View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004715Spring engineGeneralpublic2015-03-24 10:432015-04-29 01:47
ReporterGoogle_Frog Assigned Toabma  
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version98.0.1+git 
Target Version99.0 
Summary0004715: 98.0.1-457-g9736910 terrain invisible/black for some players with ati binary AND open source drivers
DescriptionSome players have invisible terrain in 98.0.1-457-g9736910. I have an infolog with settings and an ATI card so it may be ATI related.

98.0.1-451-g0804ae1 works and buildbot has no builds between the two versions.
Additional InformationAn infolog: http://pastebin.com/vWeuvTJz

Example image: http://snag.gy/PYx9R.jpg

Ticket opened on ZK tracker: https://github.com/ZeroK-RTS/Zero-K/issues/646
TagsNo tags attached.
Attached Files
infolog_98.0.1-451-g0804ae1.txt (Attachment missing)
screen00024_shadows-0.png (Attachment missing)
screen00025_shadows-2.png (Attachment missing)
infolog_adv_shading_shadows-0.txt (Attachment missing)
infolog_adv_shading_shadows-2.txt (Attachment missing)
infolog-abma.txt (Attachment missing)
Checked infolog.txt for Errors

Relationships

related to 0004740 closedabma (CodeXL) vertex shader compilation fails (ATI) 
related to 0004741 resolvedabma opengl error: glDrawRangeElements called in state where it is not allowed 

Activities

Anarchid

2015-03-26 16:42

reporter   ~0014240

https://github.com/spring/spring/commit/34f289c277d523c6eccbc74f185d2857bb56f948 seems relevant.

abma

2015-03-26 23:56

administrator   ~0014243

this error should be fixed first before investigating more:

[f=0000000] [Map Edge Extension] Error: Map Edge Extension widget: mirror shader error: Vertex shader failed to compile with the following errors:
ERROR: 0:17: error(0000164) l-value required: assign "gl_Vertex" (can't modify an input)
ERROR: 0:18: error(0000164) l-value required: assign "gl_Vertex" (can't modify an input)
ERROR: 0:31: error(0000162) Wrong operand types: no operation "&&" exists that takes a left-hand operand of type "uniform highp float" and a right operand of type "uniform highp float" (or there is no acceptable conversion)
ERROR: error(0000273) 3 compilation errors. No code generated

abma

2015-03-26 23:58

administrator   ~0014244

also an infolog.txt with this error and DebugGL = 1 could be useful...

lhog

2015-03-28 10:59

reporter   ~0014246

Here is my infolog with DebugGL = 1

https://drive.google.com/file/d/0BzWH8KJ5x7tWUjI0UWdHQ0pFZGc/view?usp=sharing

abma

2015-03-28 15:17

administrator   ~0014248

Last edited: 2015-03-28 15:21

 as log spam begins after "Mex Placement" is initialized:

[f=0000000] Mex Placement Initialised with 22 spots.
[f=0000000] Error: OpenGL: source<API> type<error> id<1000> severity<high>:
glDrawRangeElements has generated an error (GL_INVALID_OPERATION)
[f=0000000] Error: OpenGL: source<API> type<error> id<2003> severity<high>:
glDrawRangeElements failed because the currently active shader combination is invalid (GL_INVALID_OPERATION)

lhog

2015-03-28 19:32

reporter   ~0014249

As an example attached my infolog as how it looks on 451 engine (infolog_98.0.1-451-g0804ae1.txt)

abma

2015-03-29 03:13

administrator   ~0014251

does it work with /advmapshading 0 ?

(thats no solution, just to isolate the problem)

lhog

2015-03-29 10:14

reporter   ~0014252

Yes, it works fine with /advmapshading 0

abma

2015-03-30 20:50

administrator   ~0014255

does it work for you with AdvMapShading = 1 & Shadows = 0?

lhog

2015-03-30 21:11

reporter   ~0014258

Last edited: 2015-03-30 21:24

 With AdvMapShading = 1 & Shadows = 0 it looks similar except the edge between water and ground is visible (see screenshots). Also attached infologs.

EDIT: I've also cheched same engine version with BA 8.09 and result is consistent with Zero-K, i.e. I don't see map elements drawn.

abma

2015-04-01 09:01

administrator   ~0014264

i've an similar issue with the ATI opensource drivers on linux, terrain is black for me with these settings.


bisected it to https://github.com/spring/spring/commit/34f289c277d523c6eccbc74f185d2857bb56f948 , too.

abma

2015-04-01 09:11

administrator   ~0014265

see attached "infolog-abma.txt", which is very verbose

jK

2015-04-13 17:50

developer   ~0014346

Fix 9d1855cbdae23aee3e3c89af61f021fc26f88340 committed to develop branch: attempt to fix 0004715: shader failures, repo: spring changeset id: 4806

abma

2015-04-19 22:51

administrator   ~0014367

sadly this bug isn't fixed for me in 98.0.1-557-gab9cf88 :-|

Anarchid

2015-04-22 12:14

reporter   ~0014374

Last edited: 2015-04-22 12:14

 This is not anyhow zk related, but i guess that's known.

Bump because people report having it with Gravitas:

http://i.imgur.com/rT5fJUm.jpg
http://zero-k.info/Forum/Thread/14090#125725

abma

2015-04-24 18:59

administrator   ~0014383

Last edited: 2015-04-24 18:59

 as this is a release blocker:
default disable advmapshading for ati cards?

currently its default enabled:
https://springrts.com/wiki/Springsettings.cfg#AdvMapShading

lhog

2015-04-24 23:13

reporter   ~0014387

@abma, seriously? How about reverting the erroneous commit (identified quite long ago)?

<irony>
Out of curiosity what if I told you that there was a deadlock somewhere in the game startup code (it actually is), would you then disable game start-up?
</irony>

abma

2015-04-24 23:34

administrator   ~0014388

Last edited: 2015-04-24 23:35

 yes, seriously. reverting is bad as it would reintroduce 0004700.

its visual only and can be fixed later.

Google_Frog

2015-04-25 04:59

reporter   ~0014395

I would prefer broken heightmap view to an invisible map. I would like to use the last 100 or so commits to develop to fix the endgame crash and make sure that the pathing changes work.

abma

2015-04-26 03:43

administrator   ~0014399

for me no change after:
https://github.com/spring/spring/commit/5855bf1e80a5ea8f18f000600254b6f05178b47f

will try to investigate more...

abma

2015-04-29 01:43

administrator   ~0014407

Fix 30593880d415da1f074e4f15e816d6f83cc7966b committed to develop branch: fix 0004715 the bad way:
revert part of 5855bf1e80a5ea8f18f000600254b6f05178b47f, repo: spring changeset id: 4858

abma

2015-04-29 01:47

administrator   ~0014408

the fix makes me think that the [GLSL-PO::Validate] should message should be an error message, not a warning.

Issue History

Date Modified Username Field Change
2015-03-24 10:43 Google_Frog New Issue
2015-03-26 16:42 Anarchid Note Added: 0014240
2015-03-26 22:58 abma Target Version => 99.0
2015-03-26 23:56 abma Note Added: 0014243
2015-03-26 23:58 abma Note Added: 0014244
2015-03-27 08:18 abma Status new => feedback
2015-03-28 10:59 lhog Note Added: 0014246
2015-03-28 15:17 abma Note Added: 0014248
2015-03-28 15:21 abma Note Edited: 0014248
2015-03-28 19:31 lhog File Added: infolog_98.0.1-451-g0804ae1.txt
2015-03-28 19:32 lhog Note Added: 0014249
2015-03-29 03:13 abma Note Added: 0014251
2015-03-29 10:14 lhog Note Added: 0014252
2015-03-30 20:50 abma Note Added: 0014255
2015-03-30 21:10 lhog File Added: screen00024_shadows-0.png
2015-03-30 21:10 lhog File Added: screen00025_shadows-2.png
2015-03-30 21:10 lhog File Added: infolog_adv_shading_shadows-0.txt
2015-03-30 21:10 lhog File Added: infolog_adv_shading_shadows-2.txt
2015-03-30 21:11 lhog Note Added: 0014258
2015-03-30 21:24 lhog Note Edited: 0014258
2015-03-31 00:38 abma Status feedback => new
2015-04-01 09:01 abma Note Added: 0014264
2015-04-01 09:09 abma File Added: infolog-abma.txt
2015-04-01 09:11 abma Note Added: 0014265
2015-04-01 10:48 abma Summary 98.0.1-457-g9736910 terrain invisible for some players. => 98.0.1-457-g9736910 terrain invisible/black for some players with ati binary AND open source drivers
2015-04-12 01:30 abma Relationship added related to 0004740
2015-04-13 17:50 jK Changeset attached => spring develop 9d1855cb
2015-04-13 17:50 jK Note Added: 0014346
2015-04-13 17:50 jK Assigned To => jK
2015-04-13 17:50 jK Status new => resolved
2015-04-13 17:50 jK Resolution open => fixed
2015-04-19 22:49 abma Relationship added related to 0004741
2015-04-19 22:51 abma Note Added: 0014367
2015-04-19 22:51 abma Assigned To jK =>
2015-04-19 22:51 abma Status resolved => new
2015-04-22 12:14 Anarchid Note Added: 0014374
2015-04-22 12:14 Anarchid Note Edited: 0014374
2015-04-24 18:59 abma Note Added: 0014383
2015-04-24 18:59 abma Note Edited: 0014383
2015-04-24 23:13 lhog Note Added: 0014387
2015-04-24 23:34 abma Note Added: 0014388
2015-04-24 23:34 abma Note Edited: 0014388
2015-04-24 23:35 abma Note Edited: 0014388
2015-04-25 04:59 Google_Frog Note Added: 0014395
2015-04-26 03:43 abma Note Added: 0014399
2015-04-29 01:43 abma Changeset attached => spring develop 30593880
2015-04-29 01:43 abma Note Added: 0014407
2015-04-29 01:43 abma Assigned To => abma
2015-04-29 01:43 abma Status new => resolved
2015-04-29 01:47 abma Note Added: 0014408