View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000164 | Spring engine | General | public | 2006-04-25 22:31 | 2006-05-01 13:19 |
| Reporter | M2 | Assigned To | tvo | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000164: Creating sky crash with fix | ||||
| Description | I think some of the crashes that people are experienced during startup are attributed to an out of bounds access in BasicSky.cpp on line 542. ?óÔé¼?ØcloudThickness?óÔé¼?Ø consists of ?óÔé¼?ØCLOUD_SIZE*CLOUD_SIZE*4?óÔé¼?Ø elements but during the loop a element on position ?óÔé¼?ô(CLOUD_SIZE*CLOUD_SIZE-1+1)*4+3?óÔé¼?Ø is accesed which is three elements past the end of the array. | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
I will try to bump this bug since a fix didn?óÔé¼Ôäót make it to the latest version. It should be easy to fix either by changing ?óÔé¼?ô+3?óÔé¼?Ø to ?óÔé¼?ô-3?óÔé¼?Ø or the loop condition to ?óÔé¼?ôa<CLOUD_SIZE*CLOUD_SIZE-1?óÔé¼?Ø. Or maybe something else since I have not gone in deep on how the cloud generation works. And the bug tracker would be much better if all requests was resolved with some appropriate status like ?óÔé¼?ôfixed?óÔé¼?Ø ?óÔé¼?ôcould not reproduce?óÔé¼?Ø ?óÔé¼?ôby design?óÔé¼?Ø ?óÔé¼?ôadded to wish list?óÔé¼?Ø and so on. |
|
|
oops, forgot to commit :-) Anyway, I just made the array 4 elements larger and set those to zero. I don't think this causes the crashes though, because out of bounds reading usually works perfectly fine, just returns garbage. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-04-25 22:31 | M2 | New Issue | |
| 2006-04-26 14:00 | tvo | Status | new => assigned |
| 2006-04-26 14:00 | tvo | Assigned To | => tvo |
| 2006-04-26 16:01 | tvo | Assigned To | tvo => |
| 2006-04-26 16:01 | tvo | Assigned To | => tvo |
| 2006-05-01 00:44 | M2 | Note Added: 0000174 | |
| 2006-05-01 13:19 | tvo | Status | assigned => resolved |
| 2006-05-01 13:19 | tvo | Resolution | open => fixed |
| 2006-05-01 13:19 | tvo | Note Added: 0000175 |
