View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000582 | Spring engine | General | public | 2007-08-11 22:19 | 2007-08-13 10:54 |
| Reporter | Dragon45 | Assigned To | imbaczek | ||
| Priority | normal | Severity | crash | Reproducibility | sometimes |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000582: GroupAI selection/deselection crash | ||||
| Description | If i select a unit and hit select GroupAI button on its menu by accident, sometimes pressing Esc or some other method (click off it) for deselection of the button crashes the game. | ||||
| Additional Information | See infolog | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
confirmed in r4179 |
|
|
this is on a non-debug build: Program received signal SIGSEGV, Segmentation fault. 0xabababab in ?? () (gdb) bt #0 0xabababab in ?? () #1 0x00899c83 in CMouseHandler::MouseRelease () #2 0x0089ae6a in CMouseHandler::HandleSDLMouseEvent () 0000003 0x0041408f in SpringApp::Run () 0000004 0x004143cf in Run () 0000005 0x004145e1 in WinMain@16 () #6 0x008eb348 in main () (gdb) |
|
|
debug version: Program received signal SIGSEGV, Segmentation fault. 0xabababab in ?? () (gdb) bt #0 0xabababab in ?? () #1 0x0089e643 in CMouseHandler::MouseRelease (this=0xe7f7be0, x=95, y=557, button=1) at rts/Game/UI/MouseHandler.cpp:323 #2 0x0089f82a in CMouseHandler::HandleSDLMouseEvent (this=0xe7f7be0, event=@0x23fe0c) at rts/Game/UI/MouseHandler.cpp:230 0000003 0x0041420f in SpringApp::Run (this=0x23fea4, argc=1, argv=0x34288) at rts/System/Main.cpp:935 0000004 0x0041454f in Run (argc=1, argv=0x34288) at rts/System/Main.cpp:1075 0000005 0x00414761 in WinMain@16 (hInstanceIn=0x400000, hPrevInstance=0x0, lpCmdLine=0x251f32 "", nCmdShow=10) at rts/System/Main.cpp:1137 #6 0x008efd08 in main () at c:/mingw/include/c++/4.2.1/bits/stl_tree.h:421 this doesn't look good. 0xabababab is a special value set by Windows when allocating memory. if(activeReceiver){ /*323*/ activeReceiver->MouseRelease(x,y,button); activeReceiver=0; return; } I don't know what to make out of it. Maybe testing on linux will help. To reproduce the issue, just build some stuff, some units, select all and click Select AI on/off until spring crashes. Moving the mouse occasionally might help, as may pressing Esc. Don't know wheter pressing Esc alone to get rid of groupai window causes a crash. |
|
|
Here's a more reliable way to reproduce this: 1) select the commander 2) click on the Group AI button 3) repeat the previous step, but hold the LMB down 4) press ESC so the menu disappears 5) release the LMB 6) die Somewhere between 4 and 5 the activeReceiver pointer is invalidated and should probably be set to zero; one possible (but maybe not the best) place to do so is CglList::KeyPressed(): if (k == SDLK_ESCAPE) { if (cancelPlace >= 0) { place = cancelPlace; mouse->activeReceiver = 0; // ESC closes any menu Select(); return true; } } ... edit: fixed in r4182 |
|
|
r4182. btw, I wonder if there are more places like this and would those be the reason of LuaUI crashes. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-08-11 22:19 | Dragon45 | New Issue | |
| 2007-08-11 22:19 | Dragon45 | File Added: infolog.txt | |
| 2007-08-12 22:03 | imbaczek | Note Added: 0001085 | |
| 2007-08-12 22:03 | imbaczek | Status | new => confirmed |
| 2007-08-12 22:15 | imbaczek | Note Added: 0001086 | |
| 2007-08-12 23:01 | imbaczek | Note Added: 0001088 | |
| 2007-08-13 00:37 | Kloot | Note Added: 0001089 | |
| 2007-08-13 00:37 | Kloot | Note Edited: 0001089 | |
| 2007-08-13 08:58 | Kloot | Note Edited: 0001089 | |
| 2007-08-13 10:54 | imbaczek | Status | confirmed => resolved |
| 2007-08-13 10:54 | imbaczek | Resolution | open => fixed |
| 2007-08-13 10:54 | imbaczek | Assigned To | => imbaczek |
| 2007-08-13 10:54 | imbaczek | Note Added: 0001095 | |
| 2007-08-18 11:12 | imbaczek | Relationship added | related to 0000597 |
