Stop breaking lua?

Stop breaking lua?

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Post Reply
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Stop breaking lua?

Post by Forboding Angel »

I understand that some things have needed to be expanded over time etc etc, but could we please stop breaking lua in every release?
User avatar
lurker
Posts: 3842
Joined: 08 Jan 2007, 06:13

Re: Stop breaking lua?

Post by lurker »

Not really?
User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6242
Joined: 29 Apr 2005, 01:14

Re: Stop breaking lua?

Post by FLOZi »

Took me about 5 minutes to fix all S44 lua for 77. Mainly it was just updating the gadgethandler files.

In fact, the changes helped me find existing bugs that hadn't been caught under 76.
User avatar
quantum
Posts: 590
Joined: 19 Sep 2006, 22:48

Re: Stop breaking lua?

Post by quantum »

http://spring.clan-sy.com/phpbb/viewtop ... 23&t=15331

A warning time of three months and a half is fair, especially for a few minutes of work.
dizekat
Posts: 438
Joined: 07 Dec 2007, 12:10

Re: Stop breaking lua?

Post by dizekat »

Yes, precisely.
My own widgets (some written after warning) didn't even break; the only that broke was commander_ends2 and its not my widget, just widget i fixed for BA's new endgame modes. And the fix takes no time at all.
Could only be significant issue for those modders whom cant program and are using widgets and other lua code by other people. But well, thats the general problem with copypasta.
User avatar
KDR_11k
Game Developer
Posts: 8293
Joined: 25 Jun 2006, 08:44

Re: Stop breaking lua?

Post by KDR_11k »

FLOZi wrote:Took me about 5 minutes to fix all S44 lua for 77. Mainly it was just updating the gadgethandler files.
You have gadgethandler files?
User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6242
Joined: 29 Apr 2005, 01:14

Re: Stop breaking lua?

Post by FLOZi »

Yes. I know I could just include them with the VFS.
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Re: Stop breaking lua?

Post by Forboding Angel »

I'm talking about gadgets mainly. I have 8 or nine and all of them are non working. Most written by lurker and 1 or 2 by KDR. As a result I'm pretty much forked here, but that wasn't the entire point of the post.

The point was that it would be nice if lua (gadgets in particular) could stop getting broken in every release unless they really really really need to be updated.
User avatar
lurker
Posts: 3842
Joined: 08 Jan 2007, 06:13

Re: Stop breaking lua?

Post by lurker »

Fine I'll go poke them more. Did you say every single one isn't working?
User avatar
Forboding Angel
Evolution RTS Developer
Posts: 14673
Joined: 17 Nov 2005, 02:43

Re: Stop breaking lua?

Post by Forboding Angel »

Yep, I tested each and every one. They're all down for the caount.

However, I'm sure it wasn't just me suffering headaches from it. There are a lot of player widgets and old gadgets that are broken too that prolly won't get updated and tbh it's a real shame :-(

Edit: Speaking of, while it is near and dear to my heart, I know you are helping with the spring releases and whatnot, so no need to divert time to me until you have it. The engine is more important imo.
Post Reply

Return to “Engine”