Can we please get the AllowFeatureBuildStep patch released

Can we please get the AllowFeatureBuildStep patch released

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Post Reply
User avatar
TheFatController
Balanced Annihilation Developer
Posts: 1177
Joined: 10 Dec 2006, 18:46

Can we please get the AllowFeatureBuildStep patch released

Post by TheFatController »

http://springrts.com/mantis/view.php?id=1436

I'm not entirely sure why this has been left broken for so long as this call-in is crucial for BA to restore the old reclaiming formula since it was changed.

Two spring.exe releases have been made but no release to fix this issue which currently prevents resurrection of partially reclaimed corpses in BA.

The only argument for not releasing a proper patch (ie not just replacing spring.exe) is that it inconveniences the playerbase, however since ~75% of the playerbase are affected by this bug it would be reasonable to force a release though to resolve it.

Thanks
imbaczek
Posts: 3629
Joined: 22 Aug 2006, 16:19

Re: Can we please get the AllowFeatureBuildStep patch released

Post by imbaczek »

there are several reasons for why the fix for this isn't released yet:
- it wouldn't sync with 0.79
- 0.8 currently needs testing badly, there was a big merge of Tobi's lua unitscript branch which is badass but i haven't seen anybody using it, so it most likely has bugs and probably they aren't trivial
- fixing bugs in a major release takes time

IOW: wait a bit more for the planets to align. in the mean time, it'll be of great help if you could get some games going with the buildserv builds.
Master-Athmos
Posts: 916
Joined: 27 Jun 2009, 01:32

Re: Can we please get the AllowFeatureBuildStep patch released

Post by Master-Athmos »

imbaczek wrote:Tobi's lua unitscript branch
Could you please point out what exactly this is about?
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Re: Can we please get the AllowFeatureBuildStep patch released

Post by Tobi »

Makes it possible to write unit scripts, which are now always written in the legacy BOS language (COB bytecode), in Lua.

So there was lots of refactoring of the scripting related code.
Master-Athmos
Posts: 916
Joined: 27 Jun 2009, 01:32

Re: Can we please get the AllowFeatureBuildStep patch released

Post by Master-Athmos »

That sounds very interesting - is there a wiki page or something like that where you can get more info about how this works and so on? Didn't hear a word about this yet...
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Re: Can we please get the AllowFeatureBuildStep patch released

Post by Tobi »

Not yet; still working on the Lua framework side, some example scripts, testing, and writing docs :-) (only engine side (C++) code is feature complete currently)
User avatar
Argh
Posts: 10920
Joined: 21 Feb 2005, 03:38

Re: Can we please get the AllowFeatureBuildStep patch released

Post by Argh »

I'm planning on testing it when it's available, just let me know when it's a little more complete.
Master-Athmos
Posts: 916
Joined: 27 Jun 2009, 01:32

Re: Can we please get the AllowFeatureBuildStep patch released

Post by Master-Athmos »

Same for me - just drop a line when you think you have something ready for extensive testing... :-)
YokoZar
Posts: 883
Joined: 15 Jul 2007, 22:02

Re: Can we please get the AllowFeatureBuildStep patch released

Post by YokoZar »

There's something wrong with our release process if something serious like this both gets into the release and stays broken for weeks.
User avatar
hoijui
Former Engine Dev
Posts: 4344
Joined: 22 Sep 2007, 09:51

Re: Can we please get the AllowFeatureBuildStep patch released

Post by hoijui »

the thing that went wrong this time:
some people were eager to use Tobi's lua unitscript branch, and pushed him to merge it into master. He said it is kind of ready, but missing documentation. but as they all said he should merge it, he did anyway. now it is in there but is not getting tested because of lack of docu for the possible users of it (the mod devs).

the moral for today:
do not give in to greed, if it will not make you happy, and cause problems for others!

more practical:
tobi knows things better then the rest.
(except when hoijui disagrees of course, but maybe not even then.. yes then.. no!)
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Re: Can we please get the AllowFeatureBuildStep patch released

Post by Tobi »

hoijui, he's talking about AllowFeatureBuildStep.

LuaCOB is neither broken for weeks nor has it been in a release yet. ;-)

Also, FYI, all old COB functionality can already be tested, and if this works still 100% right it already proves about 50% of my work to be correct. (And besides that it would allow all mods to function properly even if the Lua part appears to be 100% broken after a release.)

Besides that, spins in reverse direction should work now and can be tested, and stopspin with deceleration also should work properly in master, and can be tested.
SeanHeron
Engines Of War Developer
Posts: 614
Joined: 09 Jun 2005, 23:39

Re: Can we please get the AllowFeatureBuildStep patch released

Post by SeanHeron »

Cool to here that "LuaCOB" is moving forwards! Great work Tobi, and whoever else is involved :).

Sean
YokoZar
Posts: 883
Joined: 15 Jul 2007, 22:02

Re: Can we please get the AllowFeatureBuildStep patch released

Post by YokoZar »

SeanHeron wrote:Cool to here that "LuaCOB" is moving forwards! Great work Tobi, and whoever else is involved :).

Sean
Agreed :)

We're gonna need to fix up a lot of unit scripts for BA at some point, and it would be much nicer to do it in LUA ;)
el_matarife
Posts: 933
Joined: 27 Feb 2006, 02:04

Re: Can we please get the AllowFeatureBuildStep patch released

Post by el_matarife »

YokoZar wrote:There's something wrong with our release process if something serious like this both gets into the release and stays broken for weeks.
I agree. I think taking a look at the release process might be a good idea, particularly from the experiences Yokozar has seen from WINE development as they did more work on their release process.
Post Reply

Return to “Engine”