| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005435 | Spring engine | General | public | 2017-01-22 08:55 | 2017-01-22 13:53 | ||||
| Reporter | cleanrock | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | random | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 103.0 +git | |||||||
| Summary | 0005435: assert(quadSize > 1.0f) triggered in CGroundFlash::CalcNormal | ||||||||
| Description | This may be a zk bug, even if so i guess spring should not crash. This assert was triggered once in my ~5 tests with Spring 103.0.1-519-g91b0000b2 develop (Debug Signal-NaNs). (gdb) bt #0 0x00007fcca115504f in raise () from /usr/lib/libc.so.6 #1 0x00007fcca115647a in abort () from /usr/lib/libc.so.6 #2 0x00007fcca114dea7 in __assert_fail_base () from /usr/lib/libc.so.6 0000003 0x00007fcca114df52 in __assert_fail () from /usr/lib/libc.so.6 0000004 0x0000000000937246 in CGroundFlash::CalcNormal (this=0x32385180, midPos=..., camDir=..., quadSize=-55) at /home/johanr/my_projects/spring/rts/Rendering/GroundFlash.cpp:96 0000005 0x0000000000939e2c in CSimpleGroundFlash::Init (this=0x32385180, owner=0x7fcc7e47c400, offset=...) at /home/johanr/my_projects/spring/rts/Rendering/GroundFlash.cpp:292 #6 0x0000000000da7b09 in CCustomExplosionGenerator::Explosion (this=0x16873630, pos=..., dir=..., damage=3.33333373e-05, radius=10, gfxMod=1, owner=0x7fcc7e47c400, hit=0x3ec52d00) at /home/johanr/my_projects/spring/rts/Sim/Projectiles/ExplosionGenerator.cpp:979 #7 0x0000000000da3a58 in CExplosionGeneratorHandler::GenExplosion (this=0x119bc2a0, expGenID=115, pos=..., dir=..., damage=3.33333373e-05, radius=10, gfxMod=1, owner=0x7fcc7e47c400, hit=0x3ec52d00) at /home/johanr/my_projects/spring/rts/Sim/Projectiles/ExplosionGenerator.cpp:369 #8 0x00000000005b3ea7 in CGameHelper::Explosion (this=0x4e9ca80, params=...) at /home/johanr/my_projects/spring/rts/Game/GameHelper.cpp:297 #9 0x0000000000e774b0 in CBeamLaser::FireInternal (this=0x325a2c00, curDir=...) at /home/johanr/my_projects/spring/rts/Sim/Weapons/BeamLaser.cpp:416 0000010 0x0000000000e76688 in CBeamLaser::FireImpl (this=0x325a2c00, scriptCall=false) at /home/johanr/my_projects/spring/rts/Sim/Weapons/BeamLaser.cpp:261 #11 0x0000000000e8948a in CWeapon::Fire (this=0x325a2c00, scriptCall=false) at /home/johanr/my_projects/spring/rts/Sim/Weapons/Weapon.cpp:1077 0000012 0x0000000000e86db7 in CWeapon::UpdateSalvo (this=0x325a2c00) at /home/johanr/my_projects/spring/rts/Sim/Weapons/Weapon.cpp:507 0000013 0x0000000000e85f99 in CWeapon::Update (this=0x325a2c00) at /home/johanr/my_projects/spring/rts/Sim/Weapons/Weapon.cpp:289 0000014 0x0000000000e760ca in CBeamLaser::Update (this=0x325a2c00) at /home/johanr/my_projects/spring/rts/Sim/Weapons/BeamLaser.cpp:196 #15 0x0000000000e61978 in CUnitHandler::Update (this=0x11832100) at /home/johanr/my_projects/spring/rts/Sim/Units/UnitHandler.cpp:297 #16 0x00000000005a397f in CGame::SimFrame (this=0x396a640) at /home/johanr/my_projects/spring/rts/Game/Game.cpp:1499 #17 0x00000000006eed89 in CGame::ClientReadNet (this=0x396a640) at /home/johanr/my_projects/spring/rts/Net/NetCommands.cpp:511 (gdb) f 5 0000005 0x0000000000939e2c in CSimpleGroundFlash::Init (this=0x32385180, owner=0x7fcc7e47c400, offset=...) at /home/johanr/my_projects/spring/rts/Rendering/GroundFlash.cpp:292 292 const float3 normal = CalcNormal(pos, camera->GetDir() * -1000.0f, size + (sizeGrowth * ttl)); (gdb) p size $3 = 20 (gdb) p sizeGrowth $4 = -1.25 (gdb) p ttl $5 = 60 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2017-01-22 13:17 |
size=20 + (sizeGrowth=-1.25 * ttl=60) = -55.0 causes a degenerate quad so at least one ZK groundflash starts life with too much ttl or excessive negative sizeGrowth. |
|
Kloot (developer) 2017-01-22 13:53 |
worked around with a clamp; degenerates will be visible as lingering 2x2 flashes |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-01-22 08:55 | cleanrock | New Issue | |
| 2017-01-22 13:17 | Kloot | Note Added: 0017105 | |
| 2017-01-22 13:53 | Kloot | Assigned To | => Kloot |
| 2017-01-22 13:53 | Kloot | Status | new => resolved |
| 2017-01-22 13:53 | Kloot | Resolution | open => fixed |
| 2017-01-22 13:53 | Kloot | Fixed in Version | => 103.0 +git |
| 2017-01-22 13:53 | Kloot | Note Added: 0017108 | |
| Issue History |