| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005188 | Spring engine | public | 2016-03-30 00:27 | 2017-04-17 00:26 | |||||
| Reporter | FabriceFABS | ||||||||
| Assigned To | |||||||||
| Priority | high | Severity | major | Reproducibility | sometimes | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 101.0+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005188: Lab stop producing units : Unit just produced got order on a non-reachable location | ||||||||
| Description | Units goes out of the lab and sometimes, they don't move and the lab unit production is stopped due to that. Unit freshly created want to go for instance on a nano, a small hill... and can't. It doesn't move and stop unit production. Tested on BA 3.35, BAR 5413 with SpringRTS 101.0.1-202. Tested with Arm T1 Veh & kBOT. **Replays** - BAR 5403 on MetalHeck-V3.2 >> http://replays.springrts.com/replay/c034f856b1a4e34f885dc8709272c339 - BAR 5403 on MetalHeck-V3.2 >> http://replays.springrts.com/replay/6837f856b1a4e34f885dc870ddd9bdd0 - BAR 5413 on BlockWars V2.5 >> http://replays.springrts.com/replay/03f4fa56283d05864a6ce07ead9cc6d2 - BAR 5413 on Metal_Hell >> http://replays.springrts.com/replay/dff6fa56f0f93e856743647d3c2de51a - BAR 5413 on SimpleWayV1 >> http://replays.springrts.com/replay/f7f9fa56aff45af14eb8fe165a1b9797 - BA 9.35 on BlockWars V2.5 >> http://replays.springrts.com/replay/ccfbfa5638ab6b904cbc6031f8789c0f - BA 9.35 on BananaValley >> http://replays.springrts.com/replay/b8fcfa5633cbddc7daf3edfa964a9bcf | ||||||||
| Steps To Reproduce | Do some nanos or units around the lab. Each thing, like small hilly too could reproduce this effect. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|||||||||||
|
|||||||||||
 Relationships |
| Notes |
|
|
silentwings (reporter) 2016-03-30 00:37 |
A thought: maybe the easiest way to approach this is to move the first of the two waypoints recieved by a unit exiting a (non-air) lab slightly further away from the lab - making it more likely that a unit would exit the lab even if its second waypoint was not reachable. |
|
abma (administrator) 2016-03-30 02:14 Last edited: 2016-03-30 02:14 |
what is the issue here? When a unit can't move out of a factory, the factory cannot produce units. thats imo correct. Are you sure a workaround at engine side should be added? AFAIK some gadget/widgets for this problem already exist?! is there an event movefailed / command failed? |
|
silentwings (reporter) 2016-03-30 09:13 Last edited: 2016-03-30 11:24 |
The engine gives two waypoints to units exiting (non-air) labs. The second of these waypoints can (quite easily, on some maps, although on most maps it would be very rare) get placed in a non-reachable location, and the first waypoint is not always close enough to cause the unit to exit its lab; with the result that the unit stays inside its lab - even if from the users point of view there is a "clear and obvious" way to exit the lab. If this was to be done by a gadget (which imo is a much worse solution, since the engine has more reliable ways of checking if a command would fail) then the engine should not place waypoints. |
|
FabriceFABS (reporter) 2016-04-12 19:56 |
Also yesterday on Tundra map : http://replays.springrts.com/replay/60190c579ca22f1e72b0e424de43facd [OOT maybe] Also yesterday, unit was struck out of the lab on Dragons : http://imolarpg.dyndns.org/trac/balatest/ticket/1111 |
|
FabriceFABS (reporter) 2016-05-17 19:34 |
Again and again on various maps... Here Dragons : http://replays.springrts.com/replay/76533b578059ac4d71abe87afb38d791 And on others maps also, I don't rememeber. |
|
hokomoko (developer) 2016-05-17 19:51 |
eh, this map can't be found anywhere |
|
abma (administrator) 2016-05-17 19:52 |
http://api.springfiles.com/?springname=Dragons+HQ+v1 ?! |
|
hokomoko (developer) 2016-05-17 19:55 |
I swear I tried this |
|
hokomoko (developer) 2016-05-17 21:39 |
FabriceFABS the issue in your replay seems to be in the factory model - the piece where the nanoframe is seems to be in a wrong direction. (I remember BA had this issue as well) |
|
FabriceFABS (reporter) 2016-05-17 22:10 |
Sorry Hoko, it's not the same problem, I reported it on dyndns already. I will pay more attention on this topic issue during next games. |
|
Anonymous (viewer) 2017-04-17 00:26 |
Fix f282c68d9c3425e0570273e7546615be04f5b778 committed to develop branch: fix 0005188 (within reason), repo: spring changeset id: 8071 |
| Notes |
| Related Changesets |
|||
|
spring: develop f282c68d
Timestamp: 2017-04-17 00:30:40 Author: rtri [ Details ] [ Diff ] |
fix 0005188 (within reason) | ||
| mod - rts/Sim/Units/UnitTypes/Factory.cpp | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-03-30 00:27 | FabriceFABS | New Issue | |
| 2016-03-30 00:37 | silentwings | Note Added: 0016127 | |
| 2016-03-30 02:14 | abma | Note Added: 0016128 | |
| 2016-03-30 02:14 | abma | Note Edited: 0016128 | View Revisions |
| 2016-03-30 09:13 | silentwings | Note Added: 0016131 | |
| 2016-03-30 09:14 | silentwings | Note Edited: 0016131 | View Revisions |
| 2016-03-30 09:15 | silentwings | Note Edited: 0016131 | View Revisions |
| 2016-03-30 10:13 | silentwings | Note Edited: 0016131 | View Revisions |
| 2016-03-30 11:24 | silentwings | Note Edited: 0016131 | View Revisions |
| 2016-04-12 19:37 | hokomoko | Relationship added | related to 0005206 |
| 2016-04-12 19:56 | FabriceFABS | Note Added: 0016181 | |
| 2016-05-17 19:34 | FabriceFABS | Note Added: 0016314 | |
| 2016-05-17 19:51 | hokomoko | Note Added: 0016315 | |
| 2016-05-17 19:52 | abma | Note Added: 0016316 | |
| 2016-05-17 19:55 | hokomoko | Note Added: 0016317 | |
| 2016-05-17 21:39 | hokomoko | Note Added: 0016320 | |
| 2016-05-17 22:10 | FabriceFABS | Note Added: 0016322 | |
| 2016-12-17 18:02 | Kloot | Relationship added | duplicate of 0005253 |
| 2017-04-17 00:26 | Changeset attached | => spring develop f282c68d | |
| 2017-04-17 00:26 | Anonymous | Note Added: 0017461 | |
| 2017-04-17 00:26 | Anonymous | Status | new => resolved |
| 2017-04-17 00:26 | Anonymous | Resolution | open => fixed |
| Issue History |