|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0005062||Spring engine||General||public||2016-02-07 14:42||2016-02-07 16:04|
|Target Version||Fixed in Version|
|Summary||0005062: EmitSfx weapon direction control problems|
|Description||The direction of weapon EmitSfx seems to no longer be based on the direction of the piece it is emitted from.|
I had an issue with the Krow in Zero-K. With the dev engine it would fire its bombs up into the sky instead of directly below it. I tried Turning the emit piece and the parent of the emit piece but it still fired into the sky. Turning Base fixed the problem but that fix made no sense and broke the rest of the unit.
This commit fixes the issue: https://github.com/ZeroK-RTS/Zero-K/commit/e812afe8497002ae8f80a1764c4e6fc735d4b035
The fix makes no sense because the position of the parent of the piece which is passed to EmitSfx should not affect the direction of the EmitSfx. If the -12 in the commit is changed to -11 the bombs shoot into the sky.
|Steps To Reproduce||To reproduce:|
* Get the appropriate ZK version, either before or after https://github.com/ZeroK-RTS/Zero-K/commit/e812afe8497002ae8f80a1764c4e6fc735d4b035
* Spawn a corcrw
* Set its land/fly state to fly.
* Give the drop bombs command (hotkey D)
A spray of missiles fire downwards from the Krow and bombard a small area about 2x the radius of the Krow.
The Krow fires a spray of missiles into the sky. They fall down and impact an area with radius about 1200 elmos (depends on map gravity).
|Additional Information||WeaponDef: https://github.com/ZeroK-RTS/Zero-K/blob/master/units/corcrw.lua#L218|
|Tags||No tags attached.|
|Checked infolog.txt for lua Errors|
Fix bac3b2f6d7970047f083123a941d3001502ea480 committed to develop branch: Fix 0005062
Be careful when multiplying a vector with a matrix, repo: spring changeset id: 6563
spring: develop bac3b2f6
Timestamp: 2016-02-07 16:07:30
Be careful when multiplying a vector with a matrix
|mod - rts/Rendering/Models/3DModel.cpp|
|2016-02-07 14:42||Google_Frog||New Issue|
|2016-02-07 15:35||hokomoko||Relationship added||duplicate of 0005061|
|2016-02-07 16:04||hokomoko||Changeset attached||=> spring develop bac3b2f6|
|2016-02-07 16:04||hokomoko||Note Added: 0015640|
|2016-02-07 16:04||hokomoko||Assigned To||=> hokomoko|
|2016-02-07 16:04||hokomoko||Status||new => resolved|
|2016-02-07 16:04||hokomoko||Resolution||open => fixed|