2025-07-22 13:53 CEST
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003326Spring engineGeneralpublic2012-11-09 16:082012-12-09 02:48
ReporterKingRaptor 
Assigned TojK 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
Product Version91.0 
Target VersionFixed in Version 
Summary0003326: Bumpwater shader broken in 91.0.1-dev
DescriptionIn Spring 91.0.1-326-g7c987d2 develop:

[Shader] Warning: [Compile]
    shader-object name: GLSL/bumpWaterCoastBlurFS.glsl, compile-log:
Fragment shader failed to compile with the following errors:
ERROR: 3:13: error(0000105) #version must occur before any other statement in the program
ERROR: error(0000273) 1 compilation errors. No code generated

If bumpwater is enabled before start, Spring will usually crash.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
+Relationships

-Notes

~0009365

Beherith (reporter)

2012-11-21 21:52

 Im testing in 91.0.1-405, and it works for me. I have nvidia though, you might want to post full infolog.

~0009428

abma (administrator)

2012-12-02 06:19

 i get a similar error with open-source drivers:

[f=0007050] Debug: /water 2
Mesa: User error: GL_INVALID_OPERATION in glProgramStringARB(invalid ARB vertex program option)

Mesa: User error: GL_INVALID_OPERATION in glProgramString(bad program)
[f=0007051] Error: [CheckParseErrors] shader compilation error at index 28 (near "program3;

PARAM mat[4] = { st") when loading vertex-program file ARB/waterDyn.vp:
line 2, char 8: error: invalid ARB vertex program option

[f=0007051] Set water rendering mode to 2 (dynamic)

Spring 91.0.1-551-g42f493b develop (Debug Sync-Trace Sync-Debug OMP)

~0009429

cleanrock (reporter)

2012-12-02 07:20

Last edited: 2012-12-02 08:15

View 2 revisions

 What driver/platform are you on ?

I suspect you have a bugged driver that barfs on the initial multiline comment.
You can try to move #version 120 to top or remove the initial comment.

~0009432

abma (administrator)

2012-12-02 09:53

 [f=0000000] SDL version: 1.2.15
[f=0000000] GL version: 2.1 Mesa 9.1-devel (git-6e33b55 quantal-oibaf-ppa)
[f=0000000] GL vendor: X.Org
[f=0000000] GL renderer: Gallium 0.4 on AMD JUNIPER
[f=0000000] GLSL version: 1.30
[f=0000000] GLEW version: 1.6.0
[f=0000000] Video RAM: unknown

Ubuntu 12.10 amd64 / opensource driver. will try your suggestion...

~0009433

abma (administrator)

2012-12-02 09:59

 hmm, i don't know what to change, there is no "#version 120" in this file:

https://github.com/spring/spring/blob/develop/cont/base/springcontent/shaders/ARB/waterDyn.vp#L2

is NV_vertex_program3 nvidia only? i've an ati card.

~0009435

cleanrock (reporter)

2012-12-02 12:26

 Sorry for confusion, i was asking KR.

Abma, I dont know much about those ARB-shaders but NV_* is most probably nvidia-specific.

~0009436

KingRaptor (reporter)

2012-12-02 13:29

 cleanrock: Win7 32 bit
[f=0000000] SDL version: 1.2.10
[f=0000000] GL version: 4.1.10600 Compatibility Profile Context
[f=0000000] GL vendor: ATI Technologies Inc.
[f=0000000] GL renderer: ATI Radeon HD 5700 Series
[f=0000000] GLSL version: 4.10
[f=0000000] GLEW version: 1.5.8
[f=0000000] Video RAM: total 734MB, available 957MB

Can't remember which Catalyst version, sorry :(

~0009443

cleanrock (reporter)

2012-12-04 07:19

 KR,
jK moved #version 120 to top of file in develop (https://github.com/spring/spring/commit/dc210fa40705f35a21d08db473f7c6f1745f1abb).
Do you have time to test if it helped ?

If the commit don't help i see two possible causes:
- some of the unusual chars (e.g. '/') in the comment triggers a driver bug
- we miss #version statements in other glsl shader files

Perhaps we should try to stick to what http://www.opengl.org/wiki/GLSL_:_recommendations#Version_Number says:
No matter what your target GL version is, it is best to put the version number at the top of each shader (vertex shader, geometry shader, fragment shader and any other shader stage).

~0009480

KingRaptor (reporter)

2012-12-07 07:45

 Same problem in 91.0.1-583-g36b77f5. Perhaps it's a driver issue?

~0009488

cleanrock (reporter)

2012-12-07 19:03

 If you have time and energy you can remove comments in bumpWaterCoastBlurFS.glsl in springcontent.sdz (perhaps springcontent.zip on windows) and see if that helps.
I suspect some characters in that first multiline comment makes ur driver unhappy.
+Notes

-Issue History
Date Modified Username Field Change
2012-11-09 16:08 KingRaptor New Issue
2012-11-21 21:52 Beherith Note Added: 0009365
2012-12-02 06:19 abma Note Added: 0009428
2012-12-02 07:20 cleanrock Note Added: 0009429
2012-12-02 08:15 cleanrock Note Edited: 0009429 View Revisions
2012-12-02 09:53 abma Note Added: 0009432
2012-12-02 09:59 abma Note Added: 0009433
2012-12-02 12:26 cleanrock Note Added: 0009435
2012-12-02 13:29 KingRaptor Note Added: 0009436
2012-12-04 07:08 cleanrock Assigned To => cleanrock
2012-12-04 07:08 cleanrock Status new => assigned
2012-12-04 07:19 cleanrock Note Added: 0009443
2012-12-04 07:19 cleanrock Status assigned => feedback
2012-12-07 07:45 KingRaptor Note Added: 0009480
2012-12-07 07:45 KingRaptor Status feedback => assigned
2012-12-07 19:03 cleanrock Note Added: 0009488
2012-12-07 19:03 cleanrock Status assigned => feedback
2012-12-09 02:48 jK Changeset attached => spring develop d2faa508
2012-12-09 02:48 jK Assigned To cleanrock => jK
2012-12-09 02:48 jK Status feedback => resolved
2012-12-09 02:48 jK Resolution open => fixed
+Issue History