2025-06-14 05:13 CEST
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002265Spring engineGeneralpublic2010-12-18 19:422011-01-01 19:46
Reporteruser744 
Assigned Toabma 
PrioritynormalSeverityblockReproducibilityalways
StatusresolvedResolutionfixed 
Product Version0.82.3+git 
Target VersionFixed in Version0.82.3+git 
Summary0002265: spring master crashes when commander is moved (xta)
Descriptionnot sure if "product version" is correct!
I installed this version:
http://springrts.com/dl/buildbot/default/master/0.82.3-1044-g2642e75/spring_0.82.3-1044-g2642e75.exe

gives lua error message and crashes when the commander starts moving.

infolog:
http://pastebin.ca/2022375

also units are black:
http://h-2.abload.de/img/screen0000009pw.png

units are not black if [x] reflective units is enabled

i always test over spring.exe without lobby, using the "Commanders" Script which does spawn an empty AI (dont know what kind)
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
duplicate of 0002244closed current spring master crashes after start when building first mex 
duplicate of 0002271closed ZK 0.82.3-1086-gf318f6e startgame crash 
+Relationships

-Notes

~0006101

Kloot (developer)

2010-12-18 20:01

 Does it crash in a mod other than XTA 9.641beta?

~0006102

user744

2010-12-18 20:17

 yes, in my own mod too when a unit is firing.
(rest (moving, building) seems to work but dark textures are there too)

~0006103

Kloot (developer)

2010-12-18 21:17

Last edited: 2010-12-18 21:53

 But do any of the existing *A mods cause Spring to crash?

(I suspect some gadget code is triggering this, because BA 7.19, etc. all work fine, so I'll take a look at http://www.file-upload.net/download-3055405/Brickcraft.sdd_CRASHEDVERSION.zip.html)

Update: tested your game with the equivalent of http://springrts.com/dl/buildbot/default/master/0.82.3-1070-g917c833/ by issuing "/give all 0" followed by "/give all 1". No crashes when units start firing or when told to move. Texture bug shows only after "/advshading 0" and entering debug view (alt+B), but can be cancelled out by "/advshading 1".

~0006106

abma (administrator)

2010-12-20 09:08

 translated:

F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x007C09C5 rts/lib/streflop/SMath.h:228
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x007C133D rts/Rendering/Models/3DModel.cpp:205
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x0093FD1A rts/Sim/Units/COB/UnitScript.h:120
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00940549 rts/Sim/Weapons/Weapon.cpp:591
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x008C39DC rts/Sim/Units/Unit.cpp:871
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x008C322D rts/Sim/Units/Unit.cpp:832
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x0089092C /usr/lib/gcc/i586-mingw32msvc/4.4.2/include/c++/bits/stl_list.h:143
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x004041DF rts/Game/Game.cpp:1777
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00447A5C rts/System/Sync/SyncChecker.h:40
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00411A70 rts/Game/Game.cpp:1003
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00995B21 rts/System/SpringApp.cpp:1070
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x009A0E1B rts/System/SpringApp.cpp:1204
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x009A40DB rts/System/Main.cpp:53
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00B8B130 /slave/mingwlibs/include/boost/thread/detail/thread.hpp:57
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00A66CC5 /home/robin/src/boost_1_42_0/libs/thread/src/win32/thread.cpp:167
E:\WINDOWS\system32\MSVCRT.dll 0x77C0A3B0 ??:0
E:\WINDOWS\system32\kernel32.dll 0x7C80B6A3 ??:0

~0006129

user744

2010-12-22 04:20

 yes, it crashes in Balanced Annihilation V7.19 too:
http://pastebin.ca/2025965
(fresh dl from http://www.springfiles.com/show_file.php?id=2795 without any custom widgets)

a few moments after moving the commander.
just scrolling around the map and waiting/doing nothing does not crash it.

~0006131

abma (administrator)

2010-12-22 15:56

 translated: (similar stacktrace)
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x007C09C5 rts/lib/streflop/SMath.h:228
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x007C0632 rts/Rendering/Models/3DModel.cpp:173
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x007C0632 rts/Rendering/Models/3DModel.cpp:173
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x007C0632 rts/Rendering/Models/3DModel.cpp:173
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x007C133D rts/Rendering/Models/3DModel.cpp:205
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x0093FD1A rts/Sim/Units/COB/UnitScript.h:120
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00940549 rts/Sim/Weapons/Weapon.cpp:591
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x008C39DC rts/Sim/Units/Unit.cpp:871
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x008C322D rts/Sim/Units/Unit.cpp:832
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x0089092C /usr/lib/gcc/i586-mingw32msvc/4.4.2/include/c++/bits/stl_list.h:143
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x004041DF rts/Game/Game.cpp:1777
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00447A5C rts/System/Sync/SyncChecker.h:40
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00411A70 rts/Game/Game.cpp:1003
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00995B21 rts/System/SpringApp.cpp:1070
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x009A0E1B rts/System/SpringApp.cpp:1204
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x009A40DB rts/System/Main.cpp:53
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00B8B130 /slave/mingwlibs/include/boost/thread/detail/thread.hpp:57
F:\Spiele\SpringCurrentMaster82_3\spring.exe 0x00A66CC5 /home/robin/src/boost_1_42_0/libs/thread/src/win32/thread.cpp:167
E:\WINDOWS\system32\MSVCRT.dll 0x77C0A3B0 ??:0
E:\WINDOWS\system32\kernel32.dll 0x7C80B6A3 ??:0

~0006133

abma (administrator)

2010-12-23 03:38

Last edited: 2010-12-23 03:42

 crashes always on my old pc here (win xp) too, with ba7.19 with/without mutator: https://github.com/abma/testmod after moving com.

self-d com works, try to switch into fps-mode crashes, building a lab without moving com crashes when lab is finished.

infolog: http://pastebin.com/4DxfV8sk
translated: http://spring-stacktrace.pastebin.com/3iAh56WQ

~0006134

abma (administrator)

2010-12-24 15:39

Last edited: 2010-12-24 15:45

 an other crash:
infolog.txt: http://pastebin.com/0xxcNxQe
translated: http://spring-stacktrace.pastebin.com/7DgvFvMx

i tested on two computers, both nvidia + windows, both crashes always (?)...

~0006136

Kloot (developer)

2010-12-24 16:09

Last edited: 2010-12-24 16:27

 Seems to be win32-only, I can't debug it. Running buildbot/default/master/0.82.3-1126-g564dc78/ in wine 1.0.1 (with ~/.springrc copied to springsettings.cfg) also does not crash on my system. To rule out a difference in configuration, can one of you pastebin your settings file?

All traces suggest corrupt/NaN values in LocalModelPiece::pos, no clue how they got there though.

~0006137

abma (administrator)

2010-12-24 16:51

Last edited: 2010-12-25 06:05

 i've bisected:

Bug seems to be introduced by this change:

https://github.com/spring/spring/commit/edf408a1b0ca5a3bacdd40e10b602a1ea934eeda

(hopefully the buildbot didn't fool me)

works:
http://springrts.com/dl/buildbot/default/master/0.82.3-989-g2a6a149/spring_0.82.3-989-g2a6a149.exe

crash:
http://springrts.com/dl/buildbot/default/master/0.82.3-990-gedf408a/spring_0.82.3-990-gedf408a.exe

~0006138

abma (administrator)

2010-12-25 06:12

 spring config: http://pastebin.com/q9YNtaqL

(should be ultra-low-setting :)

~0006139

abma (administrator)

2010-12-25 18:57

 tested with reverting the faulty commit:

https://github.com/spring/spring/commits/win32-inline-fix

it works!

~0006174

jK (developer)

2011-01-01 05:18

 again one of those strange gcc math-optimization bugs (it `optimize` the ops in such a way that it can return invalid results).
To fix it would need a testing of all math-related compiler-flags. Nothing worth it, just apply your revert imo.

~0006177

abma (administrator)

2011-01-01 19:46

 fixed by reverting: https://github.com/spring/spring/commit/e836a39fdf1454127e5d10ff7ec518d89d3ad001
+Notes

-Issue History
Date Modified Username Field Change
2010-12-18 19:42 user744 New Issue
2010-12-18 20:01 Kloot Note Added: 0006101
2010-12-18 20:01 Kloot Status new => feedback
2010-12-18 20:17 user744 Note Added: 0006102
2010-12-18 21:17 Kloot Note Added: 0006103
2010-12-18 21:18 Kloot Note Edited: 0006103
2010-12-18 21:30 Kloot Note Edited: 0006103
2010-12-18 21:48 Kloot Note Edited: 0006103
2010-12-18 21:53 Kloot Note Edited: 0006103
2010-12-20 09:08 abma Note Added: 0006106
2010-12-20 09:10 abma Relationship added related to 0002244
2010-12-22 04:20 user744 Note Added: 0006129
2010-12-22 15:56 abma Note Added: 0006131
2010-12-23 03:38 abma Note Added: 0006133
2010-12-23 03:40 abma Note Edited: 0006133
2010-12-23 03:40 abma Note Edited: 0006133
2010-12-23 03:41 abma Note Edited: 0006133
2010-12-23 03:42 abma Note Edited: 0006133
2010-12-23 15:18 abma Relationship added duplicate of 0002271
2010-12-23 15:20 abma Relationship replaced duplicate of 0002244
2010-12-24 15:33 abma Severity crash => block
2010-12-24 15:33 abma Product Version 0.82.3 => 0.82.3+git
2010-12-24 15:39 abma Note Added: 0006134
2010-12-24 15:45 abma Note Edited: 0006134
2010-12-24 16:09 Kloot Note Added: 0006136
2010-12-24 16:27 Kloot Note Edited: 0006136
2010-12-24 16:51 abma Note Added: 0006137
2010-12-25 04:47 abma Note Edited: 0006137
2010-12-25 05:04 abma Note Edited: 0006137
2010-12-25 06:01 abma Note Edited: 0006137
2010-12-25 06:05 abma Note Edited: 0006137
2010-12-25 06:12 abma Note Added: 0006138
2010-12-25 18:57 abma Note Added: 0006139
2010-12-25 22:38 abma Status feedback => confirmed
2011-01-01 05:18 jK Note Added: 0006174
2011-01-01 19:46 abma Note Added: 0006177
2011-01-01 19:46 abma Status confirmed => resolved
2011-01-01 19:46 abma Fixed in Version => 0.82.3+git
2011-01-01 19:46 abma Resolution open => fixed
2011-01-01 19:46 abma Assigned To => abma
+Issue History