View Issue Details

IDProjectCategoryView StatusLast Update
0002178Spring engineGeneralpublic2011-06-10 19:51
ReporterFLOZi Assigned Tohoijui  
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version0.82.5 
Fixed in Version0.82.7+git 
Summary0002178: Content Error is not always thrown for missing s3o textures
DescriptionWhen Spring tries to load an s3o with a missing texture, it should crash out and pop up a 'Content Error: cannot find unittextures/missingtexname.dds' type message.

Currently it does not always do this, only sometimes. I can't narrow down the situation any more than that, except that /give all may be partly responsible. When it does not pop up, it is also not in infolog.txt

When the error does correctly pop up, it does not tell you which s3o tried to load the texture, it'd be super nice if it did to make it much easier to hunt down the offender. :)
Additional InformationS44 SVN: https://spring1944.svn.sourceforge.net/svnroot/spring1944/trunk/S44Main.sdd/ rev 3125 can be used to test for this. Units GBRLZ, RUSSU122, RUST3485_Screens should crash.

N.B. This is actually with Spring 0.82.6.1, couldn't select that version when making the report. That isn't to say this is only applicable in 82.6, however.
TagsNo tags attached.
Attached Files
infolog.txt (Attachment missing)
Checked infolog.txt for Errors

Relationships

related to 0002170 resolvedabma current spring-master hangs on exit 
related to 0002228 resolvedabma Spring.exe should give more & better error messages 

Activities

FLOZi

2010-10-18 01:46

reporter   ~0005756

Sorry, I forgot to mention:
GBRLZ has model GBRLZ2.s3o which is looking for missing Civilian.dds
RUSSU122 has model RUSSU122.s3o which is looking for missing T60Tankette.dds
RUST3485_Screens has model RUST3485_Screens.s3o which is looking for missing T3485.dds

hoijui

2010-10-18 21:22

reporter   ~0005757

did a test with spring master (0.82.3-813-gd9fd2fc):
it hangs on the first content_error thrown (Gentoo 64bit).

most important (and last few) lines:
[ 516] /give all
[ 517] UnnamedPlayer added point: AP Minefield!
[ 517] UnnamedPlayer added point: AT Minefield!
[ 517] Caught content exception: Could not load S3O texture from file unittextures/Civilian.dds
[ 517] Content error Could not load S3O texture from file unittextures/Civilian.dds
[ 517] Thread error: Content error Could not load S3O texture from file unittextures/Civilian.dds

for more, see attached infolog.txt.

an additional note by FLOZi, he mentioned in chat:
it'd be nice if the error told you the s3o as well as the texture name

hoijui

2010-10-21 15:04

reporter   ~0005774

Last edited: 2010-10-21 15:12

the log message has been extended in eed732c492de8a7eed3648966099c0eef52f2485.
only the hang part of the report is remaining.

(gdb) bt
#0 0x00007ffff79673fc in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/libpthread.so.0
#1 0x00007ffff609cff9 in boost::thread::join() () from /usr/lib/libboost_thread-mt-1_41.so.1.41.0
#2 0x0000000000dec4a3 in Run (argc=1, argv=0x7fffffffdb78) at rts/System/Main.cpp:71
0000003 0x0000000000dec514 in main (argc=1, argv=0x7fffffffdb78) at rts/System/Main.cpp:89
(gdb) bt full
#0 0x00007ffff79673fc in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/libpthread.so.0
No locals.
#1 0x00007ffff609cff9 in boost::thread::join() () from /usr/lib/libboost_thread-mt-1_41.so.1.41.0
No symbol table info available.
#2 0x0000000000dec4a3 in Run (argc=1, argv=0x7fffffffdb78) at rts/System/Main.cpp:71
        ret = 0
        mainThread = 0x2473920
0000003 0x0000000000dec514 in main (argc=1, argv=0x7fffffffdb78) at rts/System/Main.cpp:89
No locals.

jK

2011-02-28 13:22

developer   ~0006454

fixed in master?

FLOZi

2011-06-10 19:47

reporter   ~0006725

Yes, fixed in master.

hoijui

2011-06-10 19:51

reporter   ~0006726

FLOZi tested it in 0.82.3-2118-gf82799a, and he reports it as fixed

Issue History

Date Modified Username Field Change
2010-10-17 23:08 FLOZi New Issue
2010-10-18 01:46 FLOZi Note Added: 0005756
2010-10-18 21:22 hoijui Note Added: 0005757
2010-10-18 21:23 hoijui File Added: infolog.txt
2010-10-18 21:24 hoijui File Deleted: infolog.txt
2010-10-18 21:24 hoijui File Added: infolog.txt
2010-10-21 15:04 hoijui Note Added: 0005774
2010-10-21 15:07 hoijui Relationship added child of 0002170
2010-10-21 15:07 hoijui Relationship deleted child of 0002170
2010-10-21 15:07 hoijui Relationship added related to 0002170
2010-10-21 15:12 hoijui Note Edited: 0005774
2010-10-21 15:12 hoijui Note Edited: 0005774
2010-11-21 21:31 abma Relationship added related to 0002228
2011-02-28 13:22 jK Note Added: 0006454
2011-02-28 13:22 jK Status new => feedback
2011-06-10 19:47 FLOZi Note Added: 0006725
2011-06-10 19:51 hoijui Note Added: 0006726
2011-06-10 19:51 hoijui Status feedback => resolved
2011-06-10 19:51 hoijui Fixed in Version => 0.82.7+git
2011-06-10 19:51 hoijui Resolution open => fixed
2011-06-10 19:51 hoijui Assigned To => hoijui