Passwords should not be shared even in hashed format

Passwords should not be shared even in hashed format

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Locked
User avatar
TradeMark
Posts: 4867
Joined: 17 Feb 2006, 15:58

Passwords should not be shared even in hashed format

Post by TradeMark »

I just noticed something reallly scary, in the replay file each player has password hash next to their nicks:

Code: Select all

password=41379EA3;
I am afraid this makes it easy to hijack other players accounts, since most probably people dont bother making super strong passwords for games in general. And i have a bad feeling that 32bits hash is waayyy too easy to crack.

But, someone please tell me why is this password hash needed to be stored there at all?

I also wonder is it possible to get any player password hash from a tweaked lobby?

If this is meant to be a way to validate players, so others cant hijack your player name when game starts, then its a really bad idea since eventually you will find almost any player password hash from replays.adune.nl or any other replays site out there. And think of me (or any other replays site) being able to collect all this information. ITS A BAD IDEA.
Kloot
Spring Developer
Posts: 1867
Joined: 08 Oct 2006, 16:58

Re: Passwords should not be shared even in hashed format

Post by Kloot »

They are not server-account password hashes. Panic attack over.
User avatar
TradeMark
Posts: 4867
Joined: 17 Feb 2006, 15:58

Re: Passwords should not be shared even in hashed format

Post by TradeMark »

What are they then?
User avatar
aegis
Posts: 2456
Joined: 11 Jul 2007, 17:47

Re: Passwords should not be shared even in hashed format

Post by aegis »

they're randomly generated and between the host and player to validate the player joining the server is the same as the player in the lobby
User avatar
TradeMark
Posts: 4867
Joined: 17 Feb 2006, 15:58

Re: Passwords should not be shared even in hashed format

Post by TradeMark »

Oh i see, *phew*, maybe the "password" is a bad name for it then. I suggest "randomhash" or something like that to prevent future panic attacks.
Locked

Return to “Engine”