Min Builddistance is too long

Min Builddistance is too long

Requests for features in the spring code.

Moderator: Moderators

Post Reply

Good idea or Bad idea?

Good idea, should be easy to fix
1
100%
Leave the code alone!
0
No votes
 
Total votes: 1

User avatar
bobthedinosaur
Blood & Steel Developer
Posts: 2702
Joined: 25 Aug 2004, 13:31

Min Builddistance is too long

Post by bobthedinosaur »

Was recently changed to a min of 128, which is way too far for some mods/ and games. Any way to get past this minimum I will be happy with. The very min should be changed to 16 since that would be distance from the center of a 1x1 to the center of another 1x1, correct?

I talked to fatcontroller and he said he also uses builddistances under 128, which are now set to 128.

Any ways heres the mantis post:
http://springrts.com/mantis/view.php?id=2151
Last edited by bobthedinosaur on 05 Mar 2011, 21:30, edited 1 time in total.
User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6241
Joined: 29 Apr 2005, 01:14

Re: Min Builddistance is too long

Post by FLOZi »

Various S44 units use distances under 128 also.
User avatar
bobthedinosaur
Blood & Steel Developer
Posts: 2702
Joined: 25 Aug 2004, 13:31

Re: Min Builddistance is too long

Post by bobthedinosaur »

I don't know if this was looked at again. If mod/game makers are making mistakes by making some distances too short, it is their own fault and other game makers shouldn't be penalized from such a generalized scale.
User avatar
hoijui
Former Engine Dev
Posts: 4344
Joined: 22 Sep 2007, 09:51

Re: Min Builddistance is too long

Post by hoijui »

test with this installer:
http://springrts.com/dl/buildbot/defaul ... a83a6b.exe

or under linux, with branch minBuildDistance on the main git repo.
slogic
AI Developer
Posts: 626
Joined: 17 Mar 2008, 19:03

Re: Min Builddistance is too long

Post by slogic »

bobthedinosaur wrote:...The very min should be changed to 16 since that would be distance from the center of a 1x1 to the center of another 1x1, correct?
If unit center is in the center of footprint then 8. Spring allows placing buildings side by side. But i think best _default_ build distance should be unit_footprint_width / 2 + single_footprint_width.
User avatar
bobthedinosaur
Blood & Steel Developer
Posts: 2702
Joined: 25 Aug 2004, 13:31

Re: Min Builddistance is too long

Post by bobthedinosaur »

so are you saying 1.5 x times width of builder?
User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6241
Joined: 29 Apr 2005, 01:14

Re: Min Builddistance is too long

Post by FLOZi »

hoijui's test with minimum of 16 was pretty badly broken.
User avatar
hoijui
Former Engine Dev
Posts: 4344
Joined: 22 Sep 2007, 09:51

Re: Min Builddistance is too long

Post by hoijui »

aha...

and now?
slogic
AI Developer
Posts: 626
Joined: 17 Mar 2008, 19:03

Re: Min Builddistance is too long

Post by slogic »

bobthedinosaur wrote:so are you saying 1.5 x times width of builder?
No: (builder_width) / 2 + 8.
User avatar
KDR_11k
Game Developer
Posts: 8293
Joined: 25 Jun 2006, 08:44

Re: Min Builddistance is too long

Post by KDR_11k »

Units are square, not circular.
User avatar
Argh
Posts: 10920
Joined: 21 Feb 2005, 03:38

Re: Min Builddistance is too long

Post by Argh »

Yeah, unit width * 3 would probably be safest, IIRC any lower than that and the pathfinder went beserk, but that was awhile ago.
User avatar
bobthedinosaur
Blood & Steel Developer
Posts: 2702
Joined: 25 Aug 2004, 13:31

Re: Min Builddistance is too long

Post by bobthedinosaur »

Would it be hard/ costly to include the size of target being built into the equation along with the builder's size?
User avatar
Niobium
Posts: 456
Joined: 07 Dec 2008, 02:35

Re: Min Builddistance is too long

Post by Niobium »

bobthedinosaur wrote:I don't know if this was looked at again. If mod/game makers are making mistakes by making some distances too short, it is their own fault and other game makers shouldn't be penalized from such a generalized scale.
Exactly this, the engine shouldn't be overriding settings of mod makers.

I think the number of formulas proposed for a formula-based approach shows the inappropriateness of a formula-based approach, in that it is unlikely to satisfy everyone/all the special cases and we end up back in square one.

In addition a formula-based approach is something which should be handled with lua in unitdefs_post, where the modmaker is free to use whatever wild formula they want in order to sanitize their buildDistances.
User avatar
bobthedinosaur
Blood & Steel Developer
Posts: 2702
Joined: 25 Aug 2004, 13:31

Re: Min Builddistance is too long

Post by bobthedinosaur »

any updates on this? the min build dis is pretty annoying for some games like Contact and S44.
User avatar
hoijui
Former Engine Dev
Posts: 4344
Joined: 22 Sep 2007, 09:51

Re: Min Builddistance is too long

Post by hoijui »

i made a test engine change, and the answer i got was apparently "it is broken", and to the question how it is broken, i got no answer. or it is something else that was broken, and nobody tested.
pro hint: read earlier posts.
User avatar
bobthedinosaur
Blood & Steel Developer
Posts: 2702
Joined: 25 Aug 2004, 13:31

Re: Min Builddistance is too long

Post by bobthedinosaur »

Can we get some more testers?

http://springrts.com/dl/buildbot/defaul ... 24f7cd.exe

For me it seems that for a practical bare minimum optimal build range a 1x1 unit building at point blank another 1x1 with builddistance of 38. Anything smaller is just not necessary. Although some small units will have to back up to build a large unit, but I have 1x1's building 10x10's easily.
Post Reply

Return to “Feature Requests”