Please include this patch before the next RC

[echoone]

Can we get this patch included before the next RC? Would be very nice to have and appears to be fairly small in size. Anyone willing to review and accept the patch?

The patch is an attachment toward the end of replies in that thread.

[BrainDamage]

this talk happened several months ago:

20:18] <BrainDamage> anyone here with dual screen? this patch could add support to decent dual screen in linux: http://springrts.com/mantis/view.php?id=16$
[20:19] <BrainDamage> the cmake patch to search for xinerama is a lil crap tho
[20:20] <spliff> wasn't xinerama obsoleted by RandR?
[20:22] <[0_0]dizekat> seconded on that
[20:24] <BrainDamage> better than current spring support
[20:26] <BrainDamage> and it seems another guy made it for windows too:
[20:26] <BrainDamage> http://springrts.com/phpbb/viewtopic.php?f=1&t=18666
[20:27] ** [Cox]Length left the channel( Quit ).
[20:27] ** MadrMan left the channel( Quit ).
[20:28] <jk`gentoo@IRC> all those patches have one i commmon: they are hacks
[20:28] <jk`gentoo@IRC> the best would be to seperate the dualscreen minimap rendering into a seperate opengl context
[20:28] <BrainDamage> the current way that spring supports dualscreen cannot be called proper either
[20:29] <jk`gentoo@IRC> and those patches don't make it any better
[20:30] <BrainDamage> howso? at least it doesn't require the user to fiddle with custom xorg.conf settings or using windowed mode and driver desktop span
[20:31] <spliff> if you have dual screen you probably have desktop span
[20:31] <spliff> otherwise why bother?
[20:31] <spliff> even TA runs dual screen if you span
[20:31] <spliff> then make the minimap moveable and it can go anywhere
[20:31] <BrainDamage> fullscreen support
[20:32] ** [Cox]Length joined the channel.
[20:32] <justa@IRC> i mean; make one big window and find out the 'physical regions' using some extension; display map; done
[20:32] <jk`gentoo@IRC> the one big window meachanism is a hack!
[20:32] <BrainDamage> and?
[20:32] <justa@IRC> lemme phrase it this way; my setup, with two equal-sized screens , it works lovely.
[20:32] <spliff> yeah but not a bad one
[20:33] <justa@IRC> for X, it IS one big screen.
[20:33] <BrainDamage> even if it's a hack, there are way worse things
[20:33] <spliff> you'd have to have different res monitors to care
[20:33] <BrainDamage> and you got a patch for free
[20:33] <BrainDamage> and it won't make current situation worse
[20:33] <jk`gentoo@IRC> it will
[20:33] <justa@IRC> it's one display.. so, not at all an issue for the X-server that it's all one OpenGL context, etc.
[20:33] <BrainDamage> you didn't say how when i asked itfp
[20:33] <jk`gentoo@IRC> most code doesn't obey ViewPosY at all!
[20:35] <jk`gentoo@IRC> also, gpu drivers can handle multiple windows much better than screen spaning

[echoone]

That's disappointing considering the argument for it is valid and the argument against inclusion, IMOHO, doesn't seem to hold much validity.

For those with two monitors and the same resolution it works. For those with two monitors and two diff resolutions (like me), it works. The current implementation is badly broken IMOHO; especially for those with two monitors at diff resolution.

Please correct me as needed, but as I read that, what I walk away with is, it works for me so tough if it doesn't work for you. Which doesn't seem right considering the patch would work for more people. Is it perfect? No! But the current implementation is even less perfect. So rejection on the basis of it not being perfect seems arbitrary.

Basically, the needless rejection means continued one screen playing. And based on the interest, it seems I'm not alone.

[Neddie]

I am in a similar situation to echoone, with two screens of different resolution. I am reasonably certain there are at least as many users in this situation, if not more, than those with twin screens. It isn't always financially feasible to purchase two screens at the same time, and it is rather myopic to assume we all have the resources at our disposal to do that if we seek a dual screen arrangement. Most people I know with some hobbyist or business motivation for multiple monitor use have multiple differing screens configured separately.

There is no reason not to substitute a better solution for a lesser preexisting one of the same general level of quality from a design standpoint. If they're both hackish, the one that provides the most functionality to the most users - assuming no great difference in downside - should be implemented.

[Gunner]

Yeah. I really want this feature. Spring multimon is a joke right now.

<justa@IRC> lemme phrase it this way; my setup, with two equal-sized screens , it works lovely.

Whenever I hear someone say "It works for me, so its good enough", I just want to punch that person in the face. I won't. But I want to.

[oksnoop2]

I would also like this.

[aegis]

someone (like me) with a compile environment could be convinced to make you a working spring exe with this patch applied

[hoijui]

if the patch would be on git, it would be much better.. its just stupid of this guy he did not want to put it there.. its like inventing cure for cancer and not telling anybody (well.. maybe not that dramatic).
when it is on git, it could be in a separate branch on the main repo, and rebased when a release is done. very little work, and source would be available to everyone -> easy to make a windows executable, even with the buildbot.
maybe someone could also enhance the patch, so it would take ViewPosY into account, like it should, according to jk. then it might even be included into master.

thing is just...
we devs do not want to do all the dirty shit for someone that made a patch that works so so ( checking, fixing, testing, cross platform checking, ...). we are trying to get the code cleaner, and including something just cause it works for most, even doh it is ugly, is not a good option. there is only him to blame, really (or if you want, everyone that does not fix the patch, which is... everyone)

[AF]

The patch failed quality standards, has a bug, and the author ignored simple procedures

[Hobo Joe]

Well I'm not familiar with everything that goes on behind the scenes with devs and coding, but I do know that current dual screen support is so bad it might as well not even be there.


I also have two monitors at different resolutions and would love to be able to use this.

[very_bad_soldier]

I have two identical screens. Please tell me how to enable span-mode in Nvidia-drivers on Windows 7 64bit if you say current dual-screen support in spring is sufficient.

[aegis]

multimon 3d vision should support it again, even if you turn off 3d vision. it's like eyefinity + 3d vision ^^

[echoone]

The patch failed quality standards, has a bug, and the author ignored simple procedures

What standards did it fail? What needs to be addressed?

What bug?

[Neddie]

The patch failed quality standards, has a bug, and the author ignored simple procedures

What standards did it fail? What needs to be addressed? What bug?

I too would like a more detailed explanation.

[zerver]

It is impossible to meet the quality standards when being judged by a troll

[oksnoop2]

I would like to know as well.

[SirMaverick]

A bug is mentioned in the other thread.

[oksnoop2]

someone (like me) with a compile environment could be convinced to make you a working spring exe with this patch applied

You seem to be the only person who is semi willing to help/actually has the ability to. Would you be willing to make this patch for all the desperate ranks who have monitors at different resolutions?

Well crap that was supposed to be a PM... oh well.