The Jazcash update!

The Jazcash update!

Discuss Lua based Spring scripts (LuaUI widgets, mission scripts, gaia scripts, mod-rules scripts, scripted keybindings, etc...)

Moderator: Moderators

User avatar
Jazcash
Posts: 5309
Joined: 08 Dec 2007, 17:39

The Jazcash update!

Post by Jazcash »

So here's the latest things annoying me:

1: Just got the latest version of Multi-threaded Spring up and running again and I noticed that still, nobody's fixed the GML error spam issue that I thought was caused by widgets retrieving player info or something...
It's the player info aspect of Ice UI that's causing it for me yet just disabling the player info element of Ice UI doesn't solve this issue.
Is there any way possible for me to stop my console being spammed with GML error messages without having to turn of Ice UI altogether?

2: Who the hell created the widget that labels every unit when a player gives everything they have to another player!? Having a widget mark more than 100 or so units all at one time causes my game to crash... And I'm running on 3.2*4 GHz here with other decent specs....
Is there anyway you can blacklist this widget from Spring or at least write a counter script to stop more than 5 labels being placed at the exact same time?
Last edited by Jazcash on 08 Dec 2012, 17:53, edited 1 time in total.
User avatar
Tribulex
A.N.T.S. Developer
Posts: 1894
Joined: 26 Sep 2009, 21:26

Re: The Jazcash update!

Post by Tribulex »

JAZCASH wrote:2: Who the hell created the widget that labels every unit when a player gives everything they have to another player!? Having a widget mark more than 100 or so units all at one time causes my game to crash... And I'm running on 3.2*4 GHz here with other decent specs....
Is there anyway you can blacklist this widget from Spring or at least write a counter script to stop more than 5 labels being placed at the exact same time?
Its the advplayerslist, which probably causes u problems with #1 as well.

At the second part, no u cant do that. u can disable your own widget, but other people will still be able to crash you (lol).
User avatar
Jazcash
Posts: 5309
Joined: 08 Dec 2007, 17:39

Re: The Jazcash update!

Post by Jazcash »

Yeh it's never my widget marking units, it's other players. The engine should limit how many labels can be placed at one time.
User avatar
Tribulex
A.N.T.S. Developer
Posts: 1894
Joined: 26 Sep 2009, 21:26

Re: The Jazcash update!

Post by Tribulex »

JAZCASH wrote:Yeh it's never my widget marking units, it's other players. The engine should limit how many labels can be placed at one time.
or perhaps the actual problem should be fixed... ie you not crashing when those points are made.
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Re: The Jazcash update!

Post by smoth »

I expected a picture of tina fey, I did not see it...



which leaves me with only one reply...











Image
User avatar
Jazcash
Posts: 5309
Joined: 08 Dec 2007, 17:39

Re: The Jazcash update!

Post by Jazcash »

User avatar
Beherith
Posts: 5145
Joined: 26 Oct 2007, 16:21

Re: The Jazcash update!

Post by Beherith »

Amazing, that guy has 0 neck. Just wow.

Btw, number 2 is annoying.
If number one annoys you so much, you can try to help by compiling spring and running a test build. It really teaches you a lot if you ever want to code in your future life. Plus its real easy to do if you just use visual studio.
Google_Frog
Moderator
Posts: 2464
Joined: 12 Oct 2007, 09:24

Re: The Jazcash update!

Post by Google_Frog »

2: Who the hell created the widget that labels every unit when a player gives everything they have to another player!? Having a widget mark more than 100 or so units all at one time causes my game to crash... And I'm running on 3.2*4 GHz here with other decent specs....
Is there anyway you can blacklist this widget from Spring or at least write a counter script to stop more than 5 labels being placed at the exact same time?
Spring.MarkerAddPoint( 0, 0, 0, "can anyone see this?",1)

That 1 at the end there is a flag for local or allies. 1 = local, 0 = allies, local will only set the marker for the player running the widget.

Someone implemented this http://springrts.com/phpbb/viewtopic.php?f=21&t=18407 but failed to tell anyone. I've got a widget with the above code in gamestart and it seems that I am the only one that can see it. I discovered it by providing incorrect params to the function.

So now there's no excuse for label spamming.
User avatar
CarRepairer
Cursed Zero-K Developer
Posts: 3359
Joined: 07 Nov 2007, 21:48

Re: The Jazcash update!

Post by CarRepairer »

Google_Frog wrote:
2: Who the hell created the widget that labels every unit when a player gives everything they have to another player!? Having a widget mark more than 100 or so units all at one time causes my game to crash... And I'm running on 3.2*4 GHz here with other decent specs....
Is there anyway you can blacklist this widget from Spring or at least write a counter script to stop more than 5 labels being placed at the exact same time?
Spring.MarkerAddPoint( 0, 0, 0, "can anyone see this?",1)

That 1 at the end there is a flag for local or allies. 1 = local, 0 = allies, local will only set the marker for the player running the widget.

Someone implemented this http://springrts.com/phpbb/viewtopic.php?f=21&t=18407 but failed to tell anyone. I've got a widget with the above code in gamestart and it seems that I am the only one that can see it. I discovered it by providing incorrect params to the function.

So now there's no excuse for label spamming.
That's an awesome feature, I also never heard of it until now. But you miss the point of the point spamming by advplayerlist. It's supposed to go to allies so they can see which units you gave them. If they were set to local then they would be meaningless. But yes, if spring lags you out from point spam then there still needs to be a solution to that.
User avatar
zwzsg
Kernel Panic Co-Developer
Posts: 7052
Joined: 16 Nov 2004, 13:08

Re: The Jazcash update!

Post by zwzsg »

It's that advplayerlist widget that should get fixed, not Spring!
User avatar
JohannesH
Posts: 1793
Joined: 07 Apr 2009, 12:43

Re: The Jazcash update!

Post by JohannesH »

The fact that too fast pointer spam crashes people should be fixed anyway though.
SirMaverick
Posts: 834
Joined: 19 May 2009, 21:10

Re: The Jazcash update!

Post by SirMaverick »

JohannesH wrote:The fact that too fast pointer spam crashes people should be fixed anyway though.
How to reproduce? If I place 10000 pointers I get 1 fps, but no crash.
User avatar
Jazcash
Posts: 5309
Joined: 08 Dec 2007, 17:39

Re: The Jazcash update!

Post by Jazcash »

SirMaverick wrote:
JohannesH wrote:The fact that too fast pointer spam crashes people should be fixed anyway though.
How to reproduce? If I place 10000 pointers I get 1 fps, but no crash.
At the same time? If you don't crash then you'd at least get 0 FPS and a frozen screen for a short while unless you're running a super computer ofc.
SirMaverick
Posts: 834
Joined: 19 May 2009, 21:10

Re: The Jazcash update!

Post by SirMaverick »

JAZCASH wrote:
SirMaverick wrote:
JohannesH wrote:The fact that too fast pointer spam crashes people should be fixed anyway though.
How to reproduce? If I place 10000 pointers I get 1 fps, but no crash.
At the same time? If you don't crash then you'd at least get 0 FPS and a frozen screen for a short while unless you're running a super computer ofc.
Yes, at same time. I just have a normal decent PC, my CPU usage is average in game.

Are you crashing? Or just freezing and then lagging out? (that's a huge difference)
User avatar
Jazcash
Posts: 5309
Joined: 08 Dec 2007, 17:39

Re: The Jazcash update!

Post by Jazcash »

SirMaverick wrote: Are you crashing? Or just freezing and then lagging out? (that's a huge difference)
Insta Crash with error.
SirMaverick
Posts: 834
Joined: 19 May 2009, 21:10

Re: The Jazcash update!

Post by SirMaverick »

What exact version are you using? (full version pls, like Spring 0.80.5.2 (0.80.5.2-0-g67e2f5b{@}-cmake-mingw32), can be found in infolog)
User avatar
Spawn_Retard
Posts: 1248
Joined: 21 Dec 2006, 14:36

Re: The Jazcash update!

Post by Spawn_Retard »

ive also tried to crash myself by using points, the only thing i can do is crash some autohosts with it, but not myself.


jaz, get a better computer.
User avatar
Jazcash
Posts: 5309
Joined: 08 Dec 2007, 17:39

Re: The Jazcash update!

Post by Jazcash »

I don't understand how it can't make you crash really. Placing 200 points at the same time means the console has to print 200 label messages, if you have the magically label widget installed you'll get 200 arrows in edge of screen and 200 white rectangles on minimap. All this at once seems a bit much tbh...

Just to confirm, you do understand that I'm talking about a 0 second delay for all this stuff to happen? I'm not talking about adding labels one by one.
SirMaverick
Posts: 834
Joined: 19 May 2009, 21:10

Re: The Jazcash update!

Post by SirMaverick »

JAZCASH wrote:I don't understand how it can't make you crash really. Placing 200 points at the same time means the console has to print 200 label messages,
Default Spring console is afaik the last point that will lag out or crash you.
if you have the magically label widget installed you'll get 200 arrows in edge of screen and 200 white rectangles on minimap. All this at once seems a bit much tbh...
I have those widgets too, (those from BA).
Just to confirm, you do understand that I'm talking about a 0 second delay for all this stuff to happen? I'm not talking about adding labels one by one.
Yes. I tested giving 200 units via adv player list (spams points too) and via a test widget (places 1000 points at once with /manypoints).
Attachments
test_points.lua
(585 Bytes) Downloaded 11 times
User avatar
Jazcash
Posts: 5309
Joined: 08 Dec 2007, 17:39

Re: The Jazcash update!

Post by Jazcash »

Hmm, it's probably MT Spring then D: My PC's powerful enough to run Crysis on top specs with no problem so I don't see why it can't handle a few labels.

Either way, I wouldn't mind if there was some way I could limit this from happening. (Without removing Adv Player List or whatever else you simplists are thinking of again :P )
Post Reply

Return to “Lua Scripts”