Copyright issues in the source files (Engine and Lobby)

[YokoZar]

I tried uploading Spring, Springlobby, and Kernel Panic to Ubuntu today, and they were rejected.

spring-engine:
I'm rejecting spring-engine, debian/copyright says it's GPL 2 but
there are plenty files under other licences, such as those in rts/lib

Also it includes FreeSansBold.otf and Arne says it should depend on
ttf-freefonts rather than installing that (which may be the case, I
didn't compile it).

springlobby:
I'm rejecting springlobby, the debian/copyright file is incomplete.
It says GPL 2 but there are files nuder other licences such as
src/libtorrent/zlib/zlib.h and src/boost/md5.cpp. I'm also not convinced
src/boost/md5.cpp is DFSL compliant.


Is this just some text out of date at the top of the source files? Do we have permission to relicense them? I'd really like to ship this in the next Ubuntu.

[koshi]

src/libtorrent/zlib/zlib.h

the whole libtorrent subdir is unnecessary on linux, otoh libtorrent-rasterbar is in buntu already

I'm also not convinced src/boost/md5.cpp is DFSL compliant.
Is this just some text out of date at the top of the source files? Do we have permission to relicense them?

I have no idea and tbh I don't wanna know. If you find a substitute and gimme a patch I'll apply it.

[YokoZar]

src/libtorrent/zlib/zlib.h

the whole libtorrent subdir is unnecessary on linux, otoh libtorrent-rasterbar is in buntu already

I'm also not convinced src/boost/md5.cpp is DFSL compliant.
Is this just some text out of date at the top of the source files? Do we have permission to relicense them?

I have no idea and tbh I don't wanna know. If you find a substitute and gimme a patch I'll apply it.

Can you just use the md5sum command built into the system? I think all Linuxes ship that these days.

[thesleepless]

err isn't boost included in ubuntu?
use the system boost rather than spring's boost?

[hoijui]

spring-engine
under rts/lib, we have the following:
* 7z : Public Domain
* gml : Public Domain
* oscpack : Public Domain
* hpiutil2 : GPL V2
* lua : The COPYRIGHT file states MIT, but the Lua homepage cited in the same file states Public Domain (http://www.lua.org/license.html)
* minizip : Public Domain
* streflop : LGPL V2.1
(i think i got all the info right, no guarantee though)

The only thing i could imagine he would see a problem with is lua.. but that would still be wrong in my eyes.
Any ideas?

The font issue is somethign for jk.

[YokoZar]

spring-engine
under rts/lib, we have the following:
* 7z : Public Domain
* gml : Public Domain
* oscpack : Public Domain
* hpiutil2 : GPL V2
* lua : The COPYRIGHT file states MIT, but the Lua homepage cited in the same file states Public Domain (http://www.lua.org/license.html)
* minizip : Public Domain
* streflop : LGPL V2.1
(i think i got all the info right, no guarantee though)

The only thing i could imagine he would see a problem with is lua.. but that would still be wrong in my eyes.
Any ideas?

The font issue is somethign for jk.

The issue is more that I just wrote "GPL v2" in the copyright file rather than being specific -- thanks for clearing that up, I'll add that to the copyright file and resubmit.


Also why does Spring ship a Boost at all? Every Linux has one you can link against.

[Tobi]

I tried uploading Spring, Springlobby, and Kernel Panic to Ubuntu today, and they were rejected.

spring-engine:
I'm rejecting spring-engine, debian/copyright says it's GPL 2 but
there are plenty files under other licences, such as those in rts/lib

Also it includes FreeSansBold.otf and Arne says it should depend on
ttf-freefonts rather than installing that (which may be the case, I
didn't compile it).

Lua and 7-zip and streflop are just like any other library: they aren't part of Spring; we aren't relicensing them, and as far as I know, they all are GPL v2 compatible.

They are just in the source because we need a patched and precisely defined configuration (Lua), no one bothered yet to change buildsystem to link to system wide installed lib (7z, minizip, oscpack?) or it isn't in any distribution and we also need precisely the same code (read: version) on all operating systems (streflop).

Feel free to replace FreeSansBold.ttf with a symlink and a dependency in the package, I don't think this matters for the engine and I do think it's infeasible to force this dependency upon all operating systems.

(What would you do when you package a Spring game which would include a ttf file in it's archive, depend on ttf-freefonts and repack the archive on install? It seems like pointless waste of time... If, in the case the file is in an archive, it would be fine, then maybe we could put it in springcontent.sdz)

[hoijui]

spring-engine does not come with boost.
springlobby contains only 2 source files from boost. The reason (i guess), is that it is more convienient like this:
the user does not have to install two additional packages on linux, and the springlobby devs dont have to supply a library package for windows. plus checking for library and library version is not needed.

[Tobi]

spring-engine
under rts/lib, we have the following:
* 7z : Public Domain
* gml : Public Domain
* oscpack : Public Domain
* hpiutil2 : GPL V2
* lua : The COPYRIGHT file states MIT, but the Lua homepage cited in the same file states Public Domain (http://www.lua.org/license.html)
* minizip : Public Domain
* streflop : LGPL V2.1
(i think i got all the info right, no guarantee though)

The only thing i could imagine he would see a problem with is lua.. but that would still be wrong in my eyes.
Any ideas?

The font issue is somethign for jk.

Hum, for me Lua license page says:

Its licenses are compatible with GPL. Lua is not in the public domain and PUC-Rio keeps its copyright.
...
Since Lua 5.0, Lua is licensed under the terms of the MIT license reproduced below.

minizip is same as zlib actually (that's close to, but not exactly, Public Domain)

Condition of use and distribution are the same than zlib :

This software is provided 'as-is', without any express or implied
warranty. In no event will the authors be held liable for any damages
arising from the use of this software.

Permission is granted to anyone to use this software for any purpose,
including commercial applications, and to alter it and redistribute it
freely, subject to the following restrictions:

1. The origin of this software must not be misrepresented; you must not
claim that you wrote the original software. If you use this software
in a product, an acknowledgment in the product documentation would be
appreciated but is not required.
2. Altered source versions must be plainly marked as such, and must not be
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.

GML is a custom license, that should be compatible with GPL (cause it allows everything except removing/changing the copyright notice). If it isn't ask zerver to change the license.

// GML - OpenGL Multithreading Library
// for Spring http://spring.clan-sy.com
// Author: Mattias "zerver" Radeskog
// (C) Ware Zerver Tech. http://zerver.net
// Ware Zerver Tech. licenses this library
// to be used freely for any purpose, as
// long as this notice remains unchanged

oscpack is not public domain AFAICS, but modified BSD (or is it MIT?)

oscpack -- Open Sound Control packet manipulation library
http://www.audiomulch.com/~rossb/code/oscpack

Copyright (c) 2004 Ross Bencina <rossb@audiomulch.com>

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files
(the "Software"), to deal in the Software without restriction,
including without limitation the rights to use, copy, modify, merge,
publish, distribute, sublicense, and/or sell copies of the Software,
and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

Any person wishing to distribute modifications to the Software is
requested to send the modifications to the original developer so that
they can be incorporated into the canonical version.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR
ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

7zip is public domain indeed

/* 7zBuf.c -- Byte Buffer
2008-03-28
Igor Pavlov
Public domain */

streflop is indeed LGPL v2.1 + notice it contains portions of libm, which also has parts licensed like this:

/*
* ====================================================
* Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
*
* Developed at SunPro, a Sun Microsystems, Inc. business.
* Permission to use, copy, modify, and distribute this
* software is freely granted, provided that this notice
* is preserved.
* ====================================================
*/

hpiutil2 is indeed GPL v2 (or any later version, actually)

[hoijui]

The real question here is only if things are GPL compatible, right?
(me giving wrong info is less important, i wanted to say )
Lua homepage says: Its licenses are compatible with GPL
are minizip/zlib and oscpack GPL compatible?

[Tobi]

The real question here is only if things are GPL compatible, right?
(me giving wrong info is less important, i wanted to say )

Nah, Debian people actually want to know exactly all licenses used in my experience, even if it's just for a 10 line file that isn't even used anymore.

Lua homepage says: Its licenses are compatible with GPL
are minizip/zlib and oscpack GPL compatible?

As far as I can see yes (but IANAL etc. etc.)

(I always try to quickly check this anyway if a new lib is added, nothing worse then having to remove a bunch of useful code cause the used library has the wrong license.)

[hoijui]

ok.. so we need that guy to specify more clearly what problems he sees with the stuff we have under rts/lib then.
In the worst case, if the only problem is oscpack, we could remove it, or at least exclude it for GPL compatible builds or something.
It is very easy to exclude it.

edit: typo

[Tobi]

Nah I think it's fine. They just want all those licenses copy pasted in the COPYRIGHT file of the package.

[Auswaschbar]

Springlobby only comes with boost::md5, that is not a part of the official boost (yet?).
And they use it instead of the system command because doing boost::md5(password) is easier than writing the password to a temporary file, running md5sum on it, checking the output and deleting that file again.

edit: maybe we should include that copyright file in the repo and keep it up-to-date there?

[koshi]

Can you just use the md5sum command built into the system? I think all Linuxes ship that these days.

No. I'd have no guarantee output (-format) is the same everywhere, system calls have a high chance of going awry in themselves and its not avial on windows.

[jcnossen]

SM3 code also has MIT or zlib license IIRC (at least something more free than GPL), so maybe someone should change that to GPL to prevent more problems.

[Auswaschbar]

Code: Select all

/*---------------------------------------------------------------------
 Terrain Renderer using texture splatting and geomipmapping

 Copyright (2006) Jelmer Cnossen
 This code is released under GPL license (See LICENSE.html for info)
---------------------------------------------------------------------*/

[jcnossen]

Hm yeah, Map/SM3/* seems to be GPL and Map/SM3/terrain/* is still zlib

[Auswaschbar]

OK, since you are the author, I take this as a permission and change the license into GPL then.

[YokoZar]

Springlobby only comes with boost::md5, that is not a part of the official boost (yet?).
And they use it instead of the system command because doing boost::md5(password) is easier than writing the password to a temporary file, running md5sum on it, checking the output and deleting that file again.

edit: maybe we should include that copyright file in the repo and keep it up-to-date there?

The debian/copyright file is already in the ppa, it's just not complete enough.