CanCrash bug

[Argh]

CanCrash re-introduced the bug into Spring, where death-animations weren't allowed to operate during the process of removing the Unit, which effected anything using CAirMoveType. Setting it to 1 or 0 did not change this, in testing.

[Warlord Zsinj]

Just set spring to CanCrash=0; that should solve the problem.

[/bad joke]

[Argh]

LOL!

If only it were that simple. I would have to keep it on the experimental "CanCrash" mode, though, just to be different.

[KDR_11k]

canCrash only changed the if statement that checks if the plane should enter crashing mode or just explode. If the death anim doesn't play it wouldn't have played without the change either.

[Argh]

It played after ILMTitan's patch... maybe I have that confused with Lurker's bit.

Either way, meh, I'm back to having all of the death-animation code for flying things broken again, anything that wants to execute past the frame of the Unit's death does not execute...

[yuritch]

Was that patch even added to svn? AFAIR all we had was a custom compiled binary, it wasn't in the trunk.

[Argh]

Ah, that must be it, it never got committed. I thought it was working after ILMTitan's patch, but I must be wrong...

[yuritch]

I just re-read that thread, and it never mentions the patch being added to svn. Someone should add it probably (but it still had some strange things left, like 'dying' air units stuck in place until Killed() returns, which may or may not be intentional).

[ILMTitan]

The changes I have made to AirMoveType so far should not have changed any functionality. It was just refactoring so I could wrap my head around what it was doing, in preparation to write an entirely new air movement class (which is what I am working on now). If it appears I broke anything, please let me know.

[Argh]

No, it was my mistake, I was confused about what did what when, been a little busy and lost track of what's officially fixed

[lurker]

Yeah, yeah, I'll wrap it up and we can get it in svn.