Copyright issues in the source files (Engine and Lobby)

[hoijui]

it would be helpfull if we knew what is missing instead of just knowing it is incompleete.

[koshi]

BSD-licensed https://sourceforge.net/projects/hashlib2plus/ would be an ok replacement for the boost:md5, yes? Or are there feelings of non compliance too?

[YokoZar]

it would be helpfull if we knew what is missing instead of just knowing it is incompleete.

I'll update the copyright file to include all the things mentioned in this thread and resubmit to see if that's good enough. He should be more specific then if there's still something missing.

[koshi]

I found a smaller replacement for the bost crap: https://sourceforge.net/projects/libmd5-rfc/
it's used in my md5_replacement branch

[YokoZar]

I found a smaller replacement for the bost crap: https://sourceforge.net/projects/libmd5-rfc/
it's used in my md5_replacement branch

Thanks koshi, this is great. If that could be merged in for your next release everything would be perfect :)

[YokoZar]

Also it includes FreeSansBold.otf and Arne says it should depend on
ttf-freefonts rather than installing that (which may be the case, I
didn't compile it).

Feel free to replace FreeSansBold.ttf with a symlink and a dependency in the package, I don't think this matters for the engine and I do think it's infeasible to force this dependency upon all operating systems.

(What would you do when you package a Spring game which would include a ttf file in it's archive, depend on ttf-freefonts and repack the archive on install? It seems like pointless waste of time... If, in the case the file is in an archive, it would be fine, then maybe we could put it in springcontent.sdz)

Can't you just make the build system search for the font at compile time and symlink to it if it's there?

[YokoZar]

I found a smaller replacement for the bost crap: https://sourceforge.net/projects/libmd5-rfc/
it's used in my md5_replacement branch

Thanks koshi, this is great. If that could be merged in for your next release everything would be perfect :)

I'm still waiting for this to be merged in, by the way. Would it help if I submitted a ticket? Thanks :)

[Auswaschbar]

Can't you just make the build system search for the font at compile time and symlink to it if it's there?

Of course we could. But we could also just ship that damn 300 KiB GPL font with the installer.

[YokoZar]

Can't you just make the build system search for the font at compile time and symlink to it if it's there?

Of course we could. But we could also just ship that damn 300 KiB GPL font with the installer.

Fair enough. I added this to the package build script:

Code: Select all

	rm debian/spring-engine/usr/share/games/spring/fonts/*
	ln -s /usr/share/fonts/truetype/freefont/FreeSansBold.ttf debian/spring-engine/usr/share/games/spring/fonts/FreeSansBold.ttf

This will break if you ever add new fonts, however (since they'll be mysteriously deleted). Is that going to happen?

[Auswaschbar]

Fair enough. I added this to the package build script:

Code: Select all

	rm debian/spring-engine/usr/share/games/spring/fonts/*
	ln -s /usr/share/fonts/truetype/freefont/FreeSansBold.ttf debian/spring-engine/usr/share/games/spring/fonts/FreeSansBold.ttf

This will break if you ever add new fonts, however (since they'll be mysteriously deleted). Is that going to happen?

It happened at least once now. Why not just delete FreeSansBold.ttf instead of every font? Ending up with a unnecessary symlink is clearly better than not beeing able to play at all

[YokoZar]

Fair enough. I added this to the package build script:

Code: Select all

	rm debian/spring-engine/usr/share/games/spring/fonts/*
	ln -s /usr/share/fonts/truetype/freefont/FreeSansBold.ttf debian/spring-engine/usr/share/games/spring/fonts/FreeSansBold.ttf

This will break if you ever add new fonts, however (since they'll be mysteriously deleted). Is that going to happen?

It happened at least once now. Why not just delete FreeSansBold.ttf instead of every font? Ending up with a unnecessary symlink is clearly better than not beeing able to play at all

Because that leaves some of the text files there but yeah who cares.