98.0 Performance - Page 2

98.0 Performance

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

User avatar
jK
Spring Developer
Posts: 2299
Joined: 28 Jun 2007, 07:30

Re: 98.0 Performance

Post by jK »

hokomoko wrote:After some profiling

I've pinpointed the main cycles hog to be the lua mutexes, but apprently the worker threads don't run any lua, so is there a need for these mutexes at the moment?

Their removal results in significant performance improvement, and from some tests I haven't seen any desyncs (even in games between a version with mutexes and one without).

Even if they're needed and I've missed something, they can probably be heavily optimised.

Thanks!
please retest with:
http://springrts.com/dl/buildbot/defaul ... d29/win32/
hokomoko
Spring Developer
Posts: 593
Joined: 02 Jun 2014, 00:46

Re: 98.0 Performance

Post by hokomoko »

https://docs.google.com/spreadsheets/d/ ... 2064064053
(look at the CritSection sheet)

I've profiled both the dev version and the dev version with locking commented out.
There's a noticeable improvement, but it's still significantly slower (Gameframe event is nearly twice as long) than having no locks.

EDIT: forgot to mention, data was averaged over 4 games each.
Post Reply

Return to “Engine”