Correc the setSFXoccupy function name,

Correc the setSFXoccupy function name,

Requests for features in the spring code.

Moderator: Moderators

Post Reply
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Correc the setSFXoccupy function name,

Post by smoth »

in "rts\Sim\Units\Scripts\LuaScriptNames.cpp"
scriptNames[LUAFN_SetSFXOccupy] = "setSFXoccupy";

needs to be:
scriptNames[LUAFN_SetSFXOccupy] = "SetSFXOccupy";

Needs correction for consistency.
User avatar
Floris
Posts: 611
Joined: 04 Jan 2011, 20:00

Re: Correc the setSFXoccupy function name,

Post by Floris »

I want to order 3 kitchens?


can I has delivery soon?
User avatar
knorke
Posts: 7971
Joined: 22 Feb 2006, 01:02

Re: Correc the setSFXoccupy function name,

Post by knorke »

Was noticed before:
http://springrts.com/phpbb/viewtopic.ph ... py#p417643
when discussed in chat iirc the result was "oh no all the scripts needs updating!" and that the real problem is the silly name and behaviour of that function.

If the name gets changed and script need to be adjusted anyway, then please not just for making small s into big S. Instead sensible name like TerrainTypeChange() or something.
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Re: Correc the setSFXoccupy function name,

Post by smoth »

Well not just the S needs correction.

Still whatever, make it a new name, just make it a better, consistent name. COB/BOS needn't change but IMO internally and Lua needs change.
User avatar
Jools
XTA Developer
Posts: 2816
Joined: 23 Feb 2009, 16:29

Re: Correc the setSFXoccupy function name,

Post by Jools »

Don't rename functiuons just for the sake if renaming, it breaks backward and forward compatibility and besides, the function works just as well even if it has a silly name or not. It's like wondering how that hamburger looks like when you have eaten it. It's better not to.
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Re: Correc the setSFXoccupy function name,

Post by smoth »

how many lua unit scripts would this break?

Maybe a few.

I was very clear that they should update the Lua only.
User avatar
Jools
XTA Developer
Posts: 2816
Joined: 23 Feb 2009, 16:29

Re: Correc the setSFXoccupy function name,

Post by Jools »

I stand corrected
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Re: Correc the setSFXoccupy function name,

Post by smoth »

So the engine developers never responded to this.
User avatar
jK
Spring Developer
Posts: 2299
Joined: 28 Jun 2007, 07:30

Re: Correc the setSFXoccupy function name,

Post by jK »

knorke wrote:Was noticed before:
http://springrts.com/phpbb/viewtopic.ph ... py#p417643
when discussed in chat iirc the result was "oh no all the scripts needs updating!" and that the real problem is the silly name and behaviour of that function.
that
Post Reply

Return to “Feature Requests”