Featureplacer discussion

[smoth]

Now to figure out what to use instead of featureplacer because that thing doesn't want to randomize rotations

Depends on the version

[Anarchid]

What i got is "featureplacer test 20" from rapid.

[smoth]

Depends on the version

What i got is "featureplacer test 20" from rapid.

amazing

[Anarchid]

That tells me very little. The linked thread contains no instructions on acquiring a better version.

I cannot infer what you were intending to say with that to any reasonable degree of certainty.

[smoth]

Forb went and "released" an incomplete version without even talking to me because he was impatient.

I was pissed off about this because he didn't even check with me about issues in feature placer before releasing. There were issues in any public version.

I am not patching the release he did because he didn't even check with me before adding stuff on my plate and he did it before I got back.

[Anarchid]

Is there a better version anywhere?

[smoth]

I don't like to back and forth on the forums so this is my last message on it unless you want to sit down with me in the lobby. I am NOT fucking playing lets peacemeal feature placer bugs in a way that eats months of my time. In 9 days I come back to investigate a few things with assimp. I'll take a look at feature placer if you need it then. Be sure to get your bugs together and if you have any reasonable request feel free to detail it.

honestly I hate anything to do with the current map system so I don't want to fuck with it. If it is critical you can fix the random rotation thing yourself because it was a simple fix IIRC so there is that. but yeah the 18th

[knorke]

Is there a better version anywhere?

No, because any discussions about it always turn into explaining basic things about spring scripting. The best version is probally in your head.

PRO TIP:
Time sink detected.
Discussing errors/mistakes in the existing "featureplacer" is useless because just by typing out what could be changed you have already made a better version. But real reason is that neither of the two peoplepersons who are always quick to spam "their" featureplacer in any thread even remotely related to features, are not open to any feedback of "their" code and so discussions are fruitless.

For example point to an obvious copypaste mistake like this:

if ( buildinglist ) then
for i,uDef in pairs(unitlist) do

and the response will be:

been there for years in feature placer, want to raise issue with it being less than perfect NOW?

Reading comprehension will be a serious problem, too:
For example post:

Putting code "outside any function" is bad practice.
For example you lose the ability to turn off your script via the enabled=false switch, because all outside-function-code is always run, no matter that switch, which can lead to annoyance.
If you want something to be executed as soon as the gadget is loaded ("=before game starts") then put it in Initialize()

and the response will only quote the first sentence will ignoring the solution:

There is not function for that. You have to put it outside of a function if you want it to run before gamestart. Unless there is a prestart() but I have not seen it and being that you HAVE NOT suggested a better alternative.

You can literally explain excactly how to do something and the next comment will tell you that it is not possible.

Or if you have bad luck some "content developer" will simply post "Nope." to your reply and bomb the thread with his years-old broken copypasta with history reaching back to Gnome's first Lua-for-loop.

Then you will have to explain solutions problems that they did not even know existed. (But first before you have to explain that there is a problem.)
And just when everything is clear, the other peopleperson appears and copypastes his version which is basically the same, has all the already solved errors and basically disregards everything that was just explained. So yes: back and forth is a waste of time when you could just update the code.
But you know, if you are unhappy about it you could just fix it up real quick you know...
It is a bit funny to call it "updating" the code as calling CreateFeature a few times is somewhat trivial, so it is like "updating a hello-world program:" There is just not much to update, there is only so many ways to read coordinates from a file and call Spring.CreateFeature.

[Anarchid]

Wow this is a loaded topic.

I guess i have what i asked though, a "no, it doesn't exist" that actually answers the question.

[gajop]

Well, have you tried https://code.google.com/p/feature-placer/ ?
Although as knorke said, looking at the code reveals some old issues: I remember reporting something similar if not the same thing with unitlist/buildinglist to FA months/years ago.

[smoth]

PRO TIP:
Time sink detected.
Discussing errors/mistakes in the existing "featureplacer" is useless because just by typing out what could be changed you have already made a better version.

This. The random bug wasn't a big deal.

I am TRYING to stay out of fooling with anything spring for another 8 days.

Wow this is a loaded topic.

I guess i have what i asked though, a "no, it doesn't exist" that actually answers the question.

Oh but there was a stable version that was completely standalone. No one wanted it outside of the mapper who requested it at the time and I don't know what I did with the files

Well, have you tried https://code.google.com/p/feature-placer/ ?
Although as knorke said, looking at the code reveals some old issues: I remember reporting something similar if not the same thing with unitlist/buildinglist to FA months/years ago.

To *forb* who forked it. In case I have ever been unclear about any of this. it wasn't about ego, it was about the fact that at the time, he didn't even check to get the latest. If had had asked, I would have but I was IN ANTARCTICA or at the very least making the huge chain of flights back at the time

[knorke]

q.e.d.

[PicassoCT]

Should have licensed it under
GPL waLoPwanatfbtwgtoaiaot


GPL with a List of People who are not allowed to modify- because they will get the original author into alot of trouble

[smoth]

It isn't about that, just that in order to update it I have to get in touch with forb who afaik is really busy with IRL and isn't a no lifer like me with the time to screw with this shit.

I spoke with gajop a bit earlier today and it seems featureplacer + his current project(can I call it by name yet gaj?) need to be in the same tool ecosystem.

So around when I get back to playing with spring(after I do my obligatory assimp work for abma) based on what he suggested I am probably going to start working on some of it's older issues and get a stable version up on github, possibly(assuming I can reach forb) propagating that onto rapid and resolving this. From there I may go on to add some new features etc depending on my whole medical thing.

I am sure knorke will peanut gallery that also but frankly I am not sure what his deal is.

[knorke]

I am probably going to start working on some of it's older issues

No need:
Others have already fixed most of it for you, when they "reviewed" ( basically rewritten every non-trivial LOC ) it in this thread: http://springrts.com/phpbb/viewtopic.php?f=23&t=32353

I did not post there because I had just previously explained everything in another thread: http://springrts.com/phpbb/viewtopic.php?f=13&t=32347 and noticed: It is no use. Falls on deaf ears.
When posting the new thread you did not even add the changes from previous thread.

By the way: FA's version, your version posted in thread and the version in your SVN are the same. (except formating etc)

That is the problem with your posts:
It is not helpful.
You do not read.
You introduce more work because now others have not only to answer the original question but also have to debunk your nonsense.

[smoth]

I am probably going to start working on some of it's older issues

No need:
Others have already fixed most of it for you, when they "reviewed" ( basically rewritten every non-trivial LOC ) it in this thread: http://springrts.com/phpbb/viewtopic.php?f=23&t=32353

I did not ask them to because that doesn't teach anything. Saying hey this is bad because and going over why is why I started the thread. I was doing it because it was one of the oldest gadgets that i have and one of the easiest examples of how to better a gadget. That isn't how I tutor people, that isn't how you teach someone, you don't say, here let me write this my way. You say, this is bad because. I don't know how code reviews are done where you work but that wasn't the thread I wanted. I still went through with it anyway.

I find your method of feedback frustrating because you wait until the last moment to say ANYTHING. Feature placer had been around for YEARS before you decided to chastise me publicly for it. I remember when I posted that code, I KNEW *KNEW* the moment I replied to the thread you would be on me like white on rice. I posted anyway because I was trying to give him an example. It was not perfect but it was an example. When I was starting in spring lua I had NOTHING like that available to me. I wasn't rude or uncooperative. I figured I would give peace a try. I was nice, you were to so I don't see why you are making a fucking ordeal over that thread.

I did not post there because I had just previously explained everything in another thread: http://springrts.com/phpbb/viewtopic.php?f=13&t=32347 and noticed: It is no use. Falls on deaf ears.

You explained it partly, and I didn't get your point. I had to get KR to translate what you were trying to say. In the end, my repo has that version, from the feedback thread. I tried to use it as a teaching exercise and I am happy you stayed out of it. If you had posted in it, there would the same type of meta discussion you started here.

When posting the new thread you did not even add the changes from previous thread.

*I* DIDN'T START THIS THREAD, THIS IS ALL IN RESPONSE TO ANARCHID'S POST. SOME MODERATOR SPLIT THIS THREAD.

By the way: FA's version, your version posted in thread and the version in your SVN are the same. (except formating etc)

That is not the GADGET that anarchid was having issues with.

Just leave this thread please. You were doing well, then something went bad irl and you are back in here raging. you don't really feel like getting into the touchy feely "blah blah" shit where I try and come to some understanding about your anger and we are not going to be friends like this. Even if your advice was unclear in the map thread, it wasn't this catty back and forth.

[knorke]

This was a meta-discussion already before I posted.

I find your method of feedback frustrating because you wait until the last moment to say ANYTHING. Feature placer had been around for YEARS before you decided to chastise me publicly for it.

I am not your personal feedback person that has to fix all your old stuff. However, when you try to push your broken copypasta-fail then I feel compelled to say something.
And no, your post was less than a "not quite perfect example", it failed to answer excactly the problems that the thread was about.
Just because your copypasta was broken does not mean others can not find working solutions.
While I was answering the question (how to spawn features before game start) you even said it is not possible.
I'm tellin' y'all it's sabotage!

[FLOZi]

This was a meta-discussion already before I posted.

I find your method of feedback frustrating because you wait until the last moment to say ANYTHING. Feature placer had been around for YEARS before you decided to chastise me publicly for it.

I am not your personal feedback person that has to fix all your old stuff. However, when you try to push your broken copypasta-fail then I feel compelled to say something.
And no, your post was less than a "not quite perfect example", it failed to answer excactly the problems that the thread was about.
Just because your copypasta was broken does not mean others can not find working solutions.
While I was answering the question (how to spawn features before game start) you even said it is not possible.
I'm tellin' y'all it's sabotage!

For quite some time spawning units and features in Initialize() didn't work.

[PicassoCT]

+1 for Beastie Boys

[knorke]

That is excactly what I mean: actually looking at the problem or posting 6 years old crap and debatting that it is ok.
There is no problem with posting something wrong: I hope nobody is discouraged from posting in fear of being wrong.
But some replies lack any effort, it is simply spam.