Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7) - Page 2

Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6242
Joined: 29 Apr 2005, 01:14

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by FLOZi »

Either the old one back or just a totally blank png would be better (to avoid obvious aspect ratio issues)
abma
Spring Developer
Posts: 3798
Joined: 01 Jun 2009, 00:08

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by abma »

User avatar
PicassoCT
Journeywar Developer & Mapper
Posts: 10454
Joined: 24 Jan 2006, 21:12

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by PicassoCT »

Can somebody please explain to me the reason behind the breaking of the weapon numbers?
Its a shitload of work to fix and a really bad practice regarding backwards compability to do so by the way. If you break something so fundamental, you put safetyguards in place, catching the case that someone - or some game has not renamed its variables, and deliver a fix.

It might not be such a big stretch for the big Players in the Spring World, but for one-mand projects, this is a nice little kick in the shins.

I demand it to be removed. Or a converter/modoption put in place, should a game obviously not follow this shenanigan of a comit. Might be that you squeeze another bit out of some godforsaken bitmask and clean up some mess, were c-arrays began with zero and weapons had to be x-1 all the time. Fine for you. Twelfe lines of if and else cut, while i have to spend a day crawling through my unitdefs and scripts.

Oh, and by the way, its not even working.
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by smoth »

PicassoCT wrote:Can somebody please explain to me the reason behind the breaking of the weapon numbers?
what are you talking about again?
User avatar
PicassoCT
Journeywar Developer & Mapper
Posts: 10454
Joined: 24 Jan 2006, 21:12

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by PicassoCT »

weapon numbers now start with zero
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by smoth »

In what interface?
User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6242
Joined: 29 Apr 2005, 01:14

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by FLOZi »

PicassoCT wrote:weapon numbers now start with zero
No they don't.

Weapon API changes are to bring all lua API calls into line with unitdefs, unit scripts (LUS) and generic lua paradigm of array indexes starting at 1.

Before you start drama, what version are you testing? There were some flaws in the initial commits (and you also need updated base content).
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by smoth »

FLOZi wrote:(you also need updated base content).
what changed in base content?
User avatar
PicassoCT
Journeywar Developer & Mapper
Posts: 10454
Joined: 24 Jan 2006, 21:12

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by PicassoCT »

I tested Spring spring_94.1.1-549-gb9f9f06

Weapon was broken, and the info i got was basically "Make a script to autorename all your weaponscripts".. and drama is what im good at. And before you get all meta about drama, just you wait till i get sa(i)d story into a game.
User avatar
FLOZi
MC: Legacy & Spring 1944 Developer
Posts: 6242
Joined: 29 Apr 2005, 01:14

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by FLOZi »

smoth wrote:
FLOZi wrote:(you also need updated base content).
what changed in base content?
unit_script.lua

@Picasso;

Who gave you that information?
User avatar
knorke
Posts: 7971
Joined: 22 Feb 2006, 01:02

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by knorke »

PicassoCT wrote:Weapon was broken, and the info i got was basically "Make a script to autorename all your weaponscripts"
gooby your mind is playing tricks! See http://springrts.com/mantis/view.php?id=3702
the example of zK at the end:
I know the gadgets were broken as well but there are so few of them that use weapon functions that I don't care. They are easy to fix.[...] Anyway, the scripts did not need to be rewritten and ZK now has the updates to unit_script.lua.
abma
Spring Developer
Posts: 3798
Joined: 01 Jun 2009, 00:08

Re: Engine Testing - 5. May 2013 (94.1.1-413-g7b0d1a7)

Post by abma »

Post Reply

Return to “Engine”