Access violation - m RANGE VECTOR

[Forboding Angel]

Halp! What is going on?

20130221_211453_EvoRTS - Delta Siege - v12_91.sdf

(228.58 KiB) Downloaded 17 times

infolog.txt

(36.02 KiB) Downloaded 18 times

[abma]

translated:

http://paste.springfiles.com/view/06c41eb8

D:\Spring\spring.exe 0x00898179 /usr/lib/gcc/i586-mingw32msvc/4.4.4/include/c++/bits/stl_vector.h:533
D:\Spring\spring.exe 0x00836715 rts/Sim/Units/Unit.cpp:721
D:\Spring\spring.exe 0x00883E42 /usr/lib/gcc/i586-mingw32msvc/4.4.4/include/c++/bits/stl_list.h:143
D:\Spring\spring.exe 0x0042CE22 rts/Game/Game.cpp:1491
D:\Spring\spring.exe 0x00462943 rts/System/Sync/SyncChecker.h:37
D:\Spring\spring.exe 0x00431245 rts/Game/Game.cpp:886
D:\Spring\spring.exe 0x00936241 rts/System/SpringApp.cpp:938
D:\Spring\spring.exe 0x0093DB5B rts/System/SpringApp.cpp:1018
D:\Spring\spring.exe 0x00924261 rts/System/Main.cpp:51
D:\Spring\spring.exe 0x009247C4 rts/System/Main.cpp:65
D:\Spring\spring.exe 0x009248E1 rts/System/Main.cpp:101
D:\Spring\spring.exe 0x009C1B99 BumpWater.cpp:0
D:\Spring\spring.exe 0x004010B4 /root/mingw/mingw32-runtime-3.15.2/build_dir/src/mingwrt-3.15.2-mingw32/crt1.c:237
D:\Spring\spring.exe 0x00401128 /root/mingw/mingw32-runtime-3.15.2/build_dir/src/mingwrt-3.15.2-mingw32/crt1.c:271
C:\Windows\syswow64\kernel32.dll 0x772033AA ??:0
C:\Windows\SysWOW64\ntdll.dll 0x77CD9EF2 ??:0
C:\Windows\SysWOW64\ntdll.dll 0x77CD9EC5 ??:0

https://github.com/spring/spring/blob/9 ... t.cpp#L721

[Forboding Angel]

Narrowed down the cause, thanks to godde.

ONLY HAPPENS IN MULTIPLAYER!

hell if I know why

Relevant replay, and infolog

The unit that causes it is this one: https://code.google.com/p/evolutionrts/ ... eldgen.lua

20130222_063915_Trefoil_v2_91.sdf

(45.18 KiB) Downloaded 8 times

infolog.txt

(38.63 KiB) Downloaded 5 times

I'm completely baffled as to what is causing this. Halp?

[Forboding Angel]

NM. Apparently spring 91 shits the bed if isshield = true is not present in a shield weapon.

[Kloot]

Forgot to add isShield?

[Forboding Angel]

Nope, removed it so that I could be compatible with spring 92. It would be nice if you guys when removing tags that break stuff, would provide a version between where having it and not having it both work then kill that tag in the next version.

However, I understand that makes maintenance a royal bitch, so I don't blame you for not doing it.

[Silentwings]

Having it there is compatible with 92, the tag isshield just wont do anything for 92.

[Forboding Angel]

In the changelog it was marked as a breaking change. IE, spring will break if this tag is there.

[FLOZi]

In the changelog it was marked as a breaking change. IE, spring will break if this tag is there.

No. Just no.

Quit while you're still behind but in visible sight, Forb.

[Forboding Angel]

Quit while you're still behind but in visible sight, Forb.

Wtf are you talking about?

! removed isShield. Use weaponType="Shield" instead!

Gtfo.

[gajop]

not sure if related:
https://github.com/spring/spring/commit ... nt-2626475

[FLOZi]

Breaking changes (!) means only that games will need to update. Having a junk tag in any defs file won't cause Spring to break, or do anything - If it did, *A mods with all their vestigial OTA junk would never run.

As it happens, this should not really have been flagged as breaking - Previously both weaponType = "Shield" and isShield = true needed to be set, now only the former.

@gajop: Not really.

[Silentwings]

Having it there is compatible with 92, the tag isshield just wont do anything for 92.

is correct. @forb: Please test before claiming stuff. You can write pretty much any "TagIMadeUpThatHasNoEffect=True" into unit/weapondefs without causing problems.

As it happens, this should not really have been flagged as breaking - Previously both weaponType = "Shield" and isShield = true needed to be set, now only the former.

I sort of agree that this shouldn't be listed as breaking, but I think that every time a tag is deprecated it is listed as a breaking change & it is often rightly so.

*A mods with all their vestigial OTA junk would never run.

It gets removed slowly

[FLOZi]

S44 has its fair share too.

[Forboding Angel]

Breaking means breaking, at least in my mind.

Then you'd be mad at me because I didn't remove some stupid tag that was causing spring to shit itself if the inverse were the case.

I can't count how many phantom bugs I have dealt with over the years due to old tags I didn't remove. Most of them winding up as sob stories and QQ and hot blooded man tears posted on this forum. You can't really blame me for taking things literally.

Moral of the story, you can't win.