Spring 89.0 - hitspheres

[PepeAmpere]

Only change around hitspheres i noticed in changelog was:

! remove modelCenterOffset tag (can now be dynamically set with Lua)

Less important thing is, why such change was done? (which place is more logical then unit definition file to set such thing? Other collision stats still stay on that place)

And now the bug: With no other change in hitspeheres behavior in changelog, i wonder some weapons dont hit the target as before. The problem appears esp. at small units - so first thing i tried to add:

Code: Select all

collisionVolumeTest = 1;

as it is suggested in devmanual. This solve the problem, but becouse of small scale of NOTA units it means adding this tag to the most of the tech1 units and def buildings (so 50-80% of all units that are built in every NOTA game). Before i do that, i want ask

1) does this setting effect much program execution, do I risk any speed/lag problems (= i dont think so that tag was intended as standard property of most of the units)

2) wasnt changed anything other in hit_unit evaluation? Becouse in new engine version, it affects all small units (doesnt matter if they were using modelCenterOffset or not)

[FLOZi]

S44 also seems to be suffering from more 'skip through' than previously also.

[Google_Frog]

The answer is that you have to lua modelCenterOffset.

[FLOZi]

Except no S44 units were even using the tag... Is the s3o file set center no longer even used?

[PepeAmpere]

The answer is that you have to lua modelCenterOffset.

No units (that have problems) are using that tag. I was talking about tag becouse it was the only mention in spring changelog that has something to do with hitspheres. Why shall I "to lua modelCenterOffset" when i was not using this feature before? The behavior of units not using it shouldnt be changed.

[Kloot]

Less important thing is, why such change was done

It's cleaner when the engine does not need to know anything about tags which Lua can dynamically set and provide defaults for.

do I risk any speed/lag problems

No, because Spring versions < 89.0 forced use of continuous hit testing for all units without a custom (non-spherical ellipsoid/box/cylinder) collision volume.

[FLOZi]

No, because Spring versions < 89.0 forced use of continuous hit testing for all units without a custom (non-spherical ellipsoid/box/cylinder) collision volume.

Well, that would explain it. I was unaware both of the previous behavior and of the change.

(And fwiw I'm probably better informed than 99% of content devs seen as I read the git log every day and check through the changelog quite meticulously whilst updating the wiki )

[PepeAmpere]

No, because Spring versions < 89.0 forced use of continuous hit testing for all units without a custom (non-spherical ellipsoid/box/cylinder) collision volume.

Well, that would explain it. I was unaware both of the previous behavior and of the change.

(And fwiw I'm probably better informed than 99% of content devs seen as I read the git log every day and check through the changelog quite meticulously whilst updating the wiki )

Yep, that would explain it. But i was reading changelog carefully and no mention there about that.