BA's customformations widget is broken in this spring

[hunterw]

try selecting about 100 units and drawing a line. luaui crashes and you have to reload.

i mantis'd it and heres what they said

Fixed in CA SVN, download the CF widget from there and disable the
mod-local version.

[lurker]

It manages to take down luaui with it?

[hunterw]

yep, have to /luaui reload every time i try and move too many units at once

severe pita

i've noticed others commenting about their luaui's crashing as well - bet its the same thing

[TheFatController]

Yeah I noticed that and saw Jk's fix in CA, there's one more bug in BA (ressurecting partially reclaimed corpses) which is waiting for the next spring release to fix so hopefully that'll be soon and I can get them both in one release.

[MR.D]

Happened to me by selecting a mix of air and ground units.

Had 23 Bladewings and 8 pyro selected, and as soon as I drew the line for the formation Blamo it crashed Luaui.

[hunterw]

man this is really annoying...can someone familiar with luas upload a hotfix so we can disable BA's crashy one? I would do it but it would take someone familiar with lua like 5 min whereas id have to look all kinds of shit up and whatnot

[Niobium]

Attached is my customformations 2 widget (The one that does attack/unload lines) with fixes to the crash

And here is link to latest (r4901) CA version of original customformations which has also been fixed: http://trac.caspring.org/export/4901/tr ... ations.lua

[hunterw]

Thanks so much man

Defenserange isn't working for me now fwiw, gonna go see what the deal is...gives an error when it tries to start up

[Niobium]

Well, turns out my customformations 2 still fails after making the fixes... Its rather hard to debug when what it does for each formation is based on what its done in the past..

Edit: I made the same changes to 'fix' mine as was done to fix the CA version, so it's possible thats broken too. Will investigate

[hunterw]

Really? I haven't crashed with yours yet. At the very least it seems at least better than BA's, since I was able to draw a line with >100 units selected.

[Niobium]

Yeah, the version I had uploaded is an improvement over the old, so for anyone who downloaded it they don't need to replace it.

[Niobium]

Scrapped my old widget, then took CAs latest widget and added attack/unload lines, haven't been able to crash it yet, so here it is.

Edit: Attachment deleted

[TheFatController]

Scrapped my old widget, then took CAs latest widget and added attack/unload lines, haven't been able to crash it yet, so here it is.

The one in CA still crashes unfortunately, SearchNewNextNodes is not 100% guaranteed to put data in unit.dists[unit.n+1], I hadn't managed to fix it myself yet either.

[Niobium]

Scrapped my old widget, then took CAs latest widget and added attack/unload lines, haven't been able to crash it yet, so here it is.

The one in CA still crashes unfortunately, SearchNewNextNodes is not 100% guaranteed to put data in unit.dists[unit.n+1], I hadn't managed to fix it myself yet either.

Yeah, that is the part that I had error when I went to fix it initially, but this was with an old version of the customformations widget, I haven't been able to get it to error with the new one, so figured something had changed..

[code32]

Around the middle of the game in the 48th minute (a duel on the map 32 * 32), possibly because of the extra buttons on a mouse click left here this error, while a second game in succession, first at me, then my friend.

[ 83614] LuaUI::RunCallIn: error = 2, MouseRelease, [string "LuaUI/Widgets/unit_customformations.lua"]:644: attempt to index local 'next_node' (a nil value)

Prompt Please what should I do?

[hunterw]

yea i finally got it to crash but only in one out of maybe 10 games...not sure the exact situation in which it happened.

[Niobium]

Well that goes to show that the CA version is also unfixed.

I looked at the original fix and applied the pattern to all other matching occurrences.

Again, it is very hard to test due to rarity. So if you do get errors again, post here, especially with the error line/description (can be found in infolog.txt)

[el_matarife]

This bug is killing me so I'm going to try your fixed version and get back to you.

[Niobium]

Another version release

Fixes attack orders sometimes not being issued when line is across uneven terrain.. Also improves other orders correctness.