Factory commands... and Lua

[Argh]

Basically, I've found a few things that, imo at least, seem to be major bugs, in terms of factory / Lua interaction:

1. You can use Spring.EditUnitCmdDesc(u, cmdID, {hidden = true}) to hide a build-menu option, but you may not show it later by setting it to false. I tried various contexts, and it just doesn't seem to work. It's specific to build-menu commands (i.e., negative numbers).

2. Same goes for disabled = true. You can disable it, you may not re-able it.

3. You cannot insert a new build command into a Unit, even if that Unit has that build command as part of it's UnitDef. IOW, if you remove it, it's gone forever.

It's weird. Hiding / showing etc. works just fine, for all command IDs in the positive range, but only works one way for negative ones.

I know that the build-menu stuff is being handled differently than other elements, but the one-way nature of it is very strange, and made what should have been a very simple task into something like 6 hours of forehead-bashing and frustration

[KDR_11k]

Hidden = false works fine for me, same for disabled. And yes, that IS on a factory.

[Argh]

For build commands, or for fakes? I looked at THIS v4, and you're not using real build commands, you're just using fakes, generated through your customParams, using an odd range based off of 31000.

Moreover, you're doing it per-team, whereas I need to do it per-Factory:

Code: Select all

local function MakeSmallAvailable(team, ud)
	for b,_ in pairs(builder) do
		for _,u in ipairs(Spring.GetTeamUnitsByDefs(team,b)) do
			local f = Spring.FindUnitCmdDesc(u, CMD_BUILD + ud)
			if f then
				Spring.EditUnitCmdDesc(u, f, {disabled = false})
			end
		end
	end
end

Fakes and other positive-numbered command IDs worked just fine, in short it's just negatives that bork.

In an ideal world, I would have just used InsertUnitCmdDesc() to put the relevant Units into my Builder's list, and been done with the whole thing in half an hour (first attempt was just basically "if builder == blah, then insert commands blah blah blah", which should have worked) but if you pass that a negative commandID, Spring gives you an error, says that the param is wrong. Just plain strange.

[KDR_11k]

It was in a test version of Gundam and that uses real build commands.

[Kloot]

Build cmdID's (not cmdDescID's, which must be >= 0) are identified via -unitDefID, nothing more. There is no CMD_BUILD command ID unless you define one yourself.

[Argh]

It was in a test version of Gundam and that uses real build commands.

You just sent Spring.EditUnitCmdDesc(u, -unitID, {disabled = false}), and it worked, for a build command? Because I'm telling you, it just didn't work for me. No error, it just didn't do anything. Same with hidden = false. And yes, I confirmed and re-confirmed the unitID and unitDefID a bazillion times, I know I was using all the right data.

[jK]

Spring.EditUnitCmdDesc(u, cmdID, {hidden = true})

Spring.EditUnitCmdDesc(u, -unitID, {disabled = false})

wiki says:
Spring.EditUnitCmdDesc( number unitID, number cmdDescID, table cmdArray ) -> nil

CmdDescID != CmdID

[Argh]

Oh.

Damn, I hate it when you're right. That's probably it. Sheesh

I guess I'll just have to re-write the damn thing then, the method I used was terrifying orkish work.

[KDR_11k]

(just use FindUnitCmdDesc...)

[lurker]

Build cmdID's (not cmdDescID's, which must be >= 0) are identified via -unitDefID, nothing more. There is no CMD_BUILD command ID unless you define one yourself.

I think that was the code from THIS.

[KDR_11k]

Yeah, that's why it's using CmdDescIds correctly .