Submitting patches

[zenzike]

I've submitted a couple very minor patches via Mantis.

I'm wondering what the submit protocol is here: of course, it would be better if I had SVN write access, rather than creating patches all the time, what's the consensus on new becoming a new dev? Should I continue to submit patches via mantis?

[Tobi]

Usually you start by submitting patches, and then if they are good enough and I get lazy I give you commit access

(That's sort of the "protocol" )

[koshi]

now that that's cleared up: whatever happened to the plans to move to a distributed scm like git?

if the repo hosting was an issue, take a look at gitosis:
http://scie.nti.st/2007/11/14/hosting-g ... secure-way

[Tobi]

Hosting isn't the issue, the issue is that when switching to new VCS (read: git, didn't look into anything else), I don't want to drag in all the pretty much unrelated crap.

IOW, I want an import of /rts, /game, /installer, /tools/unitsync and some other stuff, but I do not want e.g. /tools/MapDesigner (>50M useless binaries), /Site (unrelated to engine), /tools/upspring, etc.

This because people used to complain about the fact that they need to check out lots of unnecessary stuff with SVN, and that even while with SVN, you can check out subfolders. So I don't think it would be a good idea to make a git repo weigh in at >100M (with all the crap in it).

But I did not yet figure out a good way to import the right stuff and filter out the bloat. (still need to play a bit more with git-filter-branch tho..., it might be doable with that...)

[zenzike]

Usually you start by submitting patches, and then if they are good enough and I get lazy I give you commit access

(That's sort of the "protocol" )

Right, then I'll keep submitting patches until you give in :)

[Tobi]

Btw, maybe you could prefix patches with [patch] in mantis? I usually filter on that when I'm looking for patches to apply

(I'll fix the earlier ones myself, don't think normal users can change title.)

[zenzike]

Yep sure, no problem. I noticed that that's what I ought to be doing after I submitted, sorry! :$

[imbaczek]

at the very least we can spend some time with rebase --interactive to weed out unneeded commits. (i think you can easily list commits touching only certain paths, so this process doesn't have to be tedious.)

[hoijui]

Btw, maybe you could prefix patches with [patch] in mantis?
(I'll fix the earlier ones myself, don't think normal users can change title.)

no we can not change titles, and i did the same like zenzike; noticing that [patch] should be prefixed after submitting. my patch 0000655 is such one btw. very small, very minor, wiating since a long time already