Global using namespace pollution

[zenzike]

I've noticed a few places where

Code: Select all

using namespace std;

is used in header files. Is it me being picky, or should we not avoid doing this? I was pretty flumoxed earlier when I didn't have to write

Code: Select all

std::string

to define a string, and pretty horrified to see people using namespaces that fed through globally.

[Tobi]

We should avoid doing that. Personally I don't really mind if you use

Code: Select all

using namespace std;

in a .cpp file, but it's really bad indeed in a header file.

Feel free to submit a patch to correct it.

[zenzike]

Feel free to submit a patch to correct it.

Where should I submit? I don't have svn access...

[KDR_11k]

Create a .patch file and post it somewhere, preferrably in Mantis.

[zenzike]

Patch submitted.

Quite a few header files across the board had included using namespace std. I've removed all occurrences and modified the headers so that they use std:: statements as appropriate. I've also modified cpp files so that they have using namespace if they require it.

I've made no attempt to rectify the situation in the Global/AI/ folder; there are many uses of using namespace std in header files there, but since they're library files, I don't think it's such a problem.