TAS Server protocol changes

TAS Server protocol changes

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

TAS Server protocol changes

Post by Tobi »

For those of you who did not notice it yet, there have been some protocol changes committed in the SVN the last week.

Look here for documentation about these changes. (Open in IE, Firefox (at least mine) doesn't apply XML stylesheet to it.)

You want to search for SETSCRIPTTAGS, which was added. It replaces UPDATEBATTLEDETAILS, and provides much more flexibility then that.

Also some arguments where removed from OPENBATTLE and JOINBATTLE and two more ranks were added.

On buildbot.no-ip.org:8200 runs the latest version of TASServer (r4719).

I hope to have informed you enough with this information, of course you can always post questions here.
Betalord
Former Engine Dev
Posts: 543
Joined: 29 Jun 2005, 09:31

Post by Betalord »

If you want to see XML formated document, you must rather open:
http://spring.clan-sy.com:8202/lobby/pr ... iption.xml

All the changes are mentioned at the beginning, in "Recent Changes" section :)
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

New startpos type added: "choose before battle" (type 3). These change affects following commands: OPENBATTLE, JOINBATTLE.
What does this mean? And how do we use it?

There's been some talk over incompatibilities with the new TASServer command and the extra parameter yet I can't see why that would be the case, is there a required response that's missing?

Your documentation does not explain the [] syntax used in the protocol description.

Is there any word on reduction of the protocols size? The description itself is incomplete yet its 28 A4 pages long.
Betalord
Former Engine Dev
Posts: 543
Joined: 29 Jun 2005, 09:31

Post by Betalord »

AF wrote:What does this mean? And how do we use it?
It's a new game mode option where you get to pick start positions in the lobby rather than in-game. Tobi will have to explain it more in detail as I wouldn't really know.
AF wrote:There's been some talk over incompatibilities with the new TASServer command and the extra parameter yet I can't see why that would be the case, is there a required response that's missing?
See the protocol description, there was 1 extra argument added.
AF wrote:Your documentation does not explain the [] syntax used in the protocol description.
[] stands for "optional" arguments.
AF wrote:Is there any word on reduction of the protocols size? The description itself is incomplete yet its 28 A4 pages long.
Not sure what you mean by that?
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

Open the protocol description then go to file menu->print preview and it'll show up as 28 pages of A4 paper.
User avatar
Neddie
Community Lead
Posts: 9406
Joined: 10 Apr 2006, 05:05

Post by Neddie »

300 and 1000 hours? What are the icons?
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

For TASClient, the same as star rank only the 300 icon has the lower half bronze, and the 1k hour is all bronze.

Springlobby rank pics cna be found in their svn.

All 16 AFLobby ranks can be found somewhere.
Betalord
Former Engine Dev
Posts: 543
Joined: 29 Jun 2005, 09:31

Post by Betalord »

AF wrote:Open the protocol description then go to file menu->print preview and it'll show up as 28 pages of A4 paper.
I understand that part, but not the "reduction" part.
neddiedrow wrote:300 and 1000 hours? What are the icons?
Ask Satirik (I can't find them in SVN at least), this is his doing :)
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

AF wrote:
New startpos type added: "choose before battle" (type 3). These change affects following commands: OPENBATTLE, JOINBATTLE.
What does this mean? And how do we use it?
http://spring.clan-sy.com/phpbb/viewtop ... 824#213824
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

pah we need a proper description of all of this with basic examples.


Aa lobby protocol shouldn't take up 28 pages. Granted the first 2 pages are the recent changes and initial description, but that's still 26 pages of commands, and suggests a lot of redundancy for such an inflexible protocol.
Satirik
Lobby Developer
Posts: 1688
Joined: 16 Mar 2007, 18:27

Post by Satirik »

AF wrote:For TASClient, the same as star rank only the 300 icon has the lower half bronze, and the 1k hour is all bronze.

Springlobby rank pics cna be found in their svn.

All 16 AFLobby ranks can be found somewhere.
you really think it's bronze ?
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

It could be gold but I don't know the exact composition of the neurons in your brain that control your specific perception of colour so there's little point in dithering over it.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

AF wrote:pah we need a proper description of all of this with basic examples.
Look in the docs, it's full of examples.

Open TASClient and press Ctrl+shift+f6 and there you go, a real world example.
Aa lobby protocol shouldn't take up 28 pages. Granted the first 2 pages are the recent changes and initial description, but that's still 26 pages of commands, and suggests a lot of redundancy for such an inflexible protocol.
RFC1459 is 65 pages and RFC2812 is 63 pages.
Last edited by Tobi on 09 Nov 2007, 09:29, edited 1 time in total.
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

There are no examples for anything save for the protocol commands themselves. Anything done via a protocol command that isn't a direct static parameter requires the user to figure it out for themselves.


That and IRC rfcs are far more verbose in describing each command.



For those who don't know, the re-ordering of users in the script has been moved into spring.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

Feel free to submit a patch.
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

Does anybody see a problem there? Like asking a school child to write a reference book on the subject they're being taught before they learn it?
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

Actually you made a lobby already, not I, so you are the one who can give good examples, not I.
Last edited by Tobi on 07 Nov 2007, 10:55, edited 1 time in total.
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

I made a lobby yes, but that was before you made these changes. You'll notice that no changes to my lobby have occurred since the protocol changes were actually made, so its a moot point.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

Then what do you not understand? Maybe that would be a more useful question to ask then complaining about the 28 pages of lobby protocol doc?

Seriously Satirik has already implemented the changes without first complaining for 10 posts.
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

1: Satirik has had direct discussions with betalord and some of the changes are at satiriks request, so satirik does not have this issue because he ahd a direct chance to ask how.

However it seems everybody else has to go to the lengths of figuring it all out themselves, which is stupid as it shouldnt take more than a single sentence to explain it, yet the lengths needed to retrieve the version of satiriks lobby and test run it to observe it in action are much greater.

2: Your muddling up 2 different things into 1 sole thing and then complaining that it makes no sense.

My suggestion that the 28 page protocol should be streamlined to get rid of redundancies, is not the same as my inquiry as to examples of the new protocol in practice.

The protocol description (which btw needs updating to reflect trepans changes that fix null value stuff such as the user of the '=' key value separator) makes no mention of what the new start position does or how it's to be used save what its name implies.

Simply saying that we should root through a daily build svn folder pull out an installer, download 40MB+, install it, run it after changing to the test server, sift through pages of raw traffic logs to identify whats different, close and uninstall, then restore the registry keys to point to the old 0.75b2 folder to prevent future installers messing up, all so we can discover something that could probably said in a one liner post is ridiculous and insulting.
Post Reply

Return to “Engine”