bonusShield is dead! Long live flankingBonus!

Post by **det** » 20 Jul 2007, 21:13

el_matarife wrote:I'm just guessing all this code came from SJ's 19th century RTS Spring was initially based on. Still, it is absolutely mindblowing that 3000+ revisions of the codebase later we just now found this. Anyone want to get in touch with SJ and ask him if there's any other skeletons in the closet we should know about?

Here's one: If a unit is captured, all further captures will only take 50% as long.

Code: Select all

curCapture->captureProgress=0.5f;	//make units somewhat easier to capture back after first capture

el_matarife · Post by **el_matarife** » 20 Jul 2007, 21:59

det wrote: Here's one: If a unit is captured, all further captures will only take 50% as long.
Code: Select all
curCapture->captureProgress=0.5f;	//make units somewhat easier to capture back after first capture

I assume this is for rolling back in and recapturing a base. This will need to be mod defined or even just commented out and removed.

The good news about that old code is that not too many people capture stuff, so it probably doesn't result in many balance issues right now.

lurker wrote:Okay then. Screw hours of bugfixing on a new class or files or whatever, modders can use quick scripts to multiply damage and set bonusshieldmode to 0 if they want. Expect the patch a couple hours after I wake up.

I'm glad you decided to removing the BonusShield thing, it must be responsible for a lot of weird damage behavior. Just watch when all the mods suddenly become much more balanced when they actually can figure what is going on with damage.

Andrej · Post by **Andrej** » 20 Jul 2007, 23:04

http://desu.no-ip.info/scx1/spartaaaa.gif

how do i maeek hitspharr!?

lurker · Post by **lurker** » 21 Jul 2007, 01:36

el_matarife wrote:I'm glad you decided to removing the BonusShield thing, it must be responsible for a lot of weird damage behavior. Just watch when all the mods suddenly become much more balanced when they actually can figure what is going on with damage.

Actually, I'm leaving it on by default, as to not screw up balance of existing mods, but modders can pretty easily add the single line of bonusshieldmode=0 to their .fbis when balancing.

The patch is finished except for a few minutes of documentation, but I didn't get the confirmation email when I signed up for Mantis. Can someone fix this? If not, I guess I'll just post it here and bug people later about Mantis.

Peet · Post by **Peet** » 21 Jul 2007, 01:45

lurker wrote: the single line of bonusshieldmode=0 to their .fbis when balancing.

Could it be set as a global thing in the modinfo tdf perchance?

Caydr · Post by **Caydr** » 21 Jul 2007, 03:14

When will this change be implemented? I'd like to get my hands on this as soon as possible.

Peet wrote:
lurker wrote: the single line of bonusshieldmode=0 to their .fbis when balancing.
Could it be set as a global thing in the modinfo tdf perchance?

Should be per-unit imo... simple to mass-add a tag.

lurker · Post by **lurker** » 21 Jul 2007, 04:01

Caydr wrote:When will this change be implemented? I'd like to get my hands on this as soon as possible.

Peet wrote:
lurker wrote: the single line of bonusshieldmode=0 to their .fbis when balancing.
Could it be set as a global thing in the modinfo tdf perchance?
Should be per-unit imo... simple to mass-add a tag.

Caydr: the next version? Or you could grab an SVN release. If you mean when will it be in the SVN, it could be just a day or two.

Peet: See the part about hours of WTF and bugfixing? Add the fact that using an existing file might break things, and that mass tags aren't very hard, and it's not worth it.

Argh · Post by **Argh** » 30 Aug 2007, 18:32

Just asking... this will be in the next version, right?

KDR_11k · Post by **KDR_11k** » 31 Aug 2007, 10:22

Probably not.

Tobi · Post by **Tobi** » 31 Aug 2007, 13:24

Why not?

KDR_11k · Post by **KDR_11k** » 31 Aug 2007, 14:45

Did Lurker finish the code yet?

lurker · Post by **lurker** » 31 Aug 2007, 20:18

>_>
<_<
I'll have a patch without armorzones this weekend.

Peet · Post by **Peet** » 05 Sep 2007, 17:35

Yeah, and I'll texture simbase by tomorrow...

KDR_11k · Post by **KDR_11k** » 05 Sep 2007, 17:42

I'd be satisfied if you could just release a26 tomorrow...

Peet · Post by **Peet** » 05 Sep 2007, 19:35

Would have by now if my damn mobo hadn't died.

<---------no longer an asus fan

lurker · Post by **lurker** » 07 Sep 2007, 06:03

Peet wrote:Would have by now if my damn mobo hadn't died.

<---------no longer an asus fan

I should use that as my excuse!
Sorry people, my asus mobo died.

No really, it did.

Working on it. >_>

EDIT: Oh. >_< My only copy of the patch is on the sata drive that can't be accessed by any other computer in the house >_< yeah this one might take about a week.

MadRat · Post by **MadRat** » 05 Oct 2007, 09:06

trepan wrote:If nothing else, I'd like to see a way to disable this feature.
If lurker doesn't get his patch in, I'll add a 'noBonusShield'
or a scaling tag. I'm all for anisotropic shielding, but this
seems like a weak way of doing it

What he said. And it should be as easy as a simple line in the modinfo.tdf to disable it. Doubling of damage for flanking is completely wrong. If anything a bonus should be applied shield side only.

KDR_11k · Post by **KDR_11k** » 05 Oct 2007, 11:17

Has any of that been committed yet? Either Lurker's or trepan's solution? I could produce a patch within half an hour if necessary, will probably use a modrules tag to set a default and a per-unit tag to override it since I'd assume most mods just want to categorically disable it.

MadRat · Post by **MadRat** » 05 Oct 2007, 14:44

Can you implement a setting for scale, too?

Really need a way to tie it into the cob so a damaged shield has the option to be disabled and then repaired under condition.

KDR_11k · Post by **KDR_11k** » 05 Oct 2007, 14:52

Shield? The bonusshield is not related to the shields, bonusshield is simply a mechanism that awards bonus damage on unit hits.

Spring RTS Engine

bonusShield is dead! Long live flankingBonus!

Did you know about this?