BoredJoe wrote:If my work isn't used, it should be on the grounds it isn't as good, not "You havn't discussed this before changing it, so we're not going to implement it."
You turn it around. What Tim said was: if you
do follow the process, you can be almost sure your contribution will be accepted.
(and not: if you do not follow the process, you can be sure your contribution will not be accepted)
IOW, if you follow the process it's the responsibility of the community to give as much critique as needed to get the quality high enough for inclusion.
If you don't follow the process it means there hasn't been any discussion yet so there is a bigger chance the outcome of the discussion is that it should not (yet) be included in the site.
Also TBH the real amount of steps is being exaggerated by AF and oversimplified by BoredJoe.
For example:
1) Say its bad
2) Say why its bad
This is a one liner in a post, and often it even is implied by the fact that you suggest a replacement. (You wouldn't suggest a replacement after all if it's good enough already...)
3) Suggest a replacement
This is a prototyping stage, it already happens for almost all contributions here, whether you want it or not. It is the post starting a new thread "I made this new logo, should it be on the site?".
4) Say how theyre going to replace it
For many (most?) stuff this is entirely obvious.
I want to replace the banner
How?
By making a new one in my favorite image editor
Duh, you don't even need to say that unless you are proposing architectural/technical changes for which it isn't immediately obvious (ie. there are multiple answers to the
how? question).
5) Seek approval and wait
6) Finally implement it and provide the diff
This already happens too. After the prototype people give comments and someone with SVN access says "looks nice, if you change this and tweak that it's good for inclusion".
Diff's don't make sense for images either, just upload them somewhere and paste the link your post (again, everyone does this already).
7) wait for it to be reviewed
8 ) wait for it to go on the site.
This is kinda obvious, we can't give everyone access to the live site so they can replace everything at the instant they finish it.
As for the reviewing, that already happened with the discussion and the seek approval and wait phases.
As for the SVN, Meltrax already proved there are always people willing to give the source as a single archive file so this isn't a problem either.
OTOH, while the steps given by BoredJoe may describe the process pretty well for images, formatting etc., that process is written down too simplistic for architectural/technical changes, for which there will always be some discussion beforehand (unless you want to risk developing something that is totally not wanted).
IOW,
Tim Blokdijk wrote:The dev. process is just describing something that is already being done only more structured.