Task: Map/mod install tool - Page 3

Task: Map/mod install tool

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

zizu
Posts: 14
Joined: 12 Jun 2006, 01:51

Post by zizu »

Tobi wrote:
hughperkins wrote:Soo... it might be useful, if its not already implicit in the tool, to have some way of checking that maps etc are valid and giving an informative message if they're not, like, "This map seems to have been corrupted. You may want to try downloading it again, possibly from a different download site".
Sounds like a great idea!
Yes it would be a nice feature.
I will make an updated version that thoroughly tests the archive before adding it to the mod/map directory.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

Zizu: any news on this?
zizu
Posts: 14
Joined: 12 Jun 2006, 01:51

Post by zizu »

Tobi wrote:Zizu: any news on this?
Good that you reminded me, I finished the new version a long time ago but I didn├óÔé¼Ôäót make a public release.

New in this version:
Reject corrupt maps/mods.
More and better error messages.
Bug fixes.

Source code + Pre-compiled binary:
Image
tinnut
Posts: 67
Joined: 09 Sep 2006, 08:17

Post by tinnut »

Thanks for this tool zizu, this is cool.
MelTraX
Posts: 470
Joined: 02 Jan 2007, 16:18

Post by MelTraX »

Maybe we should also include LuaUI widgets..

Although .lua files or not only for Spring, I doubt that anyone has them associated with something else (and we could make the association optional in the installer).

Widgets have a certain structure that should be easy to be recognized by the program. They are not forced to have a widget:GetInfo function in it but all widgets I saw do have it.. So the tool could just search for it and if it finds one it could move the widget to the widgets directory..
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

I found a bug, if moving a file with a name longer then 8.3 characters to a FAT32 partition (maybe other partition types too, didn't test) it converts the name to true 8.3 notation.

For example, Foothill_Basin_Redux-v02.sd7 becomes FOOTHI~2.SD7 after moving.

Any chance you could fix that zizu?

Another bug (or inconsistency rather):
If you double click a mod/map in the Spring folder, it says it is succesfully moved, unless it truncated the name to 8.3 in the process, then it says 'Cannot move, file already exists blahblah'. So in effect it says 'succesfully moved' for filenames that fit in 8.3 characters and it says 'cannot move, file already exists' for filenames that don't fit in 8.3 characters.
imbaczek
Posts: 3629
Joined: 22 Aug 2006, 16:19

Post by imbaczek »

wrt datadirs, spring should support at least two - system-wide and per-user. I don't want to run unionfs just for ~/.spring and I don't want to sudo copy every time I want to install a map or mod and I don't want to have redundant maps.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

There are no plans to remove the support for a practically infinite amount of datadirs.
User avatar
Neddie
Community Lead
Posts: 9406
Joined: 10 Apr 2006, 05:05

Post by Neddie »

Tim, AF, I expect you to resolve this disagreement honourably and move along.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

Tobi wrote:I found a bug...
I think I found it, seems it is a bug in Windows.

The following open command in the registry causes the file to be converted to 8.3 tilde notation:

Code: Select all

D:\Program Files\Spring2\ArchiveMover.exe "%1"
But the following seems to work fine when moving the same file to the same destination folder:

Code: Select all

"D:\Program Files\Spring2\ArchiveMover.exe" "%1"
So apparently quotes around an executable means don't convert all arguments to 8.3 notation :roll:

Still need to do final test after modifying it in installer though.
User avatar
clericvash
Posts: 1394
Joined: 05 Oct 2004, 01:05

Post by clericvash »

I take it that it is not a Windows only tool?

As Spring is supposed to be multi-platform so why should you guys commit windows only stuff?

Just my opinion....
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

Codewise it should be easy/trivial to port since it doesn't use platform independent code.

But modifying the build system to compile and install it and to write the right code for finding the install location on Linux isn't a high priority item on my to do list currently.

I do not think committing platform depending stuff is a bad thing in every case, there are inherent differences between Linux and Windows that sometimes may be a motivation to add a certain feature only on one of the two operating systems. (for example: ArchiveMover is only compiled on Windows currently, but OTOH Linux/Unix supports multiple data directories.)
User avatar
clericvash
Posts: 1394
Joined: 05 Oct 2004, 01:05

Post by clericvash »

In my honest opinion if we want more people form the Linux world to play then we need to get everything we can to the Linux users, it may start with one thing, but then more and more will go to Windows and not Linux.

I don't see a problem in having it put stuff in the users springrc in the home. If users want to move to another later, then let them.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

I don't see a problem either apart from a lack of time.
User avatar
clericvash
Posts: 1394
Joined: 05 Oct 2004, 01:05

Post by clericvash »

Well...get some time, haha :)
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

Or do it for him?
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

The current full and updating test installers contain ArchiveMover.exe, the necessary file associations and the new icons.

It would be cool if some people could test it with different browsers and report back here (ie. install a test build, download some map/mod file from unknown files and click open. Does the file end up with the correct name in the right folder?)

http://www.osrts.info/~buildbot/spring/ ... vn4176.exe
http://www.osrts.info/~buildbot/spring/ ... update.exe
Satirik
Lobby Developer
Posts: 1688
Joined: 16 Mar 2007, 18:27

Post by Satirik »

you should add a spring:// binder to that archivemover
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

That would require UF itnegration at which point you then have to integrate a downloader, and then the whole think rapidly escalates into an entire package management system.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

It is fine as it is for now.

Now, did anyone already test it?

I'd like to know whether it works fine with IE 6, IE 7, Opera.
Firefox seems to work, I could test that myself.
Post Reply

Return to “Engine”