bugs in CGlobalAICallback

[jcnossen]

This:

Code: Select all

const vector<CommandDescription>* CGlobalAICallback::GetUnitCommands(int unitid)
{
if(gs->teams[ai->team]->units.find(uh->units[unitid])==gs->teams[ai->team]->units.end()){
return &(uh->units[unitid]->commandAI->possibleCommands);
}
return 0;
}

const deque<Command>* CGlobalAICallback::GetCurrentUnitCommands(int unitid)
{
if(gs->teams[ai->team]->units.find(uh->units[unitid])==gs->teams[ai->team]->units.end()){
return &(uh->units[unitid]->commandAI->commandQue);
}
return 0;
}

should be

Code: Select all

const vector<CommandDescription>* CGlobalAICallback::GetUnitCommands(int unitid)
{
if(gs->teams[ai->team]->units.find(uh->units[unitid])!=gs->teams[ai->team]->units.end()){
return &(uh->units[unitid]->commandAI->possibleCommands);
}
return 0;
}

const deque<Command>* CGlobalAICallback::GetCurrentUnitCommands(int unitid)
{
if(gs->teams[ai->team]->units.find(uh->units[unitid])!=gs->teams[ai->team]->units.end()){
return &(uh->units[unitid]->commandAI->commandQue);
}
return 0;
}

(Notice the changing of == into != )
I suppose the purpose of units.find(...) is to prevent the AI from getting info about the units of other teams?

I was thinking, could I get sourceforge springrts access too?, so I can fix these little typos without spamming the forums....

[AF]

Isnt there a bug/patch submittion system at sourceforge for this sort of thing?

[SJ]

Ok I will fix that.

We had planned to not give out CVS access to that many ppl so that we can check each patch for correctness. But if you apply a few more good patches I guess we will give you direct access to the CVS.

But as Altani said there is a bug/patch submition system on sourceforge if you dont want to post in the forums.

[AF]

Altani?! Well at least I had a mention..