Bugfix for network error in 0.75b1

Bugfix for network error in 0.75b1

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Auswaschbar
Spring Developer
Posts: 1254
Joined: 24 Jun 2007, 08:34

Bugfix for network error in 0.75b1

Post by Auswaschbar »

I think I found the bug causing the networking problems.

When your infolog keeps saying "Unknown net msg in read ahead #", than its this one. Unfortunately I cant find anyone who has svn access so I post it here:

http://freenet-homepage.de/auswaschbar/bugfix.diff

This bug was caused by the new fragmentation buffer. There was only 1!!! buffer for all!!! network connections so if the server recieved the first part of a message, and then read data from another client, the half message was copied before the new one, messing up the server completely.
User avatar
Licho
Zero-K Developer
Posts: 3803
Joined: 19 May 2006, 19:13

Post by Licho »

I commited it
User avatar
Spawn_Retard
Posts: 1248
Joined: 21 Dec 2006, 14:36

Post by Spawn_Retard »

this new version of spring makes me so angry just thinking about it.

thanks for a patch, i should be able to play A game today . :/

i cant beleive you guys actually released a version of spring with so many problems.
Auswaschbar
Spring Developer
Posts: 1254
Joined: 24 Jun 2007, 08:34

Post by Auswaschbar »

you know, its pretty hard to find bugs when nobody is testing it...

If you want to help, you may test the new build http://www.osrts.info/~buildbot/spring/ ... vn3977.exe
Last edited by Auswaschbar on 16 Jul 2007, 21:13, edited 1 time in total.
User avatar
rattle
Damned Developer
Posts: 8278
Joined: 01 Jun 2006, 13:15

Post by rattle »

^
Spawn_Retard wrote:i cant beleive you guys actually released a version of spring with so many problems.
I can't believe you weren't there for testing the dev release. :P
User avatar
Neddie
Community Lead
Posts: 9406
Joined: 10 Apr 2006, 05:05

Post by Neddie »

Honestly, it was less buggy than I expected, given all of the changes. I missed out testing with them because of my work, what is your excuse?
User avatar
Zpock
Posts: 1218
Joined: 16 Sep 2004, 23:20

Post by Zpock »

Have some patience and faith in the devs to eventually fix those inevitable problems. Would you rather have spring development halting forever?
User avatar
Agon
Posts: 527
Joined: 16 May 2007, 18:33

Post by Agon »

And if I want to test I need to compile Spring myself.
But this isn´t realy a problem. Downloading and installing each source packages is a problem. Hope it will get Linux packages for stable, unstable and svn releases. And not only for one distribution or package format. Maybe a bit not related to the topic.
Good to have some bug-hunters and developers who are fixing bugs.
Auswaschbar
Spring Developer
Posts: 1254
Joined: 24 Jun 2007, 08:34

Post by Auswaschbar »

we have been able to play a 4v4 tangerine game for about 45 mins (includeing big armies, nukes etc.) without any problems (after that 1 player desynced, but game reached end anyways) so i assume this bug is fixed
User avatar
Neddie
Community Lead
Posts: 9406
Joined: 10 Apr 2006, 05:05

Post by Neddie »

Alright, so when will it be in the full installer, you think?
silv
Posts: 30
Joined: 25 May 2006, 07:24

Post by silv »

Auswaschbar wrote:we have been able to play a 4v4 tangerine game for about 45 mins (includeing big armies, nukes etc.) without any problems (after that 1 player desynced, but game reached end anyways) so i assume this bug is fixed
yeah, i was hosting with his version and he was the only other player in it who had the svn version. so it seems to work. great job :)

altho we had 1 player unable to join (said he crashed, maybe it would have worked for him with the svn client), so we played a 4:4 without him.
Auswaschbar
Spring Developer
Posts: 1254
Joined: 24 Jun 2007, 08:34

Post by Auswaschbar »

it works when the host is running the svn build i posted earlier (normal lobby joining), he can alsdo play with the released version.

I dont lnow when it is in full installer, you have to ask a dev
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

If I dont get hit by a bus I'll release 0.75b2 later this week.
User avatar
Acidd_UK
Posts: 963
Joined: 23 Apr 2006, 02:15

Post by Acidd_UK »

Tobi I forbid you from going near a road until it's out ;-) For your health, of course.
User avatar
Neddie
Community Lead
Posts: 9406
Joined: 10 Apr 2006, 05:05

Post by Neddie »

My hero!
User avatar
Caydr
Omnidouche
Posts: 7179
Joined: 16 Oct 2004, 19:40

Post by Caydr »

Spawn_Retard wrote:i cant beleive you guys actually released a version of spring with so many problems.
I can't believe there are people this stupid in the world.
imbaczek
Posts: 3629
Joined: 22 Aug 2006, 16:19

Post by imbaczek »

Spawn_Retard wrote:this new version of spring makes me so angry just thinking about it.

thanks for a patch, i should be able to play A game today . :/

i cant beleive you guys actually released a version of spring with so many problems.
Don't ask what spring can give you, ask what you can do to help spring! Like, test.
CautionToTheWind
Posts: 272
Joined: 30 May 2006, 17:06

Post by CautionToTheWind »

A bug-free Spring or your money back!
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

The first of every Spring release series was bug'd, .75 will get a b2 and its b3 to patch it up. In the mean time you can feel like a real men (beta tester) again. ;-) I mean nothing else gives you that warm and fuzzy community feeling then a hard crash back to desktop. :P
CautionToTheWind
Posts: 272
Joined: 30 May 2006, 17:06

Post by CautionToTheWind »

If you're gonna focus your efforts in fixing bugs, rather than add more features, the test betas should be more stable than the release.
Post Reply

Return to “Engine”