CanBuildAt() and hugely complicated code

[AF]

In spring you can test if a building can be built by checking if the heightdifference underneath a footprint is bigger than the max allowed height difference.

This would suggest:
if Biggestheigh - lowestheight > maxheightdiff
Then you cant build.

This is not true.

Instead there's a hugely longwinded process involving lots of loops and averaging calculations.

[zwzsg]

I remember complaining about that eons ago. Plus they interpreted MaxSlope as being in degree, while in TA it was just the height difference. The problem is that now most mods have adapted by changing their MaxSlope, and changing its behavior would force all mods to redo all their FBI.

[clericvash]

Is there not a way you could implement something better, and people can link it to the new one somehow without updating everything?

[Guessmyname]

actually, we'd just have to update moveinfo.tdf

[AF]

We could rewrite the one single function and return to OTA style quite easily, it'd invovle a lto less computation

Code: Select all

highest = lowestpossibleheight
lowest = highest
for each gamesquare in footprint
    if higher than highest
        highest = this height
    if lower than lowest
        lowest = this height

return (highest - lowest < MaxSlope)