1. I am 100% sure. I have my version and the one on SVN to compare against, and they're totally different animals. I think JC and I are now in agreement about why I wrote it the way I did at this point- we were arguing over three If statements and the structure of an argument, basically, not anything remotely crashy, CPU-eating, or horribly written.
Given how the rest of Spring's weapon code is written (a lot of it is very messy, tbh), I'm not even sure why we were arguing minutia, but meh, I think he was trying to drive home the concept of efficiency and not coding sloppily in general, and I learned a lot from the back-and-forth.
I cleaned up the style to adhere to Spring's general style rules, and in my final version I did the math steps a little different than the last code you can see in the thread about this, but it's doing the same math, with the same results, whereas this version is definately not

2. Changing anything about Spring's interface defaults, which already worked well and have been the same for nearly a year, without any public discussion ...


3. Not really, I guess, just a gripe I have been sitting on and need to either put on Mantis or fix myself

4. If you can fix it, you are my hero. Whether or not I can ever get a custom UnitIcon to work. BTW, I have one in the SVN version of NanoBlobs... I don't suppose I can get you to look at it and find out what went horribly wrong? I so, so wanted custom icons at release!
@IMSabbel:
The last time I checked, AAI did not work with NanoBlobs. Which means that other non-OTA-based-gameplay mods, of which there will be more and more of... aren't going to work. <shrugs> I will test the current version, maybe Submarine finally made it flexible enough to deal with mods that don't feature mexes

[EDIT]
And, after further looking, no AIs have been included with Spring, even though I asked Spring to install them. It installed some folders, but no working AIs, and it didn't even install good ol' "emptyai.dll". So, you must be working with a compile for Linux, which is great and all, but I don't have a working compile for 073b for Windows, and I am not about to figure out how to compile AAI right this minute

Furthermore, I just tested NanoBlobs 0.54 with AAI 0.7, and it crashed the first time something attacked the Lord. Am I done proving my point yet?