View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000908 | Spring engine | General | public | 2008-04-29 14:35 | 2012-06-27 02:29 |
| Reporter | KDR_11k | Assigned To | abma | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000908: Units return friendly fire | ||||
| Description | A unit that is damaged by a weapon fired by an allied (same ally team but not same team) unit will target that unit and shoot at it. It's easiest to reproduce by using a mod with buildlasers (e.g. SimBase, Kernel Panic), putting two teams into one allyteam and driving one team's units through the other team's buildlasers. | ||||
| Additional Information | This is doubly weird as even if the targetting allows picking an ally the code should make the unit stop shooting at the next check (unless it's a usertarget). | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
One occurence was described here: http://spring.clan-sy.com/phpbb/viewtopic.php?p=270586 |
|
|
My simple tests show that gs->Ally doesn't work in CUnit::SetLastAttacker. I'm confused what gs->Ally should mean. Currently it is true only for a=b, at least that's what my gdb says. edit: nvm, adding gs->AlliedTeams, this should fix it. |
|
|
The check in SetLastAttacker should probably read if (gs->Ally(team, attacker->team) || gs->Ally(attacker->team, team)) { return; } since the allies matrix is not symmetric. |
|
|
did just that. r5824. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-04-29 14:35 | KDR_11k | New Issue | |
| 2008-04-30 13:18 | tvo | Note Added: 0002190 | |
| 2008-05-02 20:39 | imbaczek | Note Added: 0002217 | |
| 2008-05-02 20:43 | imbaczek | Note Edited: 0002217 | |
| 2008-05-02 20:47 | Kloot | Note Added: 0002218 | |
| 2008-05-02 20:59 | imbaczek | Note Added: 0002219 | |
| 2008-05-02 20:59 | imbaczek | Status | new => resolved |
| 2012-06-27 02:27 | abma | Status | resolved => assigned |
| 2012-06-27 02:27 | abma | Assigned To | => abma |
| 2012-06-27 02:29 | abma | Status | assigned => resolved |
| 2012-06-27 02:29 | abma | Resolution | open => fixed |
