0000835: SEGV's caused by team->leader being -1

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000835

Spring engine

General

public

2008-02-02 15:11

2008-02-02 16:21

Reporter

Kloot

Assigned To

Auswaschbar

Priority

high

Severity

crash

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

Target Version

Fixed in Version

Summary

0000835: SEGV's caused by team->leader being -1

Description

The recent changes to CTeam mean that if team->leader is not
initialized to a number >= 0 Spring crashes whenever that field
is used as an arry index. Steps to reproduce:

1. start a local game via the Commanders script
2. enable cheats
3. type .spectator
4. move your cursor over team 1's commander
5. crash in CTooltipConsole::MakeUnitString() at:

gs->players[ gs->Team(unit->team)->leader ]->playerName.c_str()

or:

1. see above
2. see above
3. .give some tanks near where team 1's commander is spawned
4. wait for the tanks to kill the other comm, but don't mouse-over it
5. crash in CTeam::Died() at:

logOutput.Print(..., ..., gs->players[ leader ]->playerName.c_str());

Tags

No tags attached.

Checked infolog.txt for Errors

Attached Files

Relationships

Relationships

Notes

~0001937

Auswaschbar (reporter)

2008-02-02 16:21

When team->leader is not initialized, there is no leader, so it shouldn't be accessed. Fixed it everywhere I found it.

But I may have missed a place. If so, reopen plz.

Notes

Date Modified	Username	Field	Change
Issue History
2008-02-02 15:11	Kloot	New Issue
2008-02-02 16:21	Auswaschbar	Status	new => resolved
2008-02-02 16:21	Auswaschbar	Resolution	open => fixed
2008-02-02 16:21	Auswaschbar	Assigned To	=> Auswaschbar
2008-02-02 16:21	Auswaschbar	Note Added: 0001937

Issue History