2019-12-13 17:25 CET
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000655Spring engineGeneralpublic2007-10-12 09:102008-04-30 17:15
Reporterhoijui 
Assigned Totvo 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0000655: [patch] Command and CommandQueue minor changes
DescriptionIn Command, there were two ';' missing.
In CommandQueue, the enum QueueType was in the private section (before public:), but was used as return statement by the public function GetType(). I moved the enum QueueType into the public section.

Additional InformationI saw these things only because SWIG reported the mas errors/inconsistencies.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files
  • diff file icon Command.diff (1,185 bytes) 2007-10-12 09:10 - 
    Index: rts/Sim/Units/CommandAI/Command.h
===================================================================
--- rts/Sim/Units/CommandAI/Command.h	(revision 4535)
+++ rts/Sim/Units/CommandAI/Command.h	(working copy)
@@ -105,7 +105,7 @@
 
 
 struct CommandDescription {
-	CR_DECLARE_STRUCT(CommandDescription)
+	CR_DECLARE_STRUCT(CommandDescription);
 	CommandDescription()
 	: showUnique(false),
 	  onlyKey(false),
@@ -110,7 +110,7 @@
 	: showUnique(false),
 	  onlyKey(false),
 	  onlyTexture(false),
-	  disabled(false) {}
+	  disabled(false) {};
 
 	bool SetupCommandDefaults(int id);
 
Index: rts/Sim/Units/CommandAI/CommandQueue.h
===================================================================
--- rts/Sim/Units/CommandAI/CommandQueue.h	(revision 4535)
+++ rts/Sim/Units/CommandAI/CommandQueue.h	(working copy)
@@ -13,14 +13,14 @@
 	friend class CCommandAI;
 	friend class CFactoryCAI;
 
-	enum QueueType {
-		CommandQueueType,
-		NewUnitQueueType,
-		BuildQueueType
-	};
-
 	CR_DECLARE(CCommandQueue);
 	public:
+		enum QueueType {
+			CommandQueueType,
+			NewUnitQueueType,
+			BuildQueueType
+		};
+
 		inline QueueType GetType() const { return queueType; }
 
 	public:
    diff file icon Command.diff (1,185 bytes) 2007-10-12 09:10 +

-Relationships
+Relationships

-Notes

~0002203

tvo (reporter)

2008-04-30 17:15

 Oh forgot this one because it was in the AI section.

Anyway it is committed now, in r5809. Thank you for the patch.
+Notes

-Issue History
Date Modified Username Field Change
2007-10-12 09:10 hoijui New Issue
2007-10-12 09:10 hoijui File Added: Command.diff
2008-04-28 21:32 tvo Summary Command and CommandQueue minor changes => [patch] Command and CommandQueue minor changes
2008-04-30 17:06 tvo Project AI => Spring engine
2008-04-30 17:15 tvo Status new => resolved
2008-04-30 17:15 tvo Resolution open => fixed
2008-04-30 17:15 tvo Assigned To => tvo
2008-04-30 17:15 tvo Note Added: 0002203
+Issue History