View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000649 | Spring engine | General | public | 2007-09-29 13:30 | 2007-10-13 16:00 |
| Reporter | redstar | Assigned To | imbaczek | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000649: [PATCH] Unitsync Extra functions, doxygen, and extra archivescanner data | ||||
| Description | This patch adds 2 new tags game= and shortgame= to modinfo.tdf and exposes them to unitsync. The patch also exposes these 2 fields and the values of several other modinfo.tdf tags to lobbies in unitsync. These extra functions have doxygen commenting, and commenting was added to several other functions. A Commit of this patch will b followed up by updates to the java interface | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
this patch causes instability of both tasclient and springlobby, please test and fix. at least, that's what it looks like, even though i can't see anything obviously wrong. maybe something else is broken. |
|
|
There's nothing in the patch that could cause that. The only new code that would ever get executed by tasclient and spring lobby are the 2 lines: + md.game = p->SGetValueDef("", (section + "\\Game").c_str()); + md.shortGame = p->SGetValueDef("", (section + "\\ShortGame").c_str()); However I will remake the patch as it seems the doxygen comments weren't saved before I made the patch |
|
|
yeah, I reversed the patch and lobbies were still crashing when joining and exiting. this needs further investigation. |
|
|
committed this in r4561 since apparently lobby devs don't have any objections. thanks for the patch. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-09-29 13:30 | redstar | New Issue | |
| 2007-09-29 13:30 | redstar | File Added: unitsyncGameandextrafunctions.patch | |
| 2007-10-02 00:38 | imbaczek | Note Added: 0001327 | |
| 2007-10-02 00:39 | imbaczek | Note Edited: 0001327 | |
| 2007-10-02 00:43 | redstar | Note Added: 0001328 | |
| 2007-10-02 00:47 | redstar | File Added: unitsyncGameandextrafunctions2.patch | |
| 2007-10-02 10:36 | imbaczek | Note Added: 0001329 | |
| 2007-10-13 16:00 | imbaczek | Status | new => resolved |
| 2007-10-13 16:00 | imbaczek | Resolution | open => fixed |
| 2007-10-13 16:00 | imbaczek | Assigned To | => imbaczek |
| 2007-10-13 16:00 | imbaczek | Note Added: 0001347 |
