2020-10-01 02:48 CEST

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0006414Spring engineGeneralpublic2020-08-04 17:32
ReporterBeherith 
Assigned ToKloot 
PrioritynormalSeveritytweakReproducibilityalways
StatusresolvedResolutionfixed 
Product Version104.0 +git 
Target VersionFixed in Version104.0 +git 
Summary0006414: Maximum texture atlas size is only 2k by 2k, which we have run out of for CEGs.
DescriptionWhile the projectile texture atlas has served us perfectly well, we have run out of space on it, especially for larger bitmaps of 512 and 1k that we wish to use for environmental effect cegs.

Could we please have the maximum size upped to 4k, or whatever is the maximum of the GPU in question?

Thank you!
Steps To ReproduceBy using plenty of nice CEGs.
Additional InformationWhere the hardcoded maximum is defined:

https://github.com/spring/spring/blob/transition/rts/Rendering/Textures/IAtlasAllocator.h#L17

Where the previous GPU supported maximum has been removed:

https://github.com/spring/spring/blob/transition/rts/Rendering/Textures/TextureAtlas.cpp#L44
Tagstexture size limit
Checked infolog.txt for ErrorsYes
Attached Files

-Relationships
+Relationships

-Notes

~0020501

IceXuick (reporter)

Yes please.

When added like ±20 new 256x256 projectile textures all ceg textures turn to white blocks.(in latest BAR version)

~0020502

Anonymous (viewer)

Fix 82eb930566556f4f96e015d0138fbddd433fa1d4 committed to develop branch: fix 0006414, repo: spring changeset id: 37965

~0020503

Anonymous (viewer)

Fix d3c0012d2fe798a583759683e55cc6f7fcd00e55 committed to maintenance branch: fix 0006414, repo: spring changeset id: 37966

~0020504

Anonymous (viewer)

Fix dfd2661dc9faf83f29f376611e1a815ea1ab8bbc committed to transition branch: fix 0006414, repo: spring changeset id: 37967
+Notes

-Related Changesets
spring: maintenance d3c0012d
Timestamp: 2020-08-04 14:47:51
Author: rtri
Details ] Diff ]
fix 0006414
mod - rts/Rendering/Models/3DModel.cpp Diff ] File ]
mod - rts/Rendering/Textures/IAtlasAllocator.h Diff ] File ]
mod - rts/Rendering/Textures/RowAtlasAlloc.cpp Diff ] File ]
mod - rts/Rendering/Textures/RowAtlasAlloc.h Diff ] File ]
mod - rts/Rendering/Textures/TextureAtlas.cpp Diff ] File ]
mod - rts/Rendering/Textures/TextureAtlas.h Diff ] File ]
mod - rts/Sim/Units/Scripts/UnitScript.cpp Diff ] File ]
spring: transition dfd2661d
Timestamp: 2020-08-04 14:49:46
Author: rtri
Details ] Diff ]
fix 0006414
mod - rts/Rendering/Models/3DModel.cpp Diff ] File ]
mod - rts/Rendering/Textures/IAtlasAllocator.h Diff ] File ]
mod - rts/Rendering/Textures/RowAtlasAlloc.cpp Diff ] File ]
mod - rts/Rendering/Textures/RowAtlasAlloc.h Diff ] File ]
mod - rts/Rendering/Textures/TextureAtlas.cpp Diff ] File ]
mod - rts/Rendering/Textures/TextureAtlas.h Diff ] File ]
mod - rts/Sim/Units/Scripts/UnitScript.cpp Diff ] File ]
spring: develop 82eb9305
Timestamp: 2020-08-04 15:28:44
Author: rtri
Details ] Diff ]
fix 0006414
mod - rts/Rendering/Textures/IAtlasAllocator.h Diff ] File ]
mod - rts/Rendering/Textures/RowAtlasAlloc.cpp Diff ] File ]
mod - rts/Rendering/Textures/RowAtlasAlloc.h Diff ] File ]
mod - rts/Rendering/Textures/TextureAtlas.cpp Diff ] File ]
mod - rts/Rendering/Textures/TextureAtlas.h Diff ] File ]
mod - rts/Sim/Units/Scripts/UnitScript.cpp Diff ] File ]

+Related Changesets

-Issue History
Date Modified Username Field Change
2020-08-04 08:04 Beherith New Issue
2020-08-04 08:04 Beherith Tag Attached: texture size limit
2020-08-04 12:16 IceXuick Note Added: 0020501
2020-08-04 17:31 Changeset attached => spring develop 82eb9305
2020-08-04 17:31 Changeset attached => spring maintenance d3c0012d
2020-08-04 17:31 Anonymous Note Added: 0020502
2020-08-04 17:31 Anonymous Note Added: 0020503
2020-08-04 17:31 Changeset attached => spring transition dfd2661d
2020-08-04 17:31 Anonymous Note Added: 0020504
2020-08-04 17:32 Kloot Assigned To => Kloot
2020-08-04 17:32 Kloot Status new => resolved
2020-08-04 17:32 Kloot Resolution open => fixed
2020-08-04 17:32 Kloot Fixed in Version => 104.0 +git
+Issue History