2020-10-24 20:26 CEST

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0006408Spring engineLuapublic2020-07-19 19:27
Reportersprung 
Assigned ToKloot 
PrioritylowSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version104.0 +git 
Target VersionFixed in Version104.0 +git 
Summary0006408: VFS.FileExists seems to use wrong mode when loading defs
DescriptionDuring the defs loading phase, VFS.FileExists("foo", nil, VFS.MAP) returns true even when the file only exists gameside.
Steps To ReproduceSee the attached zip, it has a minimal reproduction mod and script (any map without unitdefs_posts should work).

My output:
[f=-000001] [LoadScreen::SetLoadMessage] text="Loading GameData Definitions"
[f=-000001] isInMap (should usually be false), true
[f=-000001] the FileExists was most likely a lie, Include() file missing 'gamedata/unitdefs_post.lua'
[f=-000001] [defs.lua] Error: Failed to load unitDefs
TagsNo tags attached.
Checked infolog.txt for ErrorsYes
Attached Files

-Relationships
+Relationships

-Notes

~0020472

Kloot (developer)

VFS.FileExists takes two arguments, not three.

if the second is nil the VFS_ZIP mode gets used by default.

~0020473

Anonymous (viewer)

Fix 1e55cf28c3b8ca0c77c49da864a720bf778774e3 committed to develop branch: fix 0006408, repo: spring changeset id: 37932

~0020474

Anonymous (viewer)

Fix fdd9ca6aa7b70409e1649ae4bebee082692356dc committed to maintenance branch: fix 0006408, repo: spring changeset id: 37933

~0020475

Anonymous (viewer)

Fix 5588635e042731acdca74b72356e3c7d05e3a2b3 committed to transition branch: fix 0006408, repo: spring changeset id: 37934
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2020-07-19 00:18 sprung New Issue
2020-07-19 00:18 sprung File Added: VFS.SDD.zip
2020-07-19 09:26 Kloot Note Added: 0020472
2020-07-19 19:25 Changeset attached => spring develop 1e55cf28
2020-07-19 19:25 Anonymous Note Added: 0020473
2020-07-19 19:25 Changeset attached => spring maintenance fdd9ca6a
2020-07-19 19:25 Anonymous Note Added: 0020474
2020-07-19 19:25 Changeset attached => spring transition 5588635e
2020-07-19 19:25 Anonymous Note Added: 0020475
2020-07-19 19:27 Kloot Assigned To => Kloot
2020-07-19 19:27 Kloot Status new => resolved
2020-07-19 19:27 Kloot Resolution open => fixed
2020-07-19 19:27 Kloot Fixed in Version => 104.0 +git
+Issue History