| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0006404 | Spring engine | General | public | 2020-07-09 10:41 | 2020-07-10 08:58 | ||||
| Reporter | buumi | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 104.0 +git | |||||||
| Summary | 0006404: 104.0.1-1510-g89bb8e3: SetUnitSensorRadius(unitID, "airLos", value) is setting both los and airLos | ||||||||
| Description | We noticed in Spring 1944 that calling SetUnitSensorRadius(unitID, "airLos", defaultLos) is setting both "airLos" and "los" while SetUnitSensorRadius(unitID, "los", defaultLos) is only setting "los". Relevant code section seems to be here: https://github.com/spring/spring/blob/develop/rts/Lua/LuaSyncedCtrl.cpp#L2492 It feels a bit weird behaviour and took some time to notice where our problem was. After finding the issue it was still "solvable" so it's not that critical. In case it is actually wanted behaviour, then feel free to close this issue. | ||||||||
| Steps To Reproduce | Spring.Echo("Setting los to: " .. 100) SetUnitSensorRadius(unitID, "los", 100) Spring.Echo("Setting airLos to: " .. 5) SetUnitSensorRadius(unitID, "airLos", 5) Spring.Echo("airLos after writing is: " .. GetUnitSensorRadius(unitID, "airLos")) Spring.Echo("los after writing is: " .. GetUnitSensorRadius(unitID, "los")) | ||||||||
| Additional Information | PR discussion from S44: https://github.com/spring1944/spring1944/pull/364 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | Irrelevant | ||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Anonymous (viewer) 2020-07-10 00:31 |
Fix 98e256dbe5c05f83f6c61a6392e34728dd3cc8ec committed to develop branch: fix 0006404, repo: spring changeset id: 37920 |
|
Anonymous (viewer) 2020-07-10 00:31 |
Fix 3737eb223d4acab8dcd235ddfd3e5bc54c6954a3 committed to maintenance branch: fix 0006404, repo: spring changeset id: 37921 |
| Notes |
| Related Changesets |
|||
|
spring: maintenance 3737eb22
Timestamp: 2020-07-10 00:24:24 Author: rtri [ Details ] [ Diff ] |
fix 0006404 | ||
| mod - rts/Lua/LuaSyncedCtrl.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/Scripts/UnitScript.cpp | [ Diff ] [ File ] | ||
|
spring: develop 98e256db
Timestamp: 2020-07-10 00:27:23 Author: rtri [ Details ] [ Diff ] |
fix 0006404 | ||
| mod - rts/Lua/LuaSyncedCtrl.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/Scripts/UnitScript.cpp | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-07-09 10:41 | buumi | New Issue | |
| 2020-07-10 00:31 | Changeset attached | => spring develop 98e256db | |
| 2020-07-10 00:31 | Anonymous | Note Added: 0020461 | |
| 2020-07-10 00:31 | Changeset attached | => spring maintenance 3737eb22 | |
| 2020-07-10 00:31 | Anonymous | Note Added: 0020462 | |
| 2020-07-10 08:58 | Kloot | Assigned To | => Kloot |
| 2020-07-10 08:58 | Kloot | Status | new => resolved |
| 2020-07-10 08:58 | Kloot | Resolution | open => fixed |
| 2020-07-10 08:58 | Kloot | Fixed in Version | => 104.0 +git |
| Issue History |