| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0006400 | Spring engine | Lua | public | 2020-06-17 20:34 | 2020-07-04 23:03 | ||||
| Reporter | Floris | ||||||||
| Assigned To | |||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | no change required | ||||||
| Product Version | 104.0 +git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0006400: Spring.AddUnitDamage doesnt apply damage | ||||||||
| Description | when i set the 3rd argument to 1 instead of 0/nil it does apply paralyze damage, so therefore the surrounding code must be correct application: https://github.com/beyond-all-reason/Beyond-All-Reason/blob/7e7a40e7f805a4316d3712296ac500519746b1a2/luarules/gadgets/unit_lightning_splash_dmg.lua#L61 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | Irrelevant | ||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Floris (reporter) 2020-06-17 21:37 |
setting the weaponid to -7 seems to have fixed it |
|
Kloot (developer) 2020-07-04 23:03 |
the weaponDefID callin argument of UnitDamaged should be passed on to AddUnitDamage, otherwise the engine will assume a value of -1 which gets eaten by UnitPreDamaged in https://github.com/beyond-all-reason/Beyond-All-Reason/blob/c102a616eabfb3286c43251b6e55175aba455109/luarules/gadgets/engine_hotfixes.lua#L75 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-06-17 20:34 | Floris | New Issue | |
| 2020-06-17 21:37 | Floris | Note Added: 0020418 | |
| 2020-07-04 23:03 | Kloot | Status | new => closed |
| 2020-07-04 23:03 | Kloot | Resolution | open => no change required |
| 2020-07-04 23:03 | Kloot | Note Added: 0020450 | |
| Issue History |