View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006400Spring engineLuapublic2020-06-17 20:342020-07-04 23:03
ReporterFloris Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Product Version104.0 +git 
Summary0006400: Spring.AddUnitDamage doesnt apply damage
Descriptionwhen i set the 3rd argument to 1 instead of 0/nil it does apply paralyze damage, so therefore the surrounding code must be correct

application:
https://github.com/beyond-all-reason/Beyond-All-Reason/blob/7e7a40e7f805a4316d3712296ac500519746b1a2/luarules/gadgets/unit_lightning_splash_dmg.lua#L61
TagsNo tags attached.
Checked infolog.txt for ErrorsIrrelevant

Activities

Floris

2020-06-17 21:37

reporter   ~0020418

setting the weaponid to -7 seems to have fixed it

Kloot

2020-07-04 23:03

developer   ~0020450

the weaponDefID callin argument of UnitDamaged should be passed on to AddUnitDamage, otherwise the engine will assume a value of -1 which gets eaten by UnitPreDamaged in https://github.com/beyond-all-reason/Beyond-All-Reason/blob/c102a616eabfb3286c43251b6e55175aba455109/luarules/gadgets/engine_hotfixes.lua#L75

Issue History

Date Modified Username Field Change
2020-06-17 20:34 Floris New Issue
2020-06-17 21:37 Floris Note Added: 0020418
2020-07-04 23:03 Kloot Status new => closed
2020-07-04 23:03 Kloot Resolution open => no change required
2020-07-04 23:03 Kloot Note Added: 0020450