2020-09-27 22:53 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0006374Spring engineGeneralpublic2020-03-26 22:39
ReporterGoogle_Frog 
Assigned Togajop 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version104.0 +git 
Target VersionFixed in Version 
Summary0006374: Nanoframes decloak units
DescriptionPreviously nanoframes did not decloak units. Now they do. This is likely due to the cloaking mechanic rework that added some cloak callins to lua (and put more responsibility on lua).

I see no cheap way to replicate the old behaviour with lua. The cloak callins only pass the closest decloaking enemy unitID so cannot be used for filtering. Perhaps there could be a configurable filter.

Perhaps this could be implemented: https://springrts.com/mantis/view.php?id=2683

The comment "cloak behavior (energy drain, forced detection, etc) is now fully customisable via the AllowUnit{Cloak,Decloak} callins." is technically correct but is not useful. It was always possible to rewrite closking completely in lua. I don't think doing so is viable though because doing a large number of GetUnitsInSphere checks from lua is expensive.
TagsNo tags attached.
Checked infolog.txt for ErrorsIrrelevant
Attached Files

-Relationships
+Relationships

-Notes

~0020364

Google_Frog (reporter)

I can confirm that 104.0.1-287-gf7b0fcc works.

~0020365

Google_Frog (reporter)

104.0.1-1398-g7442945 and 104.0.1-1429-g1add37c does not. I don't have any other builds lying around, but "fix 0006306" is between these two builds and this change appears to make units with no LOS able to decloak. See https://springrts.com/mantis/view.php?id=6306

~0020366

Google_Frog (reporter)

PRs that resolve the issue:
 * https://github.com/spring/spring/pull/498
 * https://github.com/spring/spring/pull/499
+Notes

-Issue History
Date Modified Username Field Change
2020-03-21 01:31 Google_Frog New Issue
2020-03-21 02:14 Google_Frog Note Added: 0020364
2020-03-21 03:09 Google_Frog Note Added: 0020365
2020-03-21 04:33 Google_Frog Note Added: 0020366
2020-03-26 22:39 abma Assigned To => gajop
2020-03-26 22:39 abma Status new => resolved
2020-03-26 22:39 abma Resolution open => fixed
+Issue History