View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006355 | Spring engine | General | public | 2019-12-25 03:12 | 2019-12-31 00:53 |
| Reporter | raaar | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | new | Resolution | open | ||
| Product Version | 104.0 +git | ||||
| Summary | 0006355: units with turninplace=false lose too much speed when turning | ||||
| Description | units with turninplace=false lose too much speed when turning. This happens regardless of how sharp the turn is, with the only difference being that it takes longer to make a sharper turn. To work around this I have set turnInPlaceSpeedLimit = maxVelocity on unitdefs_post.lua turnInPlaceAngleLimit apparently does nothing. | ||||
| Steps To Reproduce | This is relatively easy to test on metal factions as the tooltip shows the selected unit's speed. To see the issue you just need to remove the turnInPlaceSpeedLimit on unitdefs_post.lua and spawn "aven_racer" or another fast unit. | ||||
| Additional Information | The drawback of setting turnInPlaceSpeedLimit = maxVelocity is that fast units will run into cliffs and get stuck or just bump into things when making wide turns. It'd be nice if they could make slow but sharp turns in those situations specifically. | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | Irrelevant | ||||
|
|
https://github.com/spring/spring/blob/5720d78bcc53dfb402e640e2a031944eace22bfb/rts/Sim/Units/UnitDef.h#L143 Not set- at default? Isue can be closed? |
|
|
https://github.com/spring/spring/blob/222160cd7b6ca45b7211bcf177bada06becd3c79/rts/Sim/MoveTypes/GroundMoveType.cpp#L817 |
|
|
So its turnMaxSpeed that is clamping it? |
|
|
The expected behavior is that, instead of dropping to turnInPlaceSpeedLimit on every turn, there is some angle setting where if the turn angle is lower, the unit will not lose any speed. Maybe turnInPlaceAngleLimit could be used for that purpose for units with turninplace=false. |
