2020-08-06 01:10 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0006355Spring engineGeneralpublic2019-12-31 00:53
Reporterraaar 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
Product Version104.0 +git 
Target VersionFixed in Version 
Summary0006355: units with turninplace=false lose too much speed when turning
Descriptionunits with turninplace=false lose too much speed when turning. This happens regardless of how sharp the turn is, with the only difference being that it takes longer to make a sharper turn.

To work around this I have set turnInPlaceSpeedLimit = maxVelocity on unitdefs_post.lua

turnInPlaceAngleLimit apparently does nothing.
Steps To ReproduceThis is relatively easy to test on metal factions as the tooltip shows the selected unit's speed.

To see the issue you just need to remove the turnInPlaceSpeedLimit on unitdefs_post.lua and spawn "aven_racer" or another fast unit.
Additional InformationThe drawback of setting turnInPlaceSpeedLimit = maxVelocity is that fast units will run into cliffs and get stuck or just bump into things when making wide turns. It'd be nice if they could make slow but sharp turns in those situations specifically.
TagsNo tags attached.
Checked infolog.txt for ErrorsIrrelevant
Attached Files

-Relationships
+Relationships

-Notes

~0020273

PicassoCT (reporter)

https://github.com/spring/spring/blob/5720d78bcc53dfb402e640e2a031944eace22bfb/rts/Sim/Units/UnitDef.h#L143

Not set- at default?

Isue can be closed?

~0020274

PicassoCT (reporter)

https://github.com/spring/spring/blob/222160cd7b6ca45b7211bcf177bada06becd3c79/rts/Sim/MoveTypes/GroundMoveType.cpp#L817

~0020275

PicassoCT (reporter)

So its turnMaxSpeed that is clamping it?

~0020281

raaar (reporter)

The expected behavior is that, instead of dropping to turnInPlaceSpeedLimit on every turn, there is some angle setting where if the turn angle is lower, the unit will not lose any speed.

Maybe turnInPlaceAngleLimit could be used for that purpose for units with turninplace=false.
+Notes

-Issue History
Date Modified Username Field Change
2019-12-25 03:12 raaar New Issue
2019-12-30 10:36 PicassoCT Note Added: 0020273
2019-12-30 10:39 PicassoCT Note Added: 0020274
2019-12-30 10:46 PicassoCT Note Added: 0020275
2019-12-31 00:53 raaar Note Added: 0020281
+Issue History