View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006321Spring engineBuildbotpublic2019-10-14 01:282019-10-24 15:14
Reporterlhog Assigned Tohokomoko  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version104.0 +git 
Summary0006321: missing tiff support in devil with mingwlibs64
DescriptionI noticed that there is a difference of how map and some selected features look when compared the same spring build on win64 and win32.

My theory is that in some cases textures are loaded incorrectly:
1. In case of failed trees this is a teamcolor that makes them red
2. In case of map, the specular map has probably got overbright.

I'm almost certain it started to happen after something was recently done to DevIL.

Tried different mods: ZK & BAR. Also tried to disable luarules, luagaia & luaui disable
Additional InformationTested on

https://springrts.com/dl/buildbot/default/maintenance/104.0.1-1412-g9391542/win32/
https://springrts.com/dl/buildbot/default/maintenance/104.0.1-1412-g9391542/win64/
TagsNo tags attached.
Attached Files
win64map.jpg (Attachment missing)
win32map.jpg (Attachment missing)
win64trees.jpg (Attachment missing)
Checked infolog.txt for ErrorsYes

Relationships

related to 0006299 resolvedhokomoko win64 builds still broken 

Activities

lhog

2019-10-14 01:29

reporter   ~0020182

win32 map

lhog

2019-10-14 01:29

reporter   ~0020183

trees on win64

lhog

2019-10-14 01:29

reporter   ~0020184

trees on win32
win32trees.jpg (Attachment missing)

lhog

2019-10-14 02:32

reporter   ~0020185

I've checked the map package and it looks like the presumably failing textures are all in .TIFF format. Looks like Win64 can't open some or all TIFFs correctly.

lhog

2019-10-14 02:46

reporter   ~0020186

Looks like win64 libIL.dll is built without TIFF support
http://clip2net.com/clip/m330814/thumb800/b1db5-clip-34kb.png

Win32 has ilLoadTiff references inside the dll, but win64 does not.

abma

2019-10-16 20:29

administrator   ~0020189

is there something related in infolog.txt?

i would expect some error message that .tiff can't be loaded.

lhog

2019-10-16 21:51

reporter   ~0020190

No there was nothing interesting in the infolog.

I think by now the issue has been identified
>> Win32 has ilLoadTiff references inside the dll, but win64 does not.
So by now it's more about fixing the issue rather than identifying it.

abma

2019-10-16 22:29

administrator   ~0020191

so this error message is not shown?
https://github.com/spring/spring/blob/develop/rts/Rendering/Textures/Bitmap.cpp#L530

are you sure?

if so, this is a bad bug, too.

abma

2019-10-16 22:33

administrator   ~0020192

also how to reproduce? which exact map / game?

lhog

2019-10-16 23:05

reporter   ~0020194

Ravaged v2. ZK and BAR had it both.
The screenshots above were made on Tabula v4

abma

2019-10-16 23:30

administrator   ~0020195

please attach infolog.txt when it fails. your description is inaccurate, "Ravaged v2" doesn't exist: https://api.springfiles.com/?springname=Ravaged%20v2

abma

2019-10-16 23:37

administrator   ~0020196

also when trying to reproduce, i'm getting this error in infolog.txt:

[f=-000001] Error: [BMP::Load] invalid bitmap "unittextures/ad0_bushes_1.tif" (loaded=0)

so, you did not check infolog.txt or ...?

next time, please just add infolog.txt, this would have answered all my questions.

lhog

2019-10-17 00:03

reporter   ~0020197

Sorry, not sure how I missed that.

hokomoko

2019-10-19 14:18

developer   ~0020200

I didn't compile tiff because I never thought anyone uses it.
Also: Why the hell are people using tiff????

hokomoko

2019-10-19 14:53

developer   ~0020201

I've updated mingwlibs64, should work now, I think.

abma

2019-10-24 15:14

administrator   ~0020205

-> https://springrts.com/phpbb/viewtopic.php?f=12&t=40285

Issue History

Date Modified Username Field Change
2019-10-14 01:28 lhog New Issue
2019-10-14 01:28 lhog File Added: win64map.jpg
2019-10-14 01:29 lhog File Added: win32map.jpg
2019-10-14 01:29 lhog Note Added: 0020182
2019-10-14 01:29 lhog File Added: win64trees.jpg
2019-10-14 01:29 lhog Note Added: 0020183
2019-10-14 01:29 lhog File Added: win32trees.jpg
2019-10-14 01:29 lhog Note Added: 0020184
2019-10-14 02:32 lhog Note Added: 0020185
2019-10-14 02:46 lhog Note Added: 0020186
2019-10-16 20:28 abma Severity minor => major
2019-10-16 20:28 abma Category General => Buildbot
2019-10-16 20:28 abma Summary Apparently some textures fail to load on Win64 builds => missing tiff support in devil with mingwlibs64
2019-10-16 20:28 abma Checked infolog.txt for lua Errors Yes => |Yes|
2019-10-16 20:29 abma Assigned To => abma
2019-10-16 20:29 abma Status new => feedback
2019-10-16 20:29 abma Note Added: 0020189
2019-10-16 20:30 abma Relationship added related to 0006299
2019-10-16 21:51 lhog Note Added: 0020190
2019-10-16 21:51 lhog Status feedback => assigned
2019-10-16 22:29 abma Note Added: 0020191
2019-10-16 22:29 abma Assigned To abma =>
2019-10-16 22:29 abma Status assigned => feedback
2019-10-16 22:33 abma Note Added: 0020192
2019-10-16 23:05 lhog Note Added: 0020194
2019-10-16 23:05 lhog Status feedback => new
2019-10-16 23:30 abma Note Added: 0020195
2019-10-16 23:30 abma Status new => feedback
2019-10-16 23:37 abma Note Added: 0020196
2019-10-17 00:03 lhog Note Added: 0020197
2019-10-17 00:03 lhog Status feedback => new
2019-10-19 14:18 hokomoko Note Added: 0020200
2019-10-19 14:53 hokomoko Assigned To => hokomoko
2019-10-19 14:53 hokomoko Status new => feedback
2019-10-19 14:53 hokomoko Note Added: 0020201
2019-10-20 16:36 hokomoko Status feedback => resolved
2019-10-20 16:36 hokomoko Resolution open => fixed
2019-10-24 15:14 abma Note Added: 0020205