| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0006103 | Spring engine | General | public | 2018-12-17 16:41 | 2018-12-17 19:31 | ||||
| Reporter | gajop | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | feature | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0006103: Allow features to have custom max metal/energy | ||||||||
| Description | Motivated by http://zero-k.info/Forum/Post/195139#195139 . Setting feature metal, energy, reclaimTime and reclaimLeft isn't enough to truly customize feature resources as per-tick reclaim seems to be based on feature def values: https://github.com/spring/spring/blob/develop/rts/Sim/Features/Feature.cpp#L353-L354 I think it would be nice to override max metal & energy so we don't have to create new defs just for this. Any objections? | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for lua Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2018-12-17 19:22 |
Fix 70cad7d460aec843b6f23dac4327199c4ae2e0af committed to develop branch: fix 0006103 Spring.SetFeatureResources can now set the maximum resources via optional arguments 6 and 7, repo: spring changeset id: 11237 |
|
Kloot (developer) 2018-12-17 19:31 |
Fix aa71497a62d92d959dde52c9a39eb51f79d5c7e3 committed to maintenance branch: fix 0006103 Spring.SetFeatureResources can now set the maximum resources via optional arguments 6 and 7, repo: spring changeset id: 11240 |
| Notes |
| Related Changesets |
|||
|
spring: develop 70cad7d4
Timestamp: 2018-12-17 19:18:12 Author: Kloot [ Details ] [ Diff ] |
fix 0006103 Spring.SetFeatureResources can now set the maximum resources via optional arguments 6 and 7 |
||
| mod - rts/Lua/LuaSyncedCtrl.cpp | [ Diff ] [ File ] | ||
| mod - rts/Lua/LuaSyncedRead.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Features/Feature.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Features/Feature.h | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/CommandAI/BuilderCAI.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/CommandAI/BuilderCAI.h | [ Diff ] [ File ] | ||
|
spring: maintenance aa71497a
Timestamp: 2018-12-17 19:18:12 Author: Kloot [ Details ] [ Diff ] |
fix 0006103 Spring.SetFeatureResources can now set the maximum resources via optional arguments 6 and 7 |
||
| mod - rts/Lua/LuaSyncedCtrl.cpp | [ Diff ] [ File ] | ||
| mod - rts/Lua/LuaSyncedRead.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Features/Feature.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Features/Feature.h | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/CommandAI/BuilderCAI.cpp | [ Diff ] [ File ] | ||
| mod - rts/Sim/Units/CommandAI/BuilderCAI.h | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-12-17 16:41 | gajop | New Issue | |
| 2018-12-17 19:22 | Kloot | Changeset attached | => spring develop 70cad7d4 |
| 2018-12-17 19:22 | Kloot | Note Added: 0019620 | |
| 2018-12-17 19:22 | Kloot | Assigned To | => Kloot |
| 2018-12-17 19:22 | Kloot | Status | new => resolved |
| 2018-12-17 19:22 | Kloot | Resolution | open => fixed |
| 2018-12-17 19:31 | Kloot | Changeset attached | => spring maintenance aa71497a |
| 2018-12-17 19:31 | Kloot | Note Added: 0019621 | |
| Issue History |