| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005937 | Spring engine | General | public | 2018-03-20 19:18 | 2018-03-20 19:30 | ||||
| Reporter | lamer | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 104.0 +git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005937: Unable to compile 104.0.1-320-gbdc6060-maintenance with gcc 7.3.1 | ||||||||
| Description | Compilation with gcc 7.3.1 fails with error: /home/bob/games/spring/spring/rts/Sim/Projectiles/ExplosionGenerator.cpp: In member function ‘void CExplosionGeneratorHandler::ParseExplosionTables()’: /home/bob/games/spring/spring/rts/Sim/Projectiles/ExplosionGenerator.cpp:222:2: error: static assertion failed static_assert(sizeof(LuaParser) <= sizeof(exploParserMem), ""); ^~~~~~~~~~~~~ /home/bob/games/spring/spring/rts/Sim/Projectiles/ExplosionGenerator.cpp:229:109: warning: placement new constructing an object of type ‘LuaParser’ and size ‘640’ in a region of type ‘uint8_t [600] {aka unsigned char [600]}’ and size ‘600’ [-Wplacement-new=] exploParser = new (exploParserMem) LuaParser("gamedata/explosions.lua", SPRING_VFS_MOD_BASE, SPRING_VFS_ZIP); ^ /home/bob/games/spring/spring/rts/Sim/Projectiles/ExplosionGenerator.cpp:230:114: warning: placement new constructing an object of type ‘LuaParser’ and size ‘640’ in a region of type ‘uint8_t [600] {aka unsigned char [600]}’ and size ‘600’ [-Wplacement-new=] aliasParser = new (aliasParserMem) LuaParser("gamedata/explosion_alias.lua", SPRING_VFS_MOD_BASE, SPRING_VFS_ZIP); ^ [ 45%] Building CXX object AI/Skirmish/Shard/CMakeFiles/Shard.dir/src/API/spring/SpringMap.cpp.o make[3]: *** [rts/Sim/CMakeFiles/engineSim.dir/build.make:1671: rts/Sim/CMakeFiles/engineSim.dir/Projectiles/ExplosionGenerator.cpp.o] Error 1 make[2]: *** [CMakeFiles/Makefile2:4099: rts/Sim/CMakeFiles/engineSim.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs.... | ||||||||
| Steps To Reproduce | Archlinux # cmake . # make spring -j6 | ||||||||
| Additional Information | made next change (600 -> 640) in ExplosionGenerator.h - uint8_t exploParserMem[600]; - uint8_t aliasParserMem[600]; ---- + uint8_t exploParserMem[640]; + uint8_t aliasParserMem[640]; and spring did compile. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2018-03-20 19:29 |
Fix 9368030e9c9dcdb9c18844d1c464fee1c29fbbab committed to develop branch: fix 0005937, repo: spring changeset id: 9855 |
|
Kloot (developer) 2018-03-20 19:30 |
Fix ec88af39121f87389d875bd0485c60bd77e68dd5 committed to maintenance branch: fix 0005937, repo: spring changeset id: 9856 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-03-20 19:18 | lamer | New Issue | |
| 2018-03-20 19:29 | Kloot | Changeset attached | => spring develop 9368030e |
| 2018-03-20 19:29 | Kloot | Note Added: 0018926 | |
| 2018-03-20 19:29 | Kloot | Assigned To | => Kloot |
| 2018-03-20 19:29 | Kloot | Status | new => resolved |
| 2018-03-20 19:29 | Kloot | Resolution | open => fixed |
| 2018-03-20 19:30 | Kloot | Changeset attached | => spring maintenance ec88af39 |
| 2018-03-20 19:30 | Kloot | Note Added: 0018927 | |
| Issue History |